From: Paul Kocialkowski <contact@paulk.fr>
To: Giulio Benetti <giulio.benetti@micronovasrl.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output.
Date: Sun, 25 Mar 2018 16:09:13 +0200 [thread overview]
Message-ID: <1521986953.5301.4.camel@paulk.fr> (raw)
In-Reply-To: <1521662593-25468-4-git-send-email-giulio.benetti@micronovasrl.com>
[-- Attachment #1.1: Type: text/plain, Size: 1552 bytes --]
Hi,
Le mercredi 21 mars 2018 à 21:03 +0100, Giulio Benetti a écrit :
> The A20 supports RGB888 with H/V sync from LCD0. Add a pinmux setting
> for the needed pins.
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi
> b/arch/arm/boot/dts/sun7i-a20.dtsi
> index efb5607..bfe6728 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -922,6 +922,14 @@
> pins = "PI20", "PI21";
> function = "uart7";
> };
> +
> + lcd0_rgb888_pins: lcd0-rgb888-pins {
It would be more consistent with other pins definitions to have
underscores in both names and to indicate the index, such as:
lcd0_rgb888_pins: lcd0_rgb888_pins@0 {
This way, other set of pins for LCD (PH0-PH27) can be declared as @1
when they are needed in the future.
> + pins = "PD0", "PD1", "PD2", "PD3",
> "PD4", "PD5", "PD6", "PD7",
> + "PD8", "PD9", "PD10", "PD11",
> "PD12", "PD13", "PD14", "PD15",
> + "PD16", "PD17", "PD18",
> "PD19", "PD20", "PD21", "PD22", "PD23",
> + "PD24", "PD25", "PD26",
> "PD27";
> + function = "lcd0";
> + };
> };
>
> timer@1c20c00 {
--
Paul Kocialkowski,
developer of free digital technology and hardware support.
Website: https://www.paulk.fr/
Coding blog: https://code.paulk.fr/
Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-25 14:09 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 20:03 [PATCH 1/7] dt-bindings: add cdtech vendor prefix Giulio Benetti
2018-03-21 20:03 ` [PATCH 2/7] drm/panel: add panel CDTech S070_WV95_CT16 to panel-simple Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 3/7] drm/panel: add panel CDTech S043WQ26H-CT7 " Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 4/7] ARM: dts: sun7i: Add pinmux settings for LCD0 RGB888 output Giulio Benetti
2018-03-25 14:09 ` Paul Kocialkowski [this message]
2018-03-26 10:01 ` Maxime Ripard
2018-03-26 11:27 ` Giulio Benetti
2018-03-26 11:46 ` Maxime Ripard
2018-03-21 20:03 ` [PATCH 5/7] dt-bindings: add micronova vendor prefix Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 6/7] ARM: dts: sun7i: Add dts file for the A20-linova1-4_3 HMI Giulio Benetti
2018-03-26 22:24 ` Rob Herring
2018-03-21 20:03 ` [PATCH 7/7] ARM: dts: sun7i: Add dts file for the A20-linova1-7 HMI Giulio Benetti
2018-03-22 18:05 ` Maxime Ripard
2018-04-23 14:37 ` Giulio Benetti
2018-04-24 8:41 ` Maxime Ripard
2018-04-24 17:44 ` Giulio Benetti
2018-04-24 18:31 ` Giulio Benetti
2018-04-25 18:40 ` Maxime Ripard
2018-04-25 20:08 ` Giulio Benetti
2018-05-02 16:41 ` Giulio Benetti
2018-05-04 8:06 ` Maxime Ripard
2018-05-04 21:52 ` Giulio Benetti
2018-05-04 21:59 ` Sergey Suloev
2018-05-04 22:05 ` Giulio Benetti
2018-05-07 7:30 ` Maxime Ripard
2018-05-09 12:28 ` Giulio Benetti
2018-03-26 22:24 ` [PATCH 1/7] dt-bindings: add cdtech vendor prefix Rob Herring
2018-03-26 22:49 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521986953.5301.4.camel@paulk.fr \
--to=contact@paulk.fr \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=giulio.benetti@micronovasrl.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).