devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Li Jun <jun.li@nxp.com>
To: robh+dt@kernel.org, gregkh@linuxfoundation.org,
	heikki.krogerus@linux.intel.com, linux@roeck-us.net
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	peter.chen@nxp.com, linux-usb@vger.kernel.org,
	a.hajda@samsung.com, linux-imx@nxp.com, jun.li@nxp.com,
	shufan_lee@richtek.com
Subject: [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach
Date: Thu, 29 Mar 2018 00:06:15 +0800	[thread overview]
Message-ID: <1522253178-32414-11-git-send-email-jun.li@nxp.com> (raw)
In-Reply-To: <1522253178-32414-1-git-send-email-jun.li@nxp.com>

In case of drp toggling, we may need set correct cc value for role control
after attach as it may never been set.

Signed-off-by: Li Jun <jun.li@nxp.com>
---
 drivers/usb/typec/tcpm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 218c230..72d4232 100644
--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -2126,6 +2126,7 @@ static void tcpm_reset_port(struct tcpm_port *port)
 	tcpm_set_attached_state(port, false);
 	port->try_src_count = 0;
 	port->try_snk_count = 0;
+	port->cc_req = 0;
 }
 
 static void tcpm_detach(struct tcpm_port *port)
@@ -2361,6 +2362,8 @@ static void run_state_machine(struct tcpm_port *port)
 		break;
 
 	case SRC_ATTACHED:
+		if (!port->cc_req)
+			tcpm_set_cc(port, tcpm_rp_cc(port));
 		ret = tcpm_src_attach(port);
 		tcpm_set_state(port, SRC_UNATTACHED,
 			       ret < 0 ? 0 : PD_T_PS_SOURCE_ON);
@@ -2531,6 +2534,8 @@ static void run_state_machine(struct tcpm_port *port)
 		tcpm_set_state(port, SNK_UNATTACHED, PD_T_PD_DEBOUNCE);
 		break;
 	case SNK_ATTACHED:
+		if (!port->cc_req)
+			tcpm_set_cc(port, TYPEC_CC_RD);
 		ret = tcpm_snk_attach(port);
 		if (ret < 0)
 			tcpm_set_state(port, SNK_UNATTACHED, 0);
-- 
2.7.4

  parent reply	other threads:[~2018-03-28 16:06 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 16:06 [PATCH v4 00/13] staging: typec: tcpci: move out of staging Li Jun
2018-03-28 16:06 ` [PATCH v4 01/13] dt-bindings: connector: add properties for typec Li Jun
2018-03-29 19:54   ` Mats Karrman
2018-03-31  3:34     ` Jun Li
2018-04-03  8:29   ` Andrzej Hajda
2018-04-13 11:51     ` Jun Li
2018-04-30 11:23   ` Heikki Krogerus
2018-05-01  7:57     ` Jun Li
2018-03-28 16:06 ` [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun
2018-04-09 20:04   ` Rob Herring
2018-04-16 11:54     ` Jun Li
2018-04-16 14:28       ` Rob Herring
2018-04-19 14:47         ` Jun Li
2018-04-30  7:41   ` Mats Karrman
2018-05-01  7:54     ` Jun Li
2018-03-28 16:06 ` [PATCH v4 03/13] staging: typec: tcpci: add compatible string for nxp ptn5110 Li Jun
2018-03-28 16:06 ` [PATCH v4 04/13] usb: typec: add fwnode to tcpc Li Jun
2018-03-29 12:57   ` Heikki Krogerus
2018-03-31  3:17     ` Jun Li
2018-03-28 16:06 ` [PATCH v4 05/13] usb: typec: add API to get typec basic port power and data config Li Jun
2018-03-28 16:06 ` [PATCH v4 06/13] usb: typec: tcpm: support get typec and pd config from device properties Li Jun
2018-03-28 16:06 ` [PATCH v4 07/13] staging: typec: tcpci: register port before request irq Li Jun
2018-03-29 10:52   ` Dan Carpenter
2018-03-31  3:09     ` Jun Li
2018-03-31  8:01       ` Dan Carpenter
2018-03-28 16:06 ` [PATCH v4 08/13] staging: typec: tcpci: enable vbus detection Li Jun
2018-03-28 16:06 ` [PATCH v4 09/13] typec: tcpm: add starting value for drp toggling Li Jun
2018-03-28 16:06 ` Li Jun [this message]
2018-03-29 21:18   ` [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach Mats Karrman
2018-03-31  3:37     ` Jun Li
2018-03-29 22:49   ` Guenter Roeck
2018-03-31  4:38     ` Jun Li
2018-03-28 16:06 ` [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open Li Jun
2018-03-30 15:15   ` Guenter Roeck
2018-03-31  4:49     ` Jun Li
2018-03-28 16:06 ` [PATCH v4 12/13] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun
2018-03-28 16:06 ` [PATCH v4 13/13] staging: typec: tcpci: move tcpci driver out of staging Li Jun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522253178-32414-11-git-send-email-jun.li@nxp.com \
    --to=jun.li@nxp.com \
    --cc=a.hajda@samsung.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shufan_lee@richtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).