From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jernej =?utf-8?B?xaBrcmFiZWM=?= Subject: Re: [PATCH 04/11] drm/bridge/synopsys: dw-hdmi: Export some PHY related functions Date: Tue, 09 Jan 2018 19:42:26 +0100 Message-ID: <1523919.I1QF6T1ars@jernej-laptop> References: <20171230210203.24115-1-jernej.skrabec@siol.net> <10903755.CJpSM8RM5e@jernej-laptop> <1586880.7NXXgpct7p@avalon> Reply-To: jernej.skrabec-gGgVlfcn5nU@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <1586880.7NXXgpct7p@avalon> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Laurent Pinchart Cc: Archit Taneja , maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, airlied-cv59FeDIM0c@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, wens-jdAy2FN1RRM@public.gmane.org, a.hajda-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, Jose.Abreu-HKixBCOQz3hWk0Htik3J/w@public.gmane.org, narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Id: devicetree@vger.kernel.org Hi Laurent, Dne torek, 09. januar 2018 ob 17:08:55 CET je Laurent Pinchart napisal(a): > Hello, >=20 > On Tuesday, 9 January 2018 17:58:46 EET Jernej =C5=A0krabec wrote: > > Dne torek, 09. januar 2018 ob 11:43:08 CET je Archit Taneja napisal(a): > > > On 12/31/2017 02:31 AM, Jernej Skrabec wrote: > > >> Parts of PHY code could be useful also for custom PHYs. For example, > > >> Allwinner A83T has custom PHY which is probably Synopsys gen2 PHY > > >> with few additional memory mapped registers, so most of the Synopsys > > >> PHY > > >> related code could be reused. > > >>=20 > > >> It turns out that even completely custom HDMI PHYs, such as the one > > >> found in Allwinner H3, can reuse some of those functions. This would > > >> suggest that (some?) functions exported in this commit are actually > > >> part > > >> of generic PHY interface and not really specific to Synopsys PHYs. > > >>=20 > > >> Export useful PHY functions. > > >>=20 > > >> Signed-off-by: Jernej Skrabec > > >> --- > > >>=20 > > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 45 +++++++++++++++++----= --- > > >> drivers/gpu/drm/bridge/synopsys/dw-hdmi.h | 2 ++ > > >> include/drm/bridge/dw_hdmi.h | 10 +++++++ > > >> 3 files changed, 44 insertions(+), 13 deletions(-) > > >>=20 > > >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > >> b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c index > > >> 7ca14d7325b5..67467d0b683a 100644 > > >> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c > > >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c >=20 > [snip] >=20 > > >> @@ -1065,6 +1067,23 @@ static void > > >> dw_hdmi_phy_sel_interface_control(struct dw_hdmi *hdmi, u8 enable) > > >>=20 > > >> HDMI_PHY_CONF0_SELDIPIF_MASK); > > >> =20 > > >> } > > >>=20 > > >> +void dw_hdmi_phy_gen2_reset(struct dw_hdmi *hdmi, u8 enable) > > >> +{ > > >> + hdmi_mask_writeb(hdmi, enable, HDMI_MC_PHYRSTZ, > > >> + HDMI_MC_PHYRSTZ_PHYRSTZ_OFFSET, > > >> + HDMI_MC_PHYRSTZ_PHYRSTZ_MASK); > > >> +} > > >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_gen2_reset); >=20 > I don't remember the details, is the reset signal Gen2-specific ? According to this comment: /* PHY reset. The reset signal is active high on Gen2 PHYs. */ I would guess that it is not specific to Gen2, otherwise the comment wouldn= 't=20 be needed. I will remove "gen2" from the name. >=20 > How about asserting and deasserting the reset signal in the same call > instead of having to call this function twice ? It works on A83T if reset signal is asserted and deasserted immediately. I= =20 will change function according to your proposal. Best regards, Jernej >=20 > > >> +void dw_hdmi_phy_set_slave_addr(struct dw_hdmi *hdmi) > > >> +{ > > >> + hdmi_phy_test_clear(hdmi, 1); > > >> + hdmi_writeb(hdmi, HDMI_PHY_I2CM_SLAVE_ADDR_PHY_GEN2, > > >> + HDMI_PHY_I2CM_SLAVE_ADDR); > > >> + hdmi_phy_test_clear(hdmi, 0); > > >> +} > > >> +EXPORT_SYMBOL_GPL(dw_hdmi_phy_set_slave_addr); > > >=20 > > > Should this be called dw_hdmi_phy_gen2_set_slave_addr? > >=20 > > Probably. I will rename it in v2 to be consistent with other phy > > functions. >=20 > The I2C write function is called dw_hdmi_phy_i2c_write(). If we want to b= e > conosistent we should either rename this one to dw_hdmi_phy_i2c_set_addr(= ) > or rename them both to dw_hdmi_phy_gen2_i2c_write() and > dw_hdmi_phy_gen2_i2c_set_addr(). I think I'd prefer the former, and we co= uld > even drop gen2 from dw_hdmi_phy_gen2_pddq() and dw_hdmi_phy_gen2_txpwron(= ) > if desired. >=20 > > > Looks good otherwise. Same for patches 3 and 4 in this series. > > >=20 > > >> + > > >>=20 > > >> static void dw_hdmi_phy_power_off(struct dw_hdmi *hdmi) > > >> { > > >> =20 > > >> const struct dw_hdmi_phy_data *phy =3D hdmi->phy.data; >=20 > [snip] >=20 > -- > Regards, >=20 > Laurent Pinchart --=20 You received this message because you are subscribed to the Google Groups "= linux-sunxi" group. To unsubscribe from this group and stop receiving emails from it, send an e= mail to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.