From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rui Miguel Silva <rui.silva@linaro.org>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
Steve Longerbeam <slongerbeam@gmail.com>,
Rob Herring <robh+dt@kernel.org>
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ryan Harkin <ryan.harkin@linaro.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 07/15] media: staging/imx: add 10 bit bayer support
Date: Thu, 19 Apr 2018 15:38:21 +0200 [thread overview]
Message-ID: <1524145101.3416.7.camel@pengutronix.de> (raw)
In-Reply-To: <20180419101812.30688-8-rui.silva@linaro.org>
On Thu, 2018-04-19 at 11:18 +0100, Rui Miguel Silva wrote:
> Some sensors can only output 10 bit bayer formats, like the OV2680. Add support
> for that in imx-media.
>
> Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
> ---
> drivers/staging/media/imx/imx-media-utils.c | 24 +++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index fab98fc0d6a0..99527daba29a 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -118,6 +118,30 @@ static const struct imx_media_pixfmt rgb_formats[] = {
> .cs = IPUV3_COLORSPACE_RGB,
> .bpp = 8,
> .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SBGGR10,
> + .codes = {MEDIA_BUS_FMT_SBGGR10_1X10},
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 16,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGBRG10,
> + .codes = {MEDIA_BUS_FMT_SGBRG10_1X10},
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 16,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SGRBG10,
> + .codes = {MEDIA_BUS_FMT_SGRBG10_1X10},
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 16,
> + .bayer = true,
> + }, {
> + .fourcc = V4L2_PIX_FMT_SRGGB10,
> + .codes = {MEDIA_BUS_FMT_SRGGB10_1X10},
> + .cs = IPUV3_COLORSPACE_RGB,
> + .bpp = 16,
> + .bayer = true,
This will break 10-bit bayer formats on i.MX6, which currently stores
them in memory expanded to 16-bit, as listed in the entries below:
> }, {
> .fourcc = V4L2_PIX_FMT_SBGGR16,
> .codes = {
regards
Philipp
next prev parent reply other threads:[~2018-04-19 13:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 10:17 [PATCH 00/15] media: staging/imx7: add i.MX7 media driver Rui Miguel Silva
2018-04-19 10:17 ` [PATCH 01/15] media: staging/imx: add support to media dev for no IPU systems Rui Miguel Silva
2018-04-19 12:06 ` Dan Carpenter
2018-04-19 14:02 ` Rui Miguel Silva
2018-04-19 10:17 ` [PATCH 02/15] media: staging/imx7: add imx7 CSI subdev driver Rui Miguel Silva
2018-04-19 12:22 ` Dan Carpenter
2018-04-19 14:03 ` Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 03/15] clk: imx7d: fix mipi dphy div parent Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 04/15] clk: imx7d: reset parent for mipi csi root Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 05/15] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7 Rui Miguel Silva
2018-04-19 12:45 ` Dan Carpenter
2018-04-19 14:09 ` Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 06/15] media: staging/imx: add imx7 capture subsystem Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 07/15] media: staging/imx: add 10 bit bayer support Rui Miguel Silva
2018-04-19 13:38 ` Philipp Zabel [this message]
2018-04-19 14:20 ` Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 08/15] ARM: dts: increase default cma size to 40MB Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 09/15] media: dt-bindings: add bindings for i.MX7 media driver Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 10/15] ARM: dts: imx7s: add mipi phy power domain Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 11/15] ARM: dts: imx7s: add multiplexer controls Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 12/15] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 13/15] ARM: dts: imx7s: add capture subsystem Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 14/15] media: imx7.rst: add documentation for i.MX7 media driver Rui Miguel Silva
2018-04-19 10:18 ` [PATCH 15/15] media: staging/imx: add i.MX7 entries to TODO file Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524145101.3416.7.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.silva@linaro.org \
--cc=ryan.harkin@linaro.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).