From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "marvin24@gmx.de" <marvin24@gmx.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH] ARM: tegra: fix ulpi regression on tegra20
Date: Mon, 23 Apr 2018 15:42:28 +0000 [thread overview]
Message-ID: <1524498146.4493.35.camel@toradex.com> (raw)
In-Reply-To: <6600596.BijQW1iq1K@ax5200p>
Hi Marc
On Fri, 2018-04-20 at 10:52 +0200, Marc Dietrich wrote:
>
> ...
> I booted 4.17-rc1 (which includes this fix) on an AC100 (T20 paz00
> board) and
> the error above is still there. Surprisingly the error vanishes when
> I revert
> your patch. So this patch actually *causes* the problem above on my
> board.
That's really strange.
I believe I do have one of them paz00 boards laying around somewhere as
well. Just need to dig it out again and will give it a try. Looking at
their schematics at least reveals the exact same circuit as found on
all other T20 based boards using DAP_MCLK2 as REFCLK to the USB3315C
which BTW is 24 MHz and not 26 MHz as CDEV2 claims!
> Could it be, that we need all four clocks? Dimitry mentioned on IRC
> that it
> could also be a problem in the clock init table. I don't have the
> technical
> background myself to fix it, but I still wonder what could be so
> different
> between TrimSlice and AC100.
I am wondering the same. However I still suspect that something is
completely wrong in that area as that CDEV2 clock is completely bogus.
It really does not exist!
> Marc
Cheers
Marcel
prev parent reply other threads:[~2018-04-23 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 15:12 [PATCH] ARM: tegra: fix ulpi regression on tegra20 Marcel Ziswiler
2018-04-20 8:52 ` Marc Dietrich
2018-04-20 10:50 ` Dmitry Osipenko
2018-04-23 22:05 ` Marcel Ziswiler
2018-04-24 14:38 ` Dmitry Osipenko
2018-04-26 11:39 ` Peter De Schrijver
2018-04-23 15:42 ` Marcel Ziswiler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524498146.4493.35.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=marvin24@gmx.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).