From: Shawn Guo <shawnguo@kernel.org>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
linux-imx@nxp.com, kernel@pengutronix.de
Subject: [PATCH 2/4] ARM: dts: imx1: move clk32 clock into soc dtsi
Date: Fri, 4 May 2018 08:57:24 +0800 [thread overview]
Message-ID: <1525395446-1953-3-git-send-email-shawnguo@kernel.org> (raw)
In-Reply-To: <1525395446-1953-1-git-send-email-shawnguo@kernel.org>
The clk32 clock is an input clock to CCM module, and should be defined
in soc dtsi rather than a board level dts. Let's move it into
imx1.dtsi.
While at it, let's drop unnecessary #address-cells/#size-cells from
'clocks' node to DTC warning avoid_unnecessary_addr_size seen with W=1
switch.
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---
arch/arm/boot/dts/imx1-ads.dts | 11 -----------
arch/arm/boot/dts/imx1.dtsi | 8 ++++++++
2 files changed, 8 insertions(+), 11 deletions(-)
diff --git a/arch/arm/boot/dts/imx1-ads.dts b/arch/arm/boot/dts/imx1-ads.dts
index 6354e4c87313..a1d81badb5c8 100644
--- a/arch/arm/boot/dts/imx1-ads.dts
+++ b/arch/arm/boot/dts/imx1-ads.dts
@@ -23,17 +23,6 @@
memory@8000000 {
reg = <0x08000000 0x04000000>;
};
-
- clocks {
- #address-cells = <1>;
- #size-cells = <0>;
-
- clk32 {
- compatible = "fsl,imx-clk32", "fixed-clock";
- #clock-cells = <0>;
- clock-frequency = <32000>;
- };
- };
};
&cspi1 {
diff --git a/arch/arm/boot/dts/imx1.dtsi b/arch/arm/boot/dts/imx1.dtsi
index f7b9edf93f5e..78cba9435f8e 100644
--- a/arch/arm/boot/dts/imx1.dtsi
+++ b/arch/arm/boot/dts/imx1.dtsi
@@ -62,6 +62,14 @@
};
};
+ clocks {
+ clk32 {
+ compatible = "fsl,imx-clk32", "fixed-clock";
+ #clock-cells = <0>;
+ clock-frequency = <32000>;
+ };
+ };
+
soc {
#address-cells = <1>;
#size-cells = <1>;
--
1.9.1
next prev parent reply other threads:[~2018-05-04 0:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 0:57 [PATCH 0/4] Fix avoid_unnecessary_addr_size DTC warning with 'clocks' node Shawn Guo
2018-05-04 0:57 ` [PATCH 1/4] ARM: dts: imx: drop unnecessary #address-cells/#size-cells Shawn Guo
2018-05-04 0:57 ` Shawn Guo [this message]
2018-05-04 0:57 ` [PATCH 3/4] ARM: dts: imx27: use lable to override osc26m clock setting Shawn Guo
2018-05-04 15:34 ` Fabio Estevam
2018-05-07 1:39 ` Shawn Guo
2018-05-04 0:57 ` [PATCH 4/4] ARM: dts: imx: drop 'clocks' container for board level clocks Shawn Guo
2018-05-04 8:18 ` Lothar Waßmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525395446-1953-3-git-send-email-shawnguo@kernel.org \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).