From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Weiss Subject: Re: [PATCH v3 1/3] dt-bindings: input: add GPIO controllable vibrator Date: Wed, 17 Apr 2019 18:02:27 +0200 Message-ID: <15255825.75VNnaJK3T@g550jk> References: <20190412150625.28384-1-luca@z3ntu.xyz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20190412150625.28384-1-luca@z3ntu.xyz> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Pascal PAILLET-LME , Coly Li , Lee Jones , Xiaotong Lu , Brian Masney , Rob Herring , Baolin Wang , David Brown , "open list:ARM/QUALCOMM SUPPORT" , "open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN)..." , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org On Freitag, 12. April 2019 17:06:23 CEST Luca Weiss wrote: > Provide a simple driver for GPIO controllable vibrators. > It will be used by the Fairphone 2. > > Signed-off-by: Luca Weiss > --- > .../bindings/input/gpio-vibrator.txt | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/input/gpio-vibrator.txt > > diff --git a/Documentation/devicetree/bindings/input/gpio-vibrator.txt > b/Documentation/devicetree/bindings/input/gpio-vibrator.txt new file mode > 100644 > index 000000000000..93e5a8e7622d > --- /dev/null > +++ b/Documentation/devicetree/bindings/input/gpio-vibrator.txt > @@ -0,0 +1,20 @@ > +* GPIO vibrator device tree bindings > + > +Registers a GPIO device as vibrator, where the vibration motor just has the > +capability to turn on or off. If the device is connected to a pwm, you > should +use the pwm-vibrator driver instead. > + > +Required properties: > +- compatible: should contain "gpio-vibrator" > +- enable-gpios: Should contain a GPIO handle > + > +Optional properties: > +- vcc-supply: Phandle for the regulator supplying power > + > +Example from Fairphone 2: > + > +vibrator { > + compatible = "gpio-vibrator"; > + enable-gpios = <&msmgpio 86 GPIO_ACTIVE_HIGH>; > + vcc-supply = <&pm8941_l18>; > +}; I see that the yaml based device tree binding docs seem to be the new hotness? Is there any "policy" / preference about new drivers? Luca