Re: [PATCH] arm: dts: imx53: Fix LDB OF graph warning

[Philipp Zabel <p.zabel@pengutronix.de>]

On Tue, 2018-05-08 at 08:59 -0500, Rob Herring wrote:
> Single child nodes in OF graph don't need an address and now dtc will
> warn about this:
> 
> Warning (graph_child_address): /soc/aips@50000000/ldb@53fa8008/lvds-channel@0: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
> 
> Since the LDB should always have an output port, fix the warning by
> adding the output port, 2, to the DT.
> 
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/boot/dts/imx53.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
> index 7d647d043f52..1cf2fc9d0a58 100644
> --- a/arch/arm/boot/dts/imx53.dtsi
> +++ b/arch/arm/boot/dts/imx53.dtsi
> @@ -488,6 +488,10 @@
>  							remote-endpoint = <&ipu_di0_lvds0>;
>  						};
>  					};
> +
> +					port@2 {
> +						reg = <2>;
> +					};

Now that the reg property of port@2 is added in the .dtsi, it could be
removed from the one .dts files that use it:

----------8<----------
--- a/arch/arm/boot/dts/imx53-ppd.dts
+++ b/arch/arm/boot/dts/imx53-ppd.dts
@@ -559,8 +559,6 @@
                status = "okay";
 
                port@2 {
-                       reg = <2>;
-
                        lvds0_out: endpoint {
                                remote-endpoint = <&panel_in_lvds0>;
                        };
---------->8----------

>  				};
>  
>  				lvds-channel@1 {
> @@ -503,6 +507,10 @@
>  							remote-endpoint = <&ipu_di1_lvds1>;
>  						};
>  					};
> +
> +					port@2 {
> +						reg = <2>;
> +					};
>  				};
>  			};
>  

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp