* [RFC] ARM: dts: imx7s: Fix the port reg properties
@ 2018-05-14 14:09 Fabio Estevam
2018-06-28 18:43 ` Fabio Estevam
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2018-05-14 14:09 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
The 'reg' property must match the unit address, so fix them
to avoid the following DTC warnings with W=1:
arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /replicator/ports/port@2: graph node unit address error, expected "0"
arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/funnel@30041000/ports/port@2: graph node unit address error, expected "0"
arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/funnel@30083000/ports/port@2: graph node unit address error, expected "0"
arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/etf@30084000/ports/port@1: graph node unit address error, expected "0"
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
Hi Rob,
Is this the correct way to fix these warnings?
arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
index 7d33993..55b6241 100644
--- a/arch/arm/boot/dts/imx7s.dtsi
+++ b/arch/arm/boot/dts/imx7s.dtsi
@@ -126,7 +126,7 @@
/* replicator input port */
port@2 {
- reg = <0>;
+ reg = <2>;
replicator_in_port0: endpoint {
slave-mode;
remote-endpoint = <&etf_out_port>;
@@ -183,7 +183,7 @@
/* funnel output port */
port@2 {
- reg = <0>;
+ reg = <2>;
ca_funnel_out_port0: endpoint {
remote-endpoint = <&hugo_funnel_in_port0>;
};
@@ -234,7 +234,7 @@
};
port@2 {
- reg = <0>;
+ reg = <2>;
hugo_funnel_out_port0: endpoint {
remote-endpoint = <&etf_in_port>;
};
@@ -263,7 +263,7 @@
};
port@1 {
- reg = <0>;
+ reg = <1>;
etf_out_port: endpoint {
remote-endpoint = <&replicator_in_port0>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC] ARM: dts: imx7s: Fix the port reg properties
2018-05-14 14:09 [RFC] ARM: dts: imx7s: Fix the port reg properties Fabio Estevam
@ 2018-06-28 18:43 ` Fabio Estevam
0 siblings, 0 replies; 2+ messages in thread
From: Fabio Estevam @ 2018-06-28 18:43 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Rob,
On Mon, May 14, 2018 at 11:09 AM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> The 'reg' property must match the unit address, so fix them
> to avoid the following DTC warnings with W=1:
>
> arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /replicator/ports/port@2: graph node unit address error, expected "0"
> arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/funnel@30041000/ports/port@2: graph node unit address error, expected "0"
> arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/funnel@30083000/ports/port@2: graph node unit address error, expected "0"
> arch/arm/boot/dts/imx7d-cl-som-imx7.dtb: Warning (graph_port): /soc/etf@30084000/ports/port@1: graph node unit address error, expected "0"
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Hi Rob,
>
> Is this the correct way to fix these warnings?
Any suggestions, please? I would like to clean up these dtc warnings.
Thanks
>
> arch/arm/boot/dts/imx7s.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7s.dtsi b/arch/arm/boot/dts/imx7s.dtsi
> index 7d33993..55b6241 100644
> --- a/arch/arm/boot/dts/imx7s.dtsi
> +++ b/arch/arm/boot/dts/imx7s.dtsi
> @@ -126,7 +126,7 @@
>
> /* replicator input port */
> port@2 {
> - reg = <0>;
> + reg = <2>;
> replicator_in_port0: endpoint {
> slave-mode;
> remote-endpoint = <&etf_out_port>;
> @@ -183,7 +183,7 @@
>
> /* funnel output port */
> port@2 {
> - reg = <0>;
> + reg = <2>;
> ca_funnel_out_port0: endpoint {
> remote-endpoint = <&hugo_funnel_in_port0>;
> };
> @@ -234,7 +234,7 @@
> };
>
> port@2 {
> - reg = <0>;
> + reg = <2>;
> hugo_funnel_out_port0: endpoint {
> remote-endpoint = <&etf_in_port>;
> };
> @@ -263,7 +263,7 @@
> };
>
> port@1 {
> - reg = <0>;
> + reg = <1>;
> etf_out_port: endpoint {
> remote-endpoint = <&replicator_in_port0>;
> };
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-28 18:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-14 14:09 [RFC] ARM: dts: imx7s: Fix the port reg properties Fabio Estevam
2018-06-28 18:43 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).