From: Philipp Zabel <p.zabel@pengutronix.de>
To: Marco Felsch <m.felsch@pengutronix.de>,
lars@metafoo.de, lgirdwood@gmail.com, broonie@kernel.org,
robh+dt@kernel.org, mark.rutland@arm.com
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
kernel@pengutronix.de
Subject: Re: [PATCH] ASoC: ssm2305: Add amplifier driver
Date: Thu, 17 May 2018 11:42:10 +0200 [thread overview]
Message-ID: <1526550130.2971.3.camel@pengutronix.de> (raw)
In-Reply-To: <20180517092245.16036-1-m.felsch@pengutronix.de>
On Thu, 2018-05-17 at 11:22 +0200, Marco Felsch wrote:
> The ssm2305 is a simple Class-D audio amplifier. A application can
> turn on/off the device by a gpio. It's also possible to hardwire the
> shutdown pin.
>
> Tested on a i.MX6 based custom board.
>
> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de>
> ---
> .../devicetree/bindings/sound/adi,ssm2305.txt | 15 +++
> sound/soc/codecs/Kconfig | 7 ++
> sound/soc/codecs/Makefile | 2 +
> sound/soc/codecs/ssm2305.c | 105 ++++++++++++++++++
> 4 files changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> create mode 100644 sound/soc/codecs/ssm2305.c
>
> diff --git a/Documentation/devicetree/bindings/sound/adi,ssm2305.txt b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> new file mode 100644
> index 000000000000..fc4c99225538
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/adi,ssm2305.txt
> @@ -0,0 +1,15 @@
> +Analog Devices SSM2305 Speaker Amplifier
> +========================================
> +
> +Required properties:
> + - compatible : "adi,ssm2305"
> +
> +Optional properties:
> + - ssm2305,shutdown-gpio : the gpio connected to the shutdown pin
This should be called shutdown-gpios (plural, no vendor prefix) for
consistency. Also, since the shutdown GPIO on SSM2305 is active low,
this should be documented here.
regards
Philipp
next prev parent reply other threads:[~2018-05-17 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 9:22 [PATCH] ASoC: ssm2305: Add amplifier driver Marco Felsch
2018-05-17 9:42 ` Philipp Zabel [this message]
2018-05-17 10:52 ` Lars-Peter Clausen
2018-05-17 11:15 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1526550130.2971.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).