* [PATCH] clk: aspeed: Add 24MHz fixed clock
@ 2018-05-18 8:57 Lei YU
2018-05-21 4:33 ` Joel Stanley
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Lei YU @ 2018-05-18 8:57 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Joel Stanley, Andrew Jeffery,
Rob Herring, Mark Rutland, Lei YU, linux-clk, linux-arm-kernel,
linux-aspeed, linux-kernel, devicetree
Add a 24MHz fixed clock.
This clock will be used for certain devices, e.g. pwm.
Signed-off-by: Lei YU <mine260309@gmail.com>
---
drivers/clk/clk-aspeed.c | 9 ++++++++-
include/dt-bindings/clock/aspeed-clock.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
index 5eb50c3..4664088 100644
--- a/drivers/clk/clk-aspeed.c
+++ b/drivers/clk/clk-aspeed.c
@@ -14,7 +14,7 @@
#include <dt-bindings/clock/aspeed-clock.h>
-#define ASPEED_NUM_CLKS 35
+#define ASPEED_NUM_CLKS 36
#define ASPEED_RESET_CTRL 0x04
#define ASPEED_CLK_SELECTION 0x08
@@ -474,6 +474,13 @@ static int aspeed_clk_probe(struct platform_device *pdev)
return PTR_ERR(hw);
aspeed_clk_data->hws[ASPEED_CLK_BCLK] = hw;
+ /* Fixed 24MHz clock */
+ hw = clk_hw_register_fixed_rate(NULL, "fixed-24m", "clkin",
+ 0, 24000000);
+ if (IS_ERR(hw))
+ return PTR_ERR(hw);
+ aspeed_clk_data->hws[ASPEED_CLK_24M] = hw;
+
/*
* TODO: There are a number of clocks that not included in this driver
* as more information is required:
diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
index d3558d8..ff29d8e 100644
--- a/include/dt-bindings/clock/aspeed-clock.h
+++ b/include/dt-bindings/clock/aspeed-clock.h
@@ -38,6 +38,7 @@
#define ASPEED_CLK_MAC 32
#define ASPEED_CLK_BCLK 33
#define ASPEED_CLK_MPLL 34
+#define ASPEED_CLK_24M 35
#define ASPEED_RESET_XDMA 0
#define ASPEED_RESET_MCTP 1
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: aspeed: Add 24MHz fixed clock
2018-05-18 8:57 [PATCH] clk: aspeed: Add 24MHz fixed clock Lei YU
@ 2018-05-21 4:33 ` Joel Stanley
2018-05-23 17:00 ` Rob Herring
2018-06-01 19:19 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Joel Stanley @ 2018-05-21 4:33 UTC (permalink / raw)
To: Lei YU
Cc: Michael Turquette, Stephen Boyd, Andrew Jeffery, Rob Herring,
Mark Rutland, linux-clk, Linux ARM, linux-aspeed,
Linux Kernel Mailing List, devicetree
On 18 May 2018 at 18:27, Lei YU <mine260309@gmail.com> wrote:
> Add a 24MHz fixed clock.
> This clock will be used for certain devices, e.g. pwm.
>
> Signed-off-by: Lei YU <mine260309@gmail.com>
Reviewed-by: Joel Stanley <joel@jms.id.au>
Cheers,
Joel
> ---
> drivers/clk/clk-aspeed.c | 9 ++++++++-
> include/dt-bindings/clock/aspeed-clock.h | 1 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
> index 5eb50c3..4664088 100644
> --- a/drivers/clk/clk-aspeed.c
> +++ b/drivers/clk/clk-aspeed.c
> @@ -14,7 +14,7 @@
>
> #include <dt-bindings/clock/aspeed-clock.h>
>
> -#define ASPEED_NUM_CLKS 35
> +#define ASPEED_NUM_CLKS 36
>
> #define ASPEED_RESET_CTRL 0x04
> #define ASPEED_CLK_SELECTION 0x08
> @@ -474,6 +474,13 @@ static int aspeed_clk_probe(struct platform_device *pdev)
> return PTR_ERR(hw);
> aspeed_clk_data->hws[ASPEED_CLK_BCLK] = hw;
>
> + /* Fixed 24MHz clock */
> + hw = clk_hw_register_fixed_rate(NULL, "fixed-24m", "clkin",
> + 0, 24000000);
> + if (IS_ERR(hw))
> + return PTR_ERR(hw);
> + aspeed_clk_data->hws[ASPEED_CLK_24M] = hw;
> +
> /*
> * TODO: There are a number of clocks that not included in this driver
> * as more information is required:
> diff --git a/include/dt-bindings/clock/aspeed-clock.h b/include/dt-bindings/clock/aspeed-clock.h
> index d3558d8..ff29d8e 100644
> --- a/include/dt-bindings/clock/aspeed-clock.h
> +++ b/include/dt-bindings/clock/aspeed-clock.h
> @@ -38,6 +38,7 @@
> #define ASPEED_CLK_MAC 32
> #define ASPEED_CLK_BCLK 33
> #define ASPEED_CLK_MPLL 34
> +#define ASPEED_CLK_24M 35
>
> #define ASPEED_RESET_XDMA 0
> #define ASPEED_RESET_MCTP 1
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: aspeed: Add 24MHz fixed clock
2018-05-18 8:57 [PATCH] clk: aspeed: Add 24MHz fixed clock Lei YU
2018-05-21 4:33 ` Joel Stanley
@ 2018-05-23 17:00 ` Rob Herring
2018-06-01 19:19 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2018-05-23 17:00 UTC (permalink / raw)
To: Lei YU
Cc: Michael Turquette, Stephen Boyd, Joel Stanley, Andrew Jeffery,
Mark Rutland, linux-clk, linux-arm-kernel, linux-aspeed,
linux-kernel, devicetree
On Fri, May 18, 2018 at 04:57:02PM +0800, Lei YU wrote:
> Add a 24MHz fixed clock.
> This clock will be used for certain devices, e.g. pwm.
>
> Signed-off-by: Lei YU <mine260309@gmail.com>
> ---
> drivers/clk/clk-aspeed.c | 9 ++++++++-
> include/dt-bindings/clock/aspeed-clock.h | 1 +
> 2 files changed, 9 insertions(+), 1 deletion(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] clk: aspeed: Add 24MHz fixed clock
2018-05-18 8:57 [PATCH] clk: aspeed: Add 24MHz fixed clock Lei YU
2018-05-21 4:33 ` Joel Stanley
2018-05-23 17:00 ` Rob Herring
@ 2018-06-01 19:19 ` Stephen Boyd
2 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2018-06-01 19:19 UTC (permalink / raw)
To: Andrew Jeffery, Joel Stanley, Lei YU, Mark Rutland,
Michael Turquette, Rob Herring, devicetree, linux-arm-kernel,
linux-aspeed, linux-clk, linux-kernel
Quoting Lei YU (2018-05-18 01:57:02)
> Add a 24MHz fixed clock.
> This clock will be used for certain devices, e.g. pwm.
>
> Signed-off-by: Lei YU <mine260309@gmail.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-06-01 19:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-18 8:57 [PATCH] clk: aspeed: Add 24MHz fixed clock Lei YU
2018-05-21 4:33 ` Joel Stanley
2018-05-23 17:00 ` Rob Herring
2018-06-01 19:19 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).