From: Hariharan K <quic_harihk@quicinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<agross@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <quic_srichara@quicinc.com>, <quic_sjaganat@quicinc.com>,
<quic_kathirav@quicinc.com>, <quic_arajkuma@quicinc.com>,
<quic_anusha@quicinc.com>
Subject: Re: [PATCH 2/2] arm64: dts: qcom: ipq5018: add support for the RDP415 variant
Date: Thu, 20 Jul 2023 16:50:29 +0530 [thread overview]
Message-ID: <15275174-4903-afd2-df7f-bc3d73a06d00@quicinc.com> (raw)
In-Reply-To: <af890343-824c-7b68-ba27-dbaa4fa5b863@linaro.org>
On 7/20/2023 2:26 PM, Krzysztof Kozlowski wrote:
> On 20/07/2023 09:48, Hariharan K wrote:
>> Add the initial device tree support for the Reference Design
>> Platform(RDP) 415 based on IPQ5018 family of SoC. This patch
>> carries the support for Console UART and eMMC.
>>
>> Signed-off-by: Hariharan K <quic_harihk@quicinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/Makefile | 1 +
>> arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts | 49 +++++++++++++++++++++
>> 2 files changed, 50 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>>
>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
>> index 6334e552b7c1..53df7f24488a 100644
>> --- a/arch/arm64/boot/dts/qcom/Makefile
>> +++ b/arch/arm64/boot/dts/qcom/Makefile
>> @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_QCOM) += apq8039-t2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8094-sony-xperia-kitakami-karin_windy.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8096-db820c.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += apq8096-ifc6640.dtb
>> +dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp415.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp441.dtb
>> dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb
>> diff --git a/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>> new file mode 100644
>> index 000000000000..5c4b43f76a48
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/ipq5018-rdp415.dts
>> @@ -0,0 +1,49 @@
>> +// SPDX-License-Identifier: GPL-2.0+ OR BSD-3-Clause
>> +/*
>> + * IPQ5018 MP03.3-C2 board device tree source
>> + * Copyright (c) 2023, The Linux Foundation. All rights reserved.
>> + */
>> +
>> +/dts-v1/;
>> +
>> +#include "ipq5018-rdp-common.dtsi"
>
> I don't understand this. You just added in in the same moment in
> different patchset, so why creating this fake dependency?
>
> It makes review difficult, applying even more.
>
> Please organize your patches in some logical work.
Sure, got it. Will rework this series and post v2.
Best regards,
Hariharan K
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-07-20 11:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 7:48 [PATCH 0/2] Add initial support for RDP415 of IPQ5018 family Hariharan K
2023-07-20 7:48 ` [PATCH 1/2] dt-bindings: arm: qcom: Document MP03.3-C2 board based on " Hariharan K
2023-07-20 7:48 ` [PATCH 2/2] arm64: dts: qcom: ipq5018: add support for the RDP415 variant Hariharan K
2023-07-20 8:16 ` Konrad Dybcio
2023-07-20 11:16 ` Hariharan K
2023-07-20 8:56 ` Krzysztof Kozlowski
2023-07-20 11:20 ` Hariharan K [this message]
2023-07-20 8:05 ` [PATCH 0/2] Add initial support for RDP415 of IPQ5018 family Konrad Dybcio
2023-07-20 11:21 ` Hariharan K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15275174-4903-afd2-df7f-bc3d73a06d00@quicinc.com \
--to=quic_harihk@quicinc.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).