[PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

[PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

[Yoshihiro Shimoda]

This patch set is based on renesas-drivers.git /
renesas-drivers-2018-06-05-v4.17 tag.

About dt-bindings of "renesas,usb2-phy-r8a77990", I submitted a patch:
https://patchwork.kernel.org/patch/10449723/

But, the phy-rcar-gen3-usb2 driver works on the board without the bindings
because "renesas,rcar-gen3-usb2-phy" can bind the driver.

Also, for now, I don't try to add/enable USB2.0 peripheral on the board
because the phy driver needs some modifications.

Yoshihiro Shimoda (4):
  arm64: dts: renesas: r8a77990: add usb2_phy device node
  arm64: dts: renesas: r8a77990: add USB2.0 host device nodes
  arm64: dts: renesas: r8a77990: ebisu: enable usb2_phy0
  arm64: dts: renesas: r8a77990: ebisu: enable USB2.0 host

 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 20 ++++++++++++++
 arch/arm64/boot/dts/renesas/r8a77990.dtsi      | 37 ++++++++++++++++++++++++++
 2 files changed, 57 insertions(+)

-- 
1.9.1

[PATCH 1/4] arm64: dts: renesas: r8a77990: add usb2_phy device node

[Yoshihiro Shimoda]

This patch adds USB2.0 phy device node for r8a77990.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index be4f519..121c4a0 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -248,6 +248,18 @@
 			status = "disabled";
 		};
 
+		usb2_phy0: usb-phy@ee080200 {
+			compatible = "renesas,usb2-phy-r8a77990",
+				     "renesas,rcar-gen3-usb2-phy";
+			reg = <0 0xee080200 0 0x700>;
+			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 703>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 703>;
+			#phy-cells = <0>;
+			status = "disabled";
+		};
+
 		gic: interrupt-controller@f1010000 {
 			compatible = "arm,gic-400";
 			#interrupt-cells = <3>;
-- 
1.9.1

[PATCH 2/4] arm64: dts: renesas: r8a77990: add USB2.0 host device nodes

[Yoshihiro Shimoda]

This patch adds USB2.0 host(EHCI/OHCI) device nodes for r8a77990.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 121c4a0..0b2bec3 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -248,6 +248,31 @@
 			status = "disabled";
 		};
 
+		ohci0: usb@ee080000 {
+			compatible = "generic-ohci";
+			reg = <0 0xee080000 0 0x100>;
+			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 703>;
+			phys = <&usb2_phy0>;
+			phy-names = "usb";
+			power-domains = <&sysc 32>;
+			resets = <&cpg 703>;
+			status = "disabled";
+		};
+
+		ehci0: usb@ee080100 {
+			compatible = "generic-ehci";
+			reg = <0 0xee080100 0 0x100>;
+			interrupts = <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 703>;
+			phys = <&usb2_phy0>;
+			phy-names = "usb";
+			companion = <&ohci0>;
+			power-domains = <&sysc 32>;
+			resets = <&cpg 703>;
+			status = "disabled";
+		};
+
 		usb2_phy0: usb-phy@ee080200 {
 			compatible = "renesas,usb2-phy-r8a77990",
 				     "renesas,rcar-gen3-usb2-phy";
-- 
1.9.1

[PATCH 3/4] arm64: dts: renesas: r8a77990: ebisu: enable usb2_phy0

[Yoshihiro Shimoda]

This patch enables usb2_phy0 for r8a77990 Ebisu board.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 7a09d05..1be10c9 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -58,8 +58,20 @@
 			function = "avb";
 		};
 	};
+
+	usb0_pins: usb {
+		groups = "usb0_b";
+		function = "usb0";
+	};
 };
 
 &scif2 {
 	status = "okay";
 };
+
+&usb2_phy0 {
+	pinctrl-0 = <&usb0_pins>;
+	pinctrl-names = "default";
+
+	status = "okay";
+};
-- 
1.9.1

[PATCH 4/4] arm64: dts: renesas: r8a77990: ebisu: enable USB2.0 host

[Yoshihiro Shimoda]

This patch enables USB2.0 host (EHCI/OHCI) for r8a77990 Ebisu board.

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
index 1be10c9..76fa244 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts
@@ -47,10 +47,18 @@
 	};
 };
 
+&ehci0 {
+	status = "okay";
+};
+
 &extal_clk {
 	clock-frequency = <48000000>;
 };
 
+&ohci0 {
+	status = "okay";
+};
+
 &pfc {
 	avb_pins: avb {
 		mux {
-- 
1.9.1

Re: [PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

[Simon Horman]

On Wed, Jun 06, 2018 at 03:56:07PM +0900, Yoshihiro Shimoda wrote:
> This patch set is based on renesas-drivers.git /
> renesas-drivers-2018-06-05-v4.17 tag.
> 
> About dt-bindings of "renesas,usb2-phy-r8a77990", I submitted a patch:
> https://patchwork.kernel.org/patch/10449723/
> 
> But, the phy-rcar-gen3-usb2 driver works on the board without the bindings
> because "renesas,rcar-gen3-usb2-phy" can bind the driver.
> 
> Also, for now, I don't try to add/enable USB2.0 peripheral on the board
> because the phy driver needs some modifications.
> 
> Yoshihiro Shimoda (4):
>   arm64: dts: renesas: r8a77990: add usb2_phy device node
>   arm64: dts: renesas: r8a77990: add USB2.0 host device nodes
>   arm64: dts: renesas: r8a77990: ebisu: enable usb2_phy0
>   arm64: dts: renesas: r8a77990: ebisu: enable USB2.0 host
> 
>  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 20 ++++++++++++++
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi      | 37 ++++++++++++++++++++++++++
>  2 files changed, 57 insertions(+)

Hi Shomoda-san,

the contents of this series looks good to me.  However, given Olof
Johansson's recent comments in ("Re: [GIT PULL] Renesas ARM64 Based SoC DT
Updates for v4.18") please consider squashing this series into a single
patch and reposting.

Thanks!

RE: [PATCH 0/4] arm64: dts: renesas: r8a77990 and ebisu: Enable USB2.0 host

[Yoshihiro Shimoda]

Hi Simon-san,

> From: Simon Horman, Sent: Wednesday, June 6, 2018 6:16 PM
> 
> On Wed, Jun 06, 2018 at 03:56:07PM +0900, Yoshihiro Shimoda wrote:
> > This patch set is based on renesas-drivers.git /
> > renesas-drivers-2018-06-05-v4.17 tag.
> >
> > About dt-bindings of "renesas,usb2-phy-r8a77990", I submitted a patch:
> > https://patchwork.kernel.org/patch/10449723/
> >
> > But, the phy-rcar-gen3-usb2 driver works on the board without the bindings
> > because "renesas,rcar-gen3-usb2-phy" can bind the driver.
> >
> > Also, for now, I don't try to add/enable USB2.0 peripheral on the board
> > because the phy driver needs some modifications.
> >
> > Yoshihiro Shimoda (4):
> >   arm64: dts: renesas: r8a77990: add usb2_phy device node
> >   arm64: dts: renesas: r8a77990: add USB2.0 host device nodes
> >   arm64: dts: renesas: r8a77990: ebisu: enable usb2_phy0
> >   arm64: dts: renesas: r8a77990: ebisu: enable USB2.0 host
> >
> >  arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 20 ++++++++++++++
> >  arch/arm64/boot/dts/renesas/r8a77990.dtsi      | 37 ++++++++++++++++++++++++++
> >  2 files changed, 57 insertions(+)
> 
> Hi Shomoda-san,
> 
> the contents of this series looks good to me.  However, given Olof
> Johansson's recent comments in ("Re: [GIT PULL] Renesas ARM64 Based SoC DT
> Updates for v4.18") please consider squashing this series into a single
> patch and reposting.

Sure. I'll resubmit v2 patch as a single patch.

Best regards,
Yoshihiro Shimoda

> Thanks!