* [PATCH 1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2
@ 2018-06-10 14:15 Paweł Chmiel
2018-06-11 12:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Paweł Chmiel @ 2018-06-10 14:15 UTC (permalink / raw)
To: kgene, krzk, robh+dt, mark.rutland
Cc: linux-arm-kernel, linux-samsung-soc, devicetree, linux-kernel,
Paweł Chmiel
This commit adds missing interrupt-controller property to gph2 block,
to silence following warnings during build
/soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property
Observed on not yet mainlined, an S5PV210 based
Samsung Galaxy S (i9000) phone.
Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
---
arch/arm/boot/dts/s5pv210-pinctrl.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
index 3a79feab11c3..7f0c9d447871 100644
--- a/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
+++ b/arch/arm/boot/dts/s5pv210-pinctrl.dtsi
@@ -258,6 +258,8 @@
gph2: gph2 {
gpio-controller;
#gpio-cells = <2>;
+
+ interrupt-controller;
#interrupt-cells = <2>;
};
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2
2018-06-10 14:15 [PATCH 1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2 Paweł Chmiel
@ 2018-06-11 12:43 ` Krzysztof Kozlowski
2018-06-11 18:57 ` Paweł Chmiel
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2018-06-11 12:43 UTC (permalink / raw)
To: Paweł Chmiel
Cc: kgene, robh+dt, mark.rutland, linux-arm-kernel,
linux-samsung-soc@vger.kernel.org, devicetree, linux-kernel
On Sun, Jun 10, 2018 at 4:15 PM, Paweł Chmiel
<pawel.mikolaj.chmiel@gmail.com> wrote:
> This commit adds missing interrupt-controller property to gph2 block,
Just "Add missing". See:
https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
> to silence following warnings during build
> /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property
>
> Observed on not yet mainlined, an S5PV210 based
> Samsung Galaxy S (i9000) phone.
The warning is not reproduceable (as you mentioned board is not
present in mainline) thus please skip it. Instead, either describe
existing reason for this change (e.g. because bindings require it for
node of every bank of pins supporting GPIO interrupts) or include this
in series mainlining new board (where the reason will be - it will be
used by new board etc).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2
2018-06-11 12:43 ` Krzysztof Kozlowski
@ 2018-06-11 18:57 ` Paweł Chmiel
0 siblings, 0 replies; 3+ messages in thread
From: Paweł Chmiel @ 2018-06-11 18:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: kgene, robh+dt, mark.rutland, linux-arm-kernel,
linux-samsung-soc@vger.kernel.org, devicetree, linux-kernel
On Monday, June 11, 2018 2:43:59 PM CEST Krzysztof Kozlowski wrote:
> On Sun, Jun 10, 2018 at 4:15 PM, Paweł Chmiel
> <pawel.mikolaj.chmiel@gmail.com> wrote:
> > This commit adds missing interrupt-controller property to gph2 block,
>
> Just "Add missing". See:
> https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151
>
> > to silence following warnings during build
> > /soc/pinctrl@e0200000/gph2: Missing interrupt-controller or interrupt-map property
> >
> > Observed on not yet mainlined, an S5PV210 based
> > Samsung Galaxy S (i9000) phone.
>
> The warning is not reproduceable (as you mentioned board is not
> present in mainline) thus please skip it. Instead, either describe
> existing reason for this change (e.g. because bindings require it for
> node of every bank of pins supporting GPIO interrupts) or include this
> in series mainlining new board (where the reason will be - it will be
> used by new board etc).
>
> Best regards,
> Krzysztof
>
Ok, I'll send this patch (fixed) with other patches adding new board.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-11 18:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-10 14:15 [PATCH 1/1] ARM: dts: s5pv210: Add missing interrupt-controller property to gph2 Paweł Chmiel
2018-06-11 12:43 ` Krzysztof Kozlowski
2018-06-11 18:57 ` Paweł Chmiel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).