From: Lucas Stach <l.stach@pengutronix.de>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Bastian Stender <bst@pengutronix.de>
Cc: devicetree@vger.kernel.org, Anson Huang <anson.huang@nxp.com>,
linux-pm@vger.kernel.org,
"Rafael J . Wysocki" <rjw@rjwysocki.net>,
linux-imx@nxp.com, kernel@pengutronix.de,
Zhang Rui <rui.zhang@intel.com>,
Leonard Crestez <leonard.crestez@nxp.com>,
Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH v3 1/2] cpufreq: imx6q/thermal: imx: register cooling device depending on OF
Date: Tue, 19 Jun 2018 11:22:19 +0200 [thread overview]
Message-ID: <1529400139.7211.12.camel@pengutronix.de> (raw)
In-Reply-To: <20180619090556.p2xjpbealrfej533@vireshk-i7>
Hi Viresh,
Am Dienstag, den 19.06.2018, 14:35 +0530 schrieb Viresh Kumar:
> On 08-06-18, 11:06, Bastian Stender wrote:
> > The cooling device should be part of the i.MX cpufreq driver, but it
> > cannot be removed for the sake of DT stability.
>
> I am not sure what you meant by DT stability here. Can you please explain that ?
The goal that we strive for in i.MX land is that a any newer kernel
boots on a older DT without functional regressions compared to a
matching DT/kernel pair when possible.
> What about calling both OF and non-OF calls from the cpufreq driver, based on
> the fact that data is present in DT or not ?
That's right, we could move the cooling device registration completely
to the cpufreq driver. As that would consolidate the code some more, I
agree that this is the right way to go.
Regards,
Lucas
next prev parent reply other threads:[~2018-06-19 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-08 9:06 [PATCH v3 1/2] cpufreq: imx6q/thermal: imx: register cooling device depending on OF Bastian Stender
2018-06-08 9:06 ` [PATCH v3 2/2] ARM: dts: imx: add cooling-cells for cpufreq cooling device Bastian Stender
2018-06-19 9:06 ` Viresh Kumar
2018-06-28 0:59 ` Shawn Guo
2018-06-08 11:47 ` [PATCH v3 1/2] cpufreq: imx6q/thermal: imx: register cooling device depending on OF Lucas Stach
2018-06-19 9:05 ` Viresh Kumar
2018-06-19 9:22 ` Lucas Stach [this message]
2018-06-19 9:31 ` Viresh Kumar
2018-07-04 10:51 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529400139.7211.12.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=anson.huang@nxp.com \
--cc=bst@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).