[PATCH] dt-bindings: sram: Add 'clocks' as an optional property

[PATCH] dt-bindings: sram: Add 'clocks' as an optional property

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Some SoCs (like i.MX53) need to specify the SRAM clock in the
device tree via the clocks property.

Add an entry to the optional property section.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 Documentation/devicetree/bindings/sram/sram.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
index 267da44..05689c1 100644
--- a/Documentation/devicetree/bindings/sram/sram.txt
+++ b/Documentation/devicetree/bindings/sram/sram.txt
@@ -50,6 +50,7 @@ Optional properties in the area nodes:
 		 manipulation of the page attributes.
 - label : the name for the reserved partition, if omitted, the label
           is taken from the node name excluding the unit address.
+- clocks: the clock specifier that controls the SRAM clock.
 
 Example:
 
-- 
2.7.4

Re: [PATCH] dt-bindings: sram: Add 'clocks' as an optional property

[Vladimir Zapolskiy]

Hi Fabio,

On 06/23/2018 06:22 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Some SoCs (like i.MX53) need to specify the SRAM clock in the
> device tree via the clocks property.
> 
> Add an entry to the optional property section.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  Documentation/devicetree/bindings/sram/sram.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/sram/sram.txt b/Documentation/devicetree/bindings/sram/sram.txt
> index 267da44..05689c1 100644
> --- a/Documentation/devicetree/bindings/sram/sram.txt
> +++ b/Documentation/devicetree/bindings/sram/sram.txt
> @@ -50,6 +50,7 @@ Optional properties in the area nodes:
>  		 manipulation of the page attributes.
>  - label : the name for the reserved partition, if omitted, the label
>            is taken from the node name excluding the unit address.
> +- clocks: the clock specifier that controls the SRAM clock.

just a nitpicking, all other property descriptions have a space before
a colon.

Also probably it makes sense to correct and pluralize "the clock specifier"
into a widely used form of "a list of phandle and clock specifier pairs",
while currently the driver does not support multiple clocks, it may be
extended in the future.

With that fixed,

Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>

--
Best wishes,
Vladimir