From: Sean Wang <sean.wang@mediatek.com>
To: Frank Wunderlich <FrankWu@gmx.de>
Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] [dts] fix green/blue pio-led on bananapi-r2
Date: Mon, 25 Jun 2018 17:17:43 +0800 [thread overview]
Message-ID: <1529918263.29697.31.camel@mtkswgap22> (raw)
In-Reply-To: <trinity-0d48bc23-f754-4da3-af01-c3a7abe1d34b-1529682783853@3c-app-gmx-bs42>
On Fri, 2018-06-22 at 17:53 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Sun, 17 Jun 2018 19:11:58 +0200
> Subject: [PATCH] [dts] fix green/blue pio-led
> green/blue pio-leds (near GPIO-Header) are swapped and LOW-active
> this patch restore this expected behaviour
> red cannot be switched afaik
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
> diff --git a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> index 531d905d924ff..3e8a0ffe8b13e 100644
> --- a/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> +++ b/arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dts
> @@ -89,21 +89,21 @@
> pinctrl-names = "default";
> pinctrl-0 = <&led_pins_a>;
>
> - blue {
> - label = "bpi-r2:pio:blue";
> - gpios = <&pio 241 GPIO_ACTIVE_HIGH>;
> + green {
> + label = "bpi-r2:pio:green";
> + gpios = <&pio 241 GPIO_ACTIVE_LOW>;
> default-state = "off";
> };
>
> - green {
> - label = "bpi-r2:pio:green";
> - gpios = <&pio 240 GPIO_ACTIVE_HIGH>;
> + blue {
> + label = "bpi-r2:pio:blue";
> + gpios = <&pio 240 GPIO_ACTIVE_LOW>;
> default-state = "off";
> };
>
> red {
> label = "bpi-r2:pio:red";
> - gpios = <&pio 239 GPIO_ACTIVE_HIGH>;
> + gpios = <&pio 239 GPIO_ACTIVE_LOW>;
> default-state = "off";
> };
> };
>
Hi, Frank
Node name should be listed in alphabetic order that means you should
keep the order and only have the fixes for its content.
Apart from that
Reviewed-by: Sean Wang <sean.wang@mediatek.com>
>
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2018-06-25 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <trinity-ae29ad25-a4fb-47f3-8d68-f6e58c875a0e-1529682447976@3c-app-gmx-bs42>
2018-06-22 15:53 ` [PATCH] [dts] fix green/blue pio-led on bananapi-r2 Frank Wunderlich
2018-06-25 9:17 ` Sean Wang [this message]
2018-06-25 10:05 ` [dts] [v2] " Frank Wunderlich
2018-06-27 5:54 ` Sean Wang
2018-07-16 9:16 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1529918263.29697.31.camel@mtkswgap22 \
--to=sean.wang@mediatek.com \
--cc=FrankWu@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).