From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13AF9C17447 for ; Wed, 13 Nov 2019 15:13:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB94422469 for ; Wed, 13 Nov 2019 15:13:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727452AbfKMPNs (ORCPT ); Wed, 13 Nov 2019 10:13:48 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:53251 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727772AbfKMPNr (ORCPT ); Wed, 13 Nov 2019 10:13:47 -0500 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1iUuKv-0007F5-My; Wed, 13 Nov 2019 16:13:37 +0100 Message-ID: <152f7b2bef85cec9ef107b58ba0bac153fde1379.camel@pengutronix.de> Subject: Re: [EXT] Re: [PATCH 4/5] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder From: Philipp Zabel To: Mirela Rabulea , "ezequiel@collabora.com" , "mchehab@kernel.org" , "shawnguo@kernel.org" , "robh+dt@kernel.org" Cc: dl-linux-imx , "linux-kernel@vger.kernel.org" , "laurent.pinchart+renesas@ideasonboard.com" , Aisheng Dong , Laurentiu Palcu , "linux-media@vger.kernel.org" , "paul.kocialkowski@bootlin.com" , "devicetree@vger.kernel.org" , Robert Chiras , "mark.rutland@arm.com" , "niklas.soderlund+renesas@ragnatech.se" , "hverkuil-cisco@xs4all.nl" , Daniel Baluta , Leonard Crestez , "dafna.hirschfeld@collabora.com" , "s.hauer@pengutronix.de" Date: Wed, 13 Nov 2019 16:13:36 +0100 In-Reply-To: <1573657156.16477.47.camel@nxp.com> References: <1573053633-21437-1-git-send-email-mirela.rabulea@nxp.com> <1573053633-21437-5-git-send-email-mirela.rabulea@nxp.com> <58ed179388b6f9d6caddd91dc03e411ca714157d.camel@collabora.com> <1573657156.16477.47.camel@nxp.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Ezequiel, Mirela, On Wed, 2019-11-13 at 14:59 +0000, Mirela Rabulea wrote: > Hi Ezequiel, > On Mi, 2019-11-13 at 11:00 -0300, Ezequiel Garcia wrote: > > + * default configuration stream, 64x64 yuv422 > > > + * split by JPEG marker, so it's easier to modify & use > > > + */ > > > +static const unsigned char jpeg_soi[] = {0xFF, 0xD8}; > > > +static const unsigned char jpeg_app0[] = {0xFF, 0xE0, > > I think it's time to re-consider creating some common code > > for drivers that deal with JPEG parsing. I don't know > > exactly how this should be done, but it's worth a try. > > > > Having been there, it might sound unfair to request you to > > take such action. However, someone has to do these kinds > > of cleanups and improvements, sooner or later, if we want > > to keep a clean codebase. > > > > Hope this makes sense. > > I agree, it makes sense, at least the jpeg parsing is somehow common > between these drivers. I'm willing to contribute to this, but I cannot > make a promise when, and this is something that requires collaboration > with other contributors who have the means to validate changes on all > the hardware affected. I just faced the same issue for the coda-vpu driver [1]. I wonder if my approach would be usable as a base for i.MX8 JPEGDEC as well. Either way, I'd like to collaborate on this, but I can't test most of the drivers either. [1] https://patchwork.linuxtv.org/patch/60109/ regards Philipp