devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stanley Chu <stanley.chu@mediatek.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
	devicetree@vger.kernel.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH v2 1/2] dt-bindings: Add mtk-systimer bindings
Date: Thu, 28 Jun 2018 18:24:32 +0800	[thread overview]
Message-ID: <1530181472.17448.37.camel@mtkswgap22> (raw)
In-Reply-To: <32d0da38-f014-c2c0-70ff-11cdf9ed0569@linaro.org>

On Wed, 2018-06-27 at 10:20 +0200, Daniel Lezcano wrote:
> Actually this binding already exists for mediatek timers, it is useless
> to add a new one.
> 
> I note the binding in
> 
> Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt
> 
> contains:
> 
>  clocks = <&system_clk>, <&rtc_clk>
> 
> However the existing driver does only use <&system_clk> AFAICT, I'm
> questioning if <&rtc_clk> is really needed.
> 
> So, I suggest you sort out and fixup the rtc_clk thing (drop it) and
> then just add your new platform in the list in this binding.
> 
> 
Hi Daniel,

OK! We'll fix it and merge two timers into single document file in v3.

Thanks.
Stanley Chu

  reply	other threads:[~2018-06-28 10:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-27  7:53 [PATCH v2 0/2] Add system timer driver for Mediatek SoCs Stanley Chu
     [not found] ` <1530086039-3763-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-06-27  7:53   ` [PATCH v2 1/2] dt-bindings: Add mtk-systimer bindings Stanley Chu
2018-06-27  8:20     ` Daniel Lezcano
2018-06-28 10:24       ` Stanley Chu [this message]
2018-06-27  7:53 ` [PATCH v2 2/2] clocksource/drivers/mtk_systimer: Add support for Mediatek SoCs Stanley Chu
2018-06-27  9:39   ` Daniel Lezcano
2018-06-27  9:50     ` Stanley Chu
2018-06-27  9:59       ` Daniel Lezcano
2018-06-27 10:01   ` Daniel Lezcano
2018-06-28 10:32     ` Stanley Chu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1530181472.17448.37.camel@mtkswgap22 \
    --to=stanley.chu@mediatek.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).