From: Stanley Chu <stanley.chu@mediatek.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH v3 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings
Date: Fri, 29 Jun 2018 08:15:24 +0800 [thread overview]
Message-ID: <1530231323.17448.50.camel@mtkswgap22> (raw)
In-Reply-To: <93345c88-f880-5e2e-ae36-cf1b57df9bba@linaro.org>
On Thu, 2018-06-28 at 16:08 +0200, Daniel Lezcano wrote:
> > +** System Timer (SYST)
> > +
> > +Required properties:
> > +- compatible: Should contain
> > + * "mediatek,mt6765-systimer" for MT6765 compatible timers
> > +- reg: Should contain the location and length for system timer registers.
> > +- clocks: System timer is drived by system clock.
> > +
> > +Examples:
> > +
> > + systimer@10017000 {
> > + compatible = "mediatek,mt6765-systimer";
>
> why not "mediatek,mt6765-timer" ? for consistency.
>
Hi Daniel,
The original thought is to remind user to notice that different timer
will be used.
However it looks more clean if we use consistent name.
Will fix it in v4.
> > + reg = <0 0x10017000 0 0x1000>;
> > + interrupts = <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&system_clk>;
> > };
> >
>
>
Thanks.
Stanley Chu
next prev parent reply other threads:[~2018-06-29 0:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-28 10:45 [PATCH v3 0/5] Add system timer driver for Mediatek SoCs Stanley Chu
[not found] ` <1530182744-10731-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2018-06-28 10:45 ` [PATCH v3 1/5] clocksource/drivers/timer-mediatek: Add system timer bindings Stanley Chu
2018-06-28 14:08 ` Daniel Lezcano
2018-06-29 0:15 ` Stanley Chu [this message]
2018-06-28 10:45 ` [PATCH v3 2/5] clocksource/drivers/timer-mediatek: Rename mtk_timer to timer-mediatek Stanley Chu
2018-06-28 10:45 ` [PATCH v3 5/5] clocksource/drivers/timer-mediatek: Add support for system timer Stanley Chu
2018-06-28 14:08 ` Daniel Lezcano
2018-06-29 0:16 ` Stanley Chu
2018-06-28 10:45 ` [PATCH v3 3/5] clocksource/drivers/timer-mediatek: Rename function prefix Stanley Chu
2018-06-28 10:45 ` [PATCH v3 4/5] clocksource/drivers/timer-mediatek: Convert the driver to timer-of Stanley Chu
2018-06-28 14:03 ` Daniel Lezcano
2018-06-29 0:10 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530231323.17448.50.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).