* [PATCH v2 2/3] ARM: dts: imx51: Add M4IF support
2018-07-09 18:19 [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Fabio Estevam
@ 2018-07-09 18:19 ` Fabio Estevam
2018-07-10 8:01 ` Lucas Stach
2018-07-09 18:19 ` [PATCH v2 2/2] ARM: imx51: Configure M4IF to avoid visual artifacts Fabio Estevam
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2018-07-09 18:19 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel, kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
As per the i.MX51 Reference Manual the M4IF register region
starts at 0x83fd8000 and has a 4kB address range.
Add support for it.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Tested-by: Sergey Lapin <sergey.lapin@cogentembedded.com>
---
Changes since v1:
- None
arch/arm/boot/dts/imx51.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 66e4187..b417c39 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -531,6 +531,11 @@
status = "disabled";
};
+ m4if: m4if@83fd8000 {
+ compatible = "fsl,imx51-m4if";
+ reg = <0x83fd8000 0x1000>;
+ };
+
weim: weim@83fda000 {
#address-cells = <2>;
#size-cells = <1>;
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/3] ARM: dts: imx51: Add M4IF support
2018-07-09 18:19 ` [PATCH v2 2/3] ARM: dts: imx51: Add M4IF support Fabio Estevam
@ 2018-07-10 8:01 ` Lucas Stach
0 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2018-07-10 8:01 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel, kernel
Am Montag, den 09.07.2018, 15:19 -0300 schrieb Fabio Estevam:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> As per the i.MX51 Reference Manual the M4IF register region
> starts at 0x83fd8000 and has a 4kB address range.
>
> Add support for it.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> Tested-by: Sergey Lapin <sergey.lapin@cogentembedded.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Changes since v1:
> - None
>
> arch/arm/boot/dts/imx51.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51.dtsi
> b/arch/arm/boot/dts/imx51.dtsi
> index 66e4187..b417c39 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -531,6 +531,11 @@
> status = "disabled";
> };
>
> + m4if: m4if@83fd8000 {
> + compatible = "fsl,imx51-m4if";
> + reg = <0x83fd8000 0x1000>;
> + };
> +
> weim: weim@83fda000 {
> #address-cells = <2>;
> #size-cells = <1>;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] ARM: imx51: Configure M4IF to avoid visual artifacts
2018-07-09 18:19 [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Fabio Estevam
2018-07-09 18:19 ` [PATCH v2 2/3] ARM: dts: imx51: Add M4IF support Fabio Estevam
@ 2018-07-09 18:19 ` Fabio Estevam
2018-07-09 18:23 ` Fabio Estevam
2018-07-10 7:59 ` [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Lucas Stach
` (2 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2018-07-09 18:19 UTC (permalink / raw)
To: shawnguo; +Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel, kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Configure the M4IF registers as per the vendor bootloader
to avoid visual artifacts during video playback.
This way we don't need to rely on the bootloader configuration for
optimal IPU/VPU bus priorities.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Tested-by: Sergey Lapin <sergey.lapin@cogentembedded.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
---
Changes since v1:
- None
arch/arm/mach-imx/mach-imx51.c | 29 ++++++++++++++++++++++++++++-
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-imx/mach-imx51.c b/arch/arm/mach-imx/mach-imx51.c
index 3835b6a..37ffdfa 100644
--- a/arch/arm/mach-imx/mach-imx51.c
+++ b/arch/arm/mach-imx/mach-imx51.c
@@ -12,6 +12,7 @@
#include <linux/io.h>
#include <linux/irq.h>
+#include <linux/of_address.h>
#include <linux/of_irq.h>
#include <linux/of_platform.h>
#include <asm/mach/arch.h>
@@ -48,11 +49,37 @@ static void __init imx51_ipu_mipi_setup(void)
iounmap(hsc_addr);
}
+static void __init imx51_m4if_setup(void)
+{
+ void __iomem *m4if_base;
+ struct device_node *np;
+
+ np = of_find_compatible_node(NULL, NULL, "fsl,imx51-m4if");
+ if (!np)
+ return;
+
+ m4if_base = of_iomap(np, 0);
+ if (!m4if_base) {
+ pr_err("Unable to map M4IF registers\n");
+ return;
+ }
+
+ /*
+ * Configure VPU and IPU with higher priorities
+ * in order to avoid artifacts during video playback
+ */
+ writel_relaxed(0x00000203, m4if_base + 0x40);
+ writel_relaxed(0x00000000, m4if_base + 0x44);
+ writel_relaxed(0x00120125, m4if_base + 0x9c);
+ writel_relaxed(0x001901A3, m4if_base + 0x48);
+ iounmap(m4if_base);
+}
+
static void __init imx51_dt_init(void)
{
imx51_ipu_mipi_setup();
imx_src_init();
-
+ imx51_m4if_setup();
imx_aips_allow_unprivileged_access("fsl,imx51-aipstz");
}
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v2 2/2] ARM: imx51: Configure M4IF to avoid visual artifacts
2018-07-09 18:19 ` [PATCH v2 2/2] ARM: imx51: Configure M4IF to avoid visual artifacts Fabio Estevam
@ 2018-07-09 18:23 ` Fabio Estevam
0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2018-07-09 18:23 UTC (permalink / raw)
To: Shawn Guo
Cc: Fabio Estevam,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Rob Herring,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Sascha Hauer
Hi Shawn,
Subject here should be [PATCH v2 3/3], sorry.
On Mon, Jul 9, 2018 at 3:19 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Configure the M4IF registers as per the vendor bootloader
> to avoid visual artifacts during video playback.
>
> This way we don't need to rely on the bootloader configuration for
> optimal IPU/VPU bus priorities.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> Tested-by: Sergey Lapin <sergey.lapin@cogentembedded.com>
> Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Changes since v1:
> - None
>
> arch/arm/mach-imx/mach-imx51.c | 29 ++++++++++++++++++++++++++++-
> 1 file changed, 28 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/mach-imx51.c b/arch/arm/mach-imx/mach-imx51.c
> index 3835b6a..37ffdfa 100644
> --- a/arch/arm/mach-imx/mach-imx51.c
> +++ b/arch/arm/mach-imx/mach-imx51.c
> @@ -12,6 +12,7 @@
>
> #include <linux/io.h>
> #include <linux/irq.h>
> +#include <linux/of_address.h>
> #include <linux/of_irq.h>
> #include <linux/of_platform.h>
> #include <asm/mach/arch.h>
> @@ -48,11 +49,37 @@ static void __init imx51_ipu_mipi_setup(void)
> iounmap(hsc_addr);
> }
>
> +static void __init imx51_m4if_setup(void)
> +{
> + void __iomem *m4if_base;
> + struct device_node *np;
> +
> + np = of_find_compatible_node(NULL, NULL, "fsl,imx51-m4if");
> + if (!np)
> + return;
> +
> + m4if_base = of_iomap(np, 0);
> + if (!m4if_base) {
> + pr_err("Unable to map M4IF registers\n");
> + return;
> + }
> +
> + /*
> + * Configure VPU and IPU with higher priorities
> + * in order to avoid artifacts during video playback
> + */
> + writel_relaxed(0x00000203, m4if_base + 0x40);
> + writel_relaxed(0x00000000, m4if_base + 0x44);
> + writel_relaxed(0x00120125, m4if_base + 0x9c);
> + writel_relaxed(0x001901A3, m4if_base + 0x48);
> + iounmap(m4if_base);
> +}
> +
> static void __init imx51_dt_init(void)
> {
> imx51_ipu_mipi_setup();
> imx_src_init();
> -
> + imx51_m4if_setup();
> imx_aips_allow_unprivileged_access("fsl,imx51-aipstz");
> }
>
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module
2018-07-09 18:19 [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Fabio Estevam
2018-07-09 18:19 ` [PATCH v2 2/3] ARM: dts: imx51: Add M4IF support Fabio Estevam
2018-07-09 18:19 ` [PATCH v2 2/2] ARM: imx51: Configure M4IF to avoid visual artifacts Fabio Estevam
@ 2018-07-10 7:59 ` Lucas Stach
2018-07-11 19:15 ` Rob Herring
2018-07-12 1:46 ` Shawn Guo
4 siblings, 0 replies; 8+ messages in thread
From: Lucas Stach @ 2018-07-10 7:59 UTC (permalink / raw)
To: Fabio Estevam, shawnguo
Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel, kernel
Am Montag, den 09.07.2018, 15:19 -0300 schrieb Fabio Estevam:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add bindings for the M4IF module present on i.MX51.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> Changes since v1:
> - Newly introduced in this series (Lucas)
>
> Documentation/devicetree/bindings/arm/freescale/m4if.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/freescale/m4if.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/m4if.txt b/Documentation/devicetree/bindings/arm/freescale/m4if.txt
> new file mode 100644
> index 0000000..93bd7b8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/freescale/m4if.txt
> @@ -0,0 +1,12 @@
> +* Freescale Multi Master Multi Memory Interface (M4IF) module
> +
> +Required properties:
> +- compatible : Should be "fsl,imx51-m4if"
> +- reg : Address and length of the register set for the device
> +
> +Example:
> +
> > +m4if: m4if@83fd8000 {
> > + compatible = "fsl,imx51-m4if";
> > + reg = <0x83fd8000 0x1000>;
> +};
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module
2018-07-09 18:19 [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Fabio Estevam
` (2 preceding siblings ...)
2018-07-10 7:59 ` [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Lucas Stach
@ 2018-07-11 19:15 ` Rob Herring
2018-07-12 1:46 ` Shawn Guo
4 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2018-07-11 19:15 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, devicetree, shawnguo, linux-arm-kernel, kernel
On Mon, Jul 09, 2018 at 03:19:13PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add bindings for the M4IF module present on i.MX51.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Newly introduced in this series (Lucas)
>
> Documentation/devicetree/bindings/arm/freescale/m4if.txt | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/freescale/m4if.txt
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module
2018-07-09 18:19 [PATCH v2 1/3] dt-bindings: freescale: Add bindings for the M4IF module Fabio Estevam
` (3 preceding siblings ...)
2018-07-11 19:15 ` Rob Herring
@ 2018-07-12 1:46 ` Shawn Guo
4 siblings, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2018-07-12 1:46 UTC (permalink / raw)
To: Fabio Estevam
Cc: Fabio Estevam, devicetree, robh+dt, linux-arm-kernel, kernel
On Mon, Jul 09, 2018 at 03:19:13PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Add bindings for the M4IF module present on i.MX51.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
Applied all, thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread