* [PATCH v2] ARM64: dts: meson-axg: add saradc support
@ 2018-07-02 22:25 Yixun Lan
2018-07-09 21:47 ` Kevin Hilman
2018-07-11 16:25 ` Jerome Brunet
0 siblings, 2 replies; 5+ messages in thread
From: Yixun Lan @ 2018-07-02 22:25 UTC (permalink / raw)
To: Kevin Hilman
Cc: Xingyu Chen, Yixun Lan, linux-amlogic, linux-arm-kernel,
linux-kernel, devicetree
From: Xingyu Chen <xingyu.chen@amlogic.com>
Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
---
Hi kevin
I just re-send this patch which rebased to your khilman/v4.18/integ branch
Thanks
Yixun
nothing changed since patch v1 [1]:
-
[1] https://lkml.kernel.org/r/20180326092117.208416-1-yixun.lan@amlogic.com
---
.../arm64/boot/dts/amlogic/meson-axg-s400.dts | 5 +++++
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 21 +++++++++++++++++++
2 files changed, 26 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
index 4b3331fbfe39..6041f68b32ae 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
@@ -153,3 +153,8 @@
compatible = "brcm,bcm4329-fmac";
};
};
+
+&saradc {
+ status = "okay";
+ vref-supply = <&vddio_ao18>;
+};
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index 67d7115e4eff..52678a69dbf8 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -91,6 +91,13 @@
method = "smc";
};
+ vddio_ao18: regulator-vddio_ao18 {
+ compatible = "regulator-fixed";
+ regulator-name = "VDDIO_AO18";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ };
+
timer {
compatible = "arm,armv8-timer";
interrupts = <GIC_PPI 13
@@ -1194,6 +1201,20 @@
interrupts = <GIC_SPI 196 IRQ_TYPE_EDGE_RISING>;
status = "disabled";
};
+
+ saradc: adc@9000 {
+ compatible = "amlogic,meson-axg-saradc",
+ "amlogic,meson-saradc";
+ reg = <0x0 0x9000 0x0 0x38>;
+ #io-channel-cells = <1>;
+ interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
+ clocks = <&xtal>,
+ <&clkc_AO CLKID_AO_SAR_ADC>,
+ <&clkc_AO CLKID_AO_SAR_ADC_CLK>,
+ <&clkc_AO CLKID_AO_SAR_ADC_SEL>;
+ clock-names = "clkin", "core", "adc_clk", "adc_sel";
+ status = "disabled";
+ };
};
};
};
--
2.18.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM64: dts: meson-axg: add saradc support
2018-07-02 22:25 [PATCH v2] ARM64: dts: meson-axg: add saradc support Yixun Lan
@ 2018-07-09 21:47 ` Kevin Hilman
2018-07-11 16:25 ` Jerome Brunet
1 sibling, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2018-07-09 21:47 UTC (permalink / raw)
To: Yixun Lan
Cc: Xingyu Chen, linux-amlogic, linux-arm-kernel, linux-kernel,
devicetree
Yixun Lan <yixun.lan@amlogic.com> writes:
> From: Xingyu Chen <xingyu.chen@amlogic.com>
>
> Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> Hi kevin
> I just re-send this patch which rebased to your khilman/v4.18/integ branch
> Thanks
> Yixun
>
> nothing changed since patch v1 [1]:
Applied to v4.19/dt64,
Thanks,
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] ARM64: dts: meson-axg: add saradc support
2018-07-02 22:25 [PATCH v2] ARM64: dts: meson-axg: add saradc support Yixun Lan
2018-07-09 21:47 ` Kevin Hilman
@ 2018-07-11 16:25 ` Jerome Brunet
2018-07-16 13:52 ` Kevin Hilman
1 sibling, 1 reply; 5+ messages in thread
From: Jerome Brunet @ 2018-07-11 16:25 UTC (permalink / raw)
To: Yixun Lan, Kevin Hilman
Cc: Xingyu Chen, linux-amlogic, linux-arm-kernel, linux-kernel,
devicetree
On Mon, 2018-07-02 at 22:25 +0000, Yixun Lan wrote:
> From: Xingyu Chen <xingyu.chen@amlogic.com>
>
> Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
>
> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
> ---
> Hi kevin
> I just re-send this patch which rebased to your khilman/v4.18/integ branch
> Thanks
> Yixun
>
> nothing changed since patch v1 [1]:
> -
>
> [1] https://lkml.kernel.org/r/20180326092117.208416-1-yixun.lan@amlogic.com
>
> ---
> .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 5 +++++
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 21 +++++++++++++++++++
> 2 files changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> index 4b3331fbfe39..6041f68b32ae 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
> @@ -153,3 +153,8 @@
> compatible = "brcm,bcm4329-fmac";
> };
> };
> +
> +&saradc {
> + status = "okay";
> + vref-supply = <&vddio_ao18>;
> +};
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index 67d7115e4eff..52678a69dbf8 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -91,6 +91,13 @@
> method = "smc";
> };
>
> + vddio_ao18: regulator-vddio_ao18 {
> + compatible = "regulator-fixed";
> + regulator-name = "VDDIO_AO18";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
Kevin, Yixun,
I find odd that we are adding a regulator to SoC device tree file.
Those regulator are usually part of board file
Unless the regulator is actually inside the SoC, this is not the place for it.
Sorry for not catching this earlier.
> +
> timer {
> compatible = "arm,armv8-timer";
> interrupts = <GIC_PPI 13
> @@ -1194,6 +1201,20 @@
> interrupts = <GIC_SPI 196 IRQ_TYPE_EDGE_RISING>;
> status = "disabled";
> };
> +
> + saradc: adc@9000 {
> + compatible = "amlogic,meson-axg-saradc",
> + "amlogic,meson-saradc";
> + reg = <0x0 0x9000 0x0 0x38>;
> + #io-channel-cells = <1>;
> + interrupts = <GIC_SPI 73 IRQ_TYPE_EDGE_RISING>;
> + clocks = <&xtal>,
> + <&clkc_AO CLKID_AO_SAR_ADC>,
> + <&clkc_AO CLKID_AO_SAR_ADC_CLK>,
> + <&clkc_AO CLKID_AO_SAR_ADC_SEL>;
> + clock-names = "clkin", "core", "adc_clk", "adc_sel";
> + status = "disabled";
> + };
> };
> };
> };
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM64: dts: meson-axg: add saradc support
2018-07-11 16:25 ` Jerome Brunet
@ 2018-07-16 13:52 ` Kevin Hilman
2018-07-17 15:28 ` Kevin Hilman
0 siblings, 1 reply; 5+ messages in thread
From: Kevin Hilman @ 2018-07-16 13:52 UTC (permalink / raw)
To: Jerome Brunet
Cc: Yixun Lan, Xingyu Chen, linux-amlogic, linux-arm-kernel,
linux-kernel, devicetree
Jerome Brunet <jbrunet@baylibre.com> writes:
> On Mon, 2018-07-02 at 22:25 +0000, Yixun Lan wrote:
>> From: Xingyu Chen <xingyu.chen@amlogic.com>
>>
>> Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
>>
>> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>> ---
>> Hi kevin
>> I just re-send this patch which rebased to your khilman/v4.18/integ branch
>> Thanks
>> Yixun
>>
>> nothing changed since patch v1 [1]:
>> -
>>
>> [1] https://lkml.kernel.org/r/20180326092117.208416-1-yixun.lan@amlogic.com
>>
>> ---
>> .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 5 +++++
>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 21 +++++++++++++++++++
>> 2 files changed, 26 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> index 4b3331fbfe39..6041f68b32ae 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>> @@ -153,3 +153,8 @@
>> compatible = "brcm,bcm4329-fmac";
>> };
>> };
>> +
>> +&saradc {
>> + status = "okay";
>> + vref-supply = <&vddio_ao18>;
>> +};
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index 67d7115e4eff..52678a69dbf8 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -91,6 +91,13 @@
>> method = "smc";
>> };
>>
>> + vddio_ao18: regulator-vddio_ao18 {
>> + compatible = "regulator-fixed";
>> + regulator-name = "VDDIO_AO18";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + };
>
> Kevin, Yixun,
>
> I find odd that we are adding a regulator to SoC device tree file.
> Those regulator are usually part of board file
>
> Unless the regulator is actually inside the SoC, this is not the place for it.
>
> Sorry for not catching this earlier.
You're right, I should've noticed this earlier also.
Yixun, can you resend this with the regulators in the board file please?
In the mean time, I've dropped this from v4.19/dt64 branch,
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] ARM64: dts: meson-axg: add saradc support
2018-07-16 13:52 ` Kevin Hilman
@ 2018-07-17 15:28 ` Kevin Hilman
0 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2018-07-17 15:28 UTC (permalink / raw)
To: Jerome Brunet
Cc: Yixun Lan, Xingyu Chen, linux-amlogic, linux-arm-kernel,
linux-kernel, devicetree
Kevin Hilman <khilman@baylibre.com> writes:
> Jerome Brunet <jbrunet@baylibre.com> writes:
>
>> On Mon, 2018-07-02 at 22:25 +0000, Yixun Lan wrote:
>>> From: Xingyu Chen <xingyu.chen@amlogic.com>
>>>
>>> Add the DT info for SAR ADC of the Amlogic's Meson-AXG SoC.
>>>
>>> Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
>>> Signed-off-by: Yixun Lan <yixun.lan@amlogic.com>
>>> ---
>>> Hi kevin
>>> I just re-send this patch which rebased to your khilman/v4.18/integ branch
>>> Thanks
>>> Yixun
>>>
>>> nothing changed since patch v1 [1]:
>>> -
>>>
>>> [1] https://lkml.kernel.org/r/20180326092117.208416-1-yixun.lan@amlogic.com
>>>
>>> ---
>>> .../arm64/boot/dts/amlogic/meson-axg-s400.dts | 5 +++++
>>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 21 +++++++++++++++++++
>>> 2 files changed, 26 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> index 4b3331fbfe39..6041f68b32ae 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg-s400.dts
>>> @@ -153,3 +153,8 @@
>>> compatible = "brcm,bcm4329-fmac";
>>> };
>>> };
>>> +
>>> +&saradc {
>>> + status = "okay";
>>> + vref-supply = <&vddio_ao18>;
>>> +};
>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> index 67d7115e4eff..52678a69dbf8 100644
>>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>>> @@ -91,6 +91,13 @@
>>> method = "smc";
>>> };
>>>
>>> + vddio_ao18: regulator-vddio_ao18 {
>>> + compatible = "regulator-fixed";
>>> + regulator-name = "VDDIO_AO18";
>>> + regulator-min-microvolt = <1800000>;
>>> + regulator-max-microvolt = <1800000>;
>>> + };
>>
>> Kevin, Yixun,
>>
>> I find odd that we are adding a regulator to SoC device tree file.
>> Those regulator are usually part of board file
>>
>> Unless the regulator is actually inside the SoC, this is not the place for it.
>>
>> Sorry for not catching this earlier.
>
> You're right, I should've noticed this earlier also.
>
> Yixun, can you resend this with the regulators in the board file please?
>
> In the mean time, I've dropped this from v4.19/dt64 branch,
Nevermind, Jerome fixed this up already in a series of DT updates for
AXG, so I'll keep it as is.
Thanks Jerome!
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-07-17 15:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-02 22:25 [PATCH v2] ARM64: dts: meson-axg: add saradc support Yixun Lan
2018-07-09 21:47 ` Kevin Hilman
2018-07-11 16:25 ` Jerome Brunet
2018-07-16 13:52 ` Kevin Hilman
2018-07-17 15:28 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).