* [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega
2018-08-07 17:02 [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Arun Parameswaran
@ 2018-08-07 17:02 ` Arun Parameswaran
2018-08-07 17:06 ` Florian Fainelli
2018-08-14 20:41 ` Rob Herring
2018-08-07 17:02 ` [PATCH 2/3] net: dsa: b53: Add support for Broadcom Omega SoC internal switch Arun Parameswaran
` (2 subsequent siblings)
3 siblings, 2 replies; 10+ messages in thread
From: Arun Parameswaran @ 2018-08-07 17:02 UTC (permalink / raw)
To: David S. Miller, Florian Fainelli, Andrew Lunn, Vivien Didelot,
Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list,
Arun Parameswaran
Add compatibility strings for the internal switch in the Broadcom
Omega SoC family (BCM5831X/BCM1140X) to B53.
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
---
Documentation/devicetree/bindings/net/dsa/b53.txt | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/b53.txt b/Documentation/devicetree/bindings/net/dsa/b53.txt
index 47a6a7f..1811e19 100644
--- a/Documentation/devicetree/bindings/net/dsa/b53.txt
+++ b/Documentation/devicetree/bindings/net/dsa/b53.txt
@@ -24,6 +24,14 @@ Required properties:
"brcm,bcm53018-srab"
"brcm,bcm53019-srab" and the mandatory "brcm,bcm5301x-srab" string
+ For the BCM5831X/BCM1140x SoCs with an integrated switch, must be one of:
+ "brcm,bcm11404-srab"
+ "brcm,bcm11407-srab"
+ "brcm,bcm11409-srab"
+ "brcm,bcm58310-srab"
+ "brcm,bcm58311-srab"
+ "brcm,bcm58313-srab" and the mandatory "brcm,omega-srab" string
+
For the BCM585xx/586XX/88312 SoCs with an integrated switch, must be one of:
"brcm,bcm58522-srab"
"brcm,bcm58523-srab"
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega
2018-08-07 17:02 ` [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega Arun Parameswaran
@ 2018-08-07 17:06 ` Florian Fainelli
2018-08-14 20:41 ` Rob Herring
1 sibling, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2018-08-07 17:06 UTC (permalink / raw)
To: Arun Parameswaran, David S. Miller, Florian Fainelli, Andrew Lunn,
Vivien Didelot, Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list
On 08/07/2018 10:02 AM, Arun Parameswaran wrote:
> Add compatibility strings for the internal switch in the Broadcom
> Omega SoC family (BCM5831X/BCM1140X) to B53.
>
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega
2018-08-07 17:02 ` [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega Arun Parameswaran
2018-08-07 17:06 ` Florian Fainelli
@ 2018-08-14 20:41 ` Rob Herring
1 sibling, 0 replies; 10+ messages in thread
From: Rob Herring @ 2018-08-14 20:41 UTC (permalink / raw)
Cc: David S. Miller, Florian Fainelli, Andrew Lunn, Vivien Didelot,
Mark Rutland, netdev, devicetree, linux-kernel,
bcm-kernel-feedback-list, Arun Parameswaran
On Tue, 7 Aug 2018 10:02:42 -0700, Arun Parameswaran wrote:
> Add compatibility strings for the internal switch in the Broadcom
> Omega SoC family (BCM5831X/BCM1140X) to B53.
>
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
> ---
> Documentation/devicetree/bindings/net/dsa/b53.txt | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] net: dsa: b53: Add support for Broadcom Omega SoC internal switch
2018-08-07 17:02 [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Arun Parameswaran
2018-08-07 17:02 ` [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega Arun Parameswaran
@ 2018-08-07 17:02 ` Arun Parameswaran
2018-08-07 17:06 ` Florian Fainelli
2018-08-07 17:02 ` [PATCH 3/3] net: phy: Add support for Broadcom Omega internal Combo GPHY Arun Parameswaran
2018-08-07 18:08 ` [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Andrew Lunn
3 siblings, 1 reply; 10+ messages in thread
From: Arun Parameswaran @ 2018-08-07 17:02 UTC (permalink / raw)
To: David S. Miller, Florian Fainelli, Andrew Lunn, Vivien Didelot,
Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list,
Arun Parameswaran
Add support for the Broadcom Omega SoC internal ethernet switch
to the b53 srab driver in the DSA framework.
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
---
drivers/net/dsa/b53/b53_srab.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/dsa/b53/b53_srab.c b/drivers/net/dsa/b53/b53_srab.c
index 8247481..91de2ba 100644
--- a/drivers/net/dsa/b53/b53_srab.c
+++ b/drivers/net/dsa/b53/b53_srab.c
@@ -374,6 +374,7 @@ static int b53_srab_write64(struct b53_device *dev, u8 page, u8 reg,
{ .compatible = "brcm,bcm88312-srab", .data = (void *)BCM58XX_DEVICE_ID },
{ .compatible = "brcm,cygnus-srab", .data = (void *)BCM583XX_DEVICE_ID },
{ .compatible = "brcm,nsp-srab", .data = (void *)BCM58XX_DEVICE_ID },
+ { .compatible = "brcm,omega-srab", .data = (void *)BCM583XX_DEVICE_ID },
{ /* sentinel */ },
};
MODULE_DEVICE_TABLE(of, b53_srab_of_match);
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] net: dsa: b53: Add support for Broadcom Omega SoC internal switch
2018-08-07 17:02 ` [PATCH 2/3] net: dsa: b53: Add support for Broadcom Omega SoC internal switch Arun Parameswaran
@ 2018-08-07 17:06 ` Florian Fainelli
0 siblings, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2018-08-07 17:06 UTC (permalink / raw)
To: Arun Parameswaran, David S. Miller, Florian Fainelli, Andrew Lunn,
Vivien Didelot, Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list
On 08/07/2018 10:02 AM, Arun Parameswaran wrote:
> Add support for the Broadcom Omega SoC internal ethernet switch
> to the b53 srab driver in the DSA framework.
>
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] net: phy: Add support for Broadcom Omega internal Combo GPHY
2018-08-07 17:02 [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Arun Parameswaran
2018-08-07 17:02 ` [PATCH 1/3] dt-bindings: net: dsa: Add compatibility strings for Broadcom Omega Arun Parameswaran
2018-08-07 17:02 ` [PATCH 2/3] net: dsa: b53: Add support for Broadcom Omega SoC internal switch Arun Parameswaran
@ 2018-08-07 17:02 ` Arun Parameswaran
2018-08-07 17:06 ` Florian Fainelli
2018-08-07 18:08 ` [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Andrew Lunn
3 siblings, 1 reply; 10+ messages in thread
From: Arun Parameswaran @ 2018-08-07 17:02 UTC (permalink / raw)
To: David S. Miller, Florian Fainelli, Andrew Lunn, Vivien Didelot,
Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list,
Arun Parameswaran
Add support for the Broadcom Omega SoC internal Combo Ethernet
GPHY to the bcm7xxx phy driver.
Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
---
drivers/net/phy/bcm7xxx.c | 2 ++
include/linux/brcmphy.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c
index 01d2ff2f..b2b6307 100644
--- a/drivers/net/phy/bcm7xxx.c
+++ b/drivers/net/phy/bcm7xxx.c
@@ -229,6 +229,7 @@ static int bcm7xxx_28nm_config_init(struct phy_device *phydev)
phy_read(phydev, MII_BMSR);
switch (rev) {
+ case 0xa0:
case 0xb0:
ret = bcm7xxx_28nm_b0_afe_config_init(phydev);
break;
@@ -659,6 +660,7 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev)
BCM7XXX_28NM_GPHY(PHY_ID_BCM7439, "Broadcom BCM7439"),
BCM7XXX_28NM_GPHY(PHY_ID_BCM7439_2, "Broadcom BCM7439 (2)"),
BCM7XXX_28NM_GPHY(PHY_ID_BCM7445, "Broadcom BCM7445"),
+ BCM7XXX_28NM_GPHY(PHY_ID_BCM_OMEGA, "Broadcom Omega Combo GPHY"),
BCM7XXX_40NM_EPHY(PHY_ID_BCM7346, "Broadcom BCM7346"),
BCM7XXX_40NM_EPHY(PHY_ID_BCM7362, "Broadcom BCM7362"),
BCM7XXX_40NM_EPHY(PHY_ID_BCM7425, "Broadcom BCM7425"),
diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
index daa9234..949e9af 100644
--- a/include/linux/brcmphy.h
+++ b/include/linux/brcmphy.h
@@ -45,6 +45,7 @@
#define PHY_ID_BCM7445 0x600d8510
#define PHY_ID_BCM_CYGNUS 0xae025200
+#define PHY_ID_BCM_OMEGA 0xae025100
#define PHY_BCM_OUI_MASK 0xfffffc00
#define PHY_BCM_OUI_1 0x00206000
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] net: phy: Add support for Broadcom Omega internal Combo GPHY
2018-08-07 17:02 ` [PATCH 3/3] net: phy: Add support for Broadcom Omega internal Combo GPHY Arun Parameswaran
@ 2018-08-07 17:06 ` Florian Fainelli
0 siblings, 0 replies; 10+ messages in thread
From: Florian Fainelli @ 2018-08-07 17:06 UTC (permalink / raw)
To: Arun Parameswaran, David S. Miller, Florian Fainelli, Andrew Lunn,
Vivien Didelot, Rob Herring, Mark Rutland
Cc: netdev, devicetree, linux-kernel, bcm-kernel-feedback-list
On 08/07/2018 10:02 AM, Arun Parameswaran wrote:
> Add support for the Broadcom Omega SoC internal Combo Ethernet
> GPHY to the bcm7xxx phy driver.
>
> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy
2018-08-07 17:02 [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Arun Parameswaran
` (2 preceding siblings ...)
2018-08-07 17:02 ` [PATCH 3/3] net: phy: Add support for Broadcom Omega internal Combo GPHY Arun Parameswaran
@ 2018-08-07 18:08 ` Andrew Lunn
2018-08-07 22:49 ` David Miller
3 siblings, 1 reply; 10+ messages in thread
From: Andrew Lunn @ 2018-08-07 18:08 UTC (permalink / raw)
To: Arun Parameswaran
Cc: David S. Miller, Florian Fainelli, Vivien Didelot, Rob Herring,
Mark Rutland, netdev, devicetree, linux-kernel,
bcm-kernel-feedback-list
On Tue, Aug 07, 2018 at 10:02:41AM -0700, Arun Parameswaran wrote:
> Hi,
>
> The patchset is based on David Miller's "net-next" repo.
>
> The patches add support for the Broadcom Omega SoC's internal ethernet
> switch and the internal gphy.
>
> The internal ethernet switch in the Omega is a b53 srab based switch.
> The support for the switch is added to the b53 driver in the dsa
> framework.
>
> The gphy support is added to the bcm7xxx driver.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy
2018-08-07 18:08 ` [PATCH 0/3] Add Broadcom Omega SoC internal switch and phy Andrew Lunn
@ 2018-08-07 22:49 ` David Miller
0 siblings, 0 replies; 10+ messages in thread
From: David Miller @ 2018-08-07 22:49 UTC (permalink / raw)
To: andrew
Cc: arun.parameswaran, f.fainelli, vivien.didelot, robh+dt,
mark.rutland, netdev, devicetree, linux-kernel,
bcm-kernel-feedback-list
From: Andrew Lunn <andrew@lunn.ch>
Date: Tue, 7 Aug 2018 20:08:27 +0200
> On Tue, Aug 07, 2018 at 10:02:41AM -0700, Arun Parameswaran wrote:
>> Hi,
>>
>> The patchset is based on David Miller's "net-next" repo.
>>
>> The patches add support for the Broadcom Omega SoC's internal ethernet
>> switch and the internal gphy.
>>
>> The internal ethernet switch in the Omega is a b53 srab based switch.
>> The support for the switch is added to the b53 driver in the dsa
>> framework.
>>
>> The gphy support is added to the bcm7xxx driver.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Series applied.
^ permalink raw reply [flat|nested] 10+ messages in thread