From: Tomasz Figa <t.figa@samsung.com>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
kgene.kim@samsung.com
Subject: Re: [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi
Date: Wed, 30 Oct 2013 15:44:38 +0100 [thread overview]
Message-ID: <1533785.9eqjzOAEYK@amdc1227> (raw)
In-Reply-To: <1383127554-13854-1-git-send-email-sachin.kamat@linaro.org>
Hi Sachin,
On Wednesday 30 of October 2013 15:35:53 Sachin Kamat wrote:
> Fix the name as per DT node naming convention.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> arch/arm/boot/dts/exynos4.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index e262946..68479c3 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -99,7 +99,7 @@
> reg = <0x10440000 0x1000>;
> };
>
> - sys_reg: sysreg {
> + sys_reg: sysreg@10010000 {
While at changing node name, could you rename it to syscon? Nodes
should have more generic names, while sysreg is an Exynos-specific term.
Best regards.
Tomasz
prev parent reply other threads:[~2013-10-30 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-30 10:05 [PATCH 1/2] ARM: dts: Fix sysreg node name in exynos4.dtsi Sachin Kamat
2013-10-30 10:05 ` [PATCH 2/2] ARM: dts: Update Samsung sysreg binding document Sachin Kamat
2013-10-30 14:44 ` Tomasz Figa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1533785.9eqjzOAEYK@amdc1227 \
--to=t.figa@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).