* [PATCH v3] usb: core: phy: fix return value checking about devm_of_phy_get_by_index()
@ 2018-08-30 1:16 Chunfeng Yun
2018-08-31 9:41 ` Johan Hovold
0 siblings, 1 reply; 3+ messages in thread
From: Chunfeng Yun @ 2018-08-30 1:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Felipe Balbi
Cc: Martin Blumenstingl, Matthias Brugger, Johan Hovold, Chunfeng Yun,
linux-usb, devicetree, linux-kernel, linux-arm-kernel,
linux-mediatek
Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index()
never return NULL value;
But still need ignore the error of -ENODEV, for more information, please
refer to:
[0] https://lkml.org/lkml/2018/4/19/88
[1] https://patchwork.kernel.org/patch/10160181/
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
V3: abandon the ternary operator suggested by Johan
V2: keep the -ENODEV check
---
drivers/usb/core/phy.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
index 9879767..38b2c77 100644
--- a/drivers/usb/core/phy.c
+++ b/drivers/usb/core/phy.c
@@ -23,10 +23,11 @@ static int usb_phy_roothub_add_phy(struct device *dev, int index,
struct list_head *list)
{
struct usb_phy_roothub *roothub_entry;
- struct phy *phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
+ struct phy *phy;
- if (IS_ERR_OR_NULL(phy)) {
- if (!phy || PTR_ERR(phy) == -ENODEV)
+ phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
+ if (IS_ERR(phy)) {
+ if (PTR_ERR(phy) == -ENODEV)
return 0;
else
return PTR_ERR(phy);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v3] usb: core: phy: fix return value checking about devm_of_phy_get_by_index()
2018-08-30 1:16 [PATCH v3] usb: core: phy: fix return value checking about devm_of_phy_get_by_index() Chunfeng Yun
@ 2018-08-31 9:41 ` Johan Hovold
2018-08-31 10:03 ` Chunfeng Yun
0 siblings, 1 reply; 3+ messages in thread
From: Johan Hovold @ 2018-08-31 9:41 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Greg Kroah-Hartman, Felipe Balbi, Martin Blumenstingl,
Matthias Brugger, Johan Hovold, linux-usb, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek
On Thu, Aug 30, 2018 at 09:16:40AM +0800, Chunfeng Yun wrote:
> Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index()
> never return NULL value;
> But still need ignore the error of -ENODEV, for more information, please
> refer to:
> [0] https://lkml.org/lkml/2018/4/19/88
> [1] https://patchwork.kernel.org/patch/10160181/
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> V3: abandon the ternary operator suggested by Johan
>
> V2: keep the -ENODEV check
Perhaps the patch Subject is a little misleading as this is more of a
clean up than a fix (as there's no bug here).
But apart from that this looks good to me.
Reviewed-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/usb/core/phy.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
> index 9879767..38b2c77 100644
> --- a/drivers/usb/core/phy.c
> +++ b/drivers/usb/core/phy.c
> @@ -23,10 +23,11 @@ static int usb_phy_roothub_add_phy(struct device *dev, int index,
> struct list_head *list)
> {
> struct usb_phy_roothub *roothub_entry;
> - struct phy *phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
> + struct phy *phy;
>
> - if (IS_ERR_OR_NULL(phy)) {
> - if (!phy || PTR_ERR(phy) == -ENODEV)
> + phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
> + if (IS_ERR(phy)) {
> + if (PTR_ERR(phy) == -ENODEV)
> return 0;
> else
> return PTR_ERR(phy);
Thanks,
Johan
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] usb: core: phy: fix return value checking about devm_of_phy_get_by_index()
2018-08-31 9:41 ` Johan Hovold
@ 2018-08-31 10:03 ` Chunfeng Yun
0 siblings, 0 replies; 3+ messages in thread
From: Chunfeng Yun @ 2018-08-31 10:03 UTC (permalink / raw)
To: Johan Hovold
Cc: Greg Kroah-Hartman, Felipe Balbi, Martin Blumenstingl,
Matthias Brugger, linux-usb, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
On Fri, 2018-08-31 at 11:41 +0200, Johan Hovold wrote:
> On Thu, Aug 30, 2018 at 09:16:40AM +0800, Chunfeng Yun wrote:
> > Use IS_ERR() instead of IS_ERR_OR_NULL() because devm_of_phy_get_by_index()
> > never return NULL value;
> > But still need ignore the error of -ENODEV, for more information, please
> > refer to:
> > [0] https://lkml.org/lkml/2018/4/19/88
> > [1] https://patchwork.kernel.org/patch/10160181/
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > V3: abandon the ternary operator suggested by Johan
> >
> > V2: keep the -ENODEV check
>
> Perhaps the patch Subject is a little misleading as this is more of a
> clean up than a fix (as there's no bug here).
>
> But apart from that this looks good to me.
>
> Reviewed-by: Johan Hovold <johan@kernel.org>
Sent a new version, thanks
>
> > ---
> > drivers/usb/core/phy.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/core/phy.c b/drivers/usb/core/phy.c
> > index 9879767..38b2c77 100644
> > --- a/drivers/usb/core/phy.c
> > +++ b/drivers/usb/core/phy.c
> > @@ -23,10 +23,11 @@ static int usb_phy_roothub_add_phy(struct device *dev, int index,
> > struct list_head *list)
> > {
> > struct usb_phy_roothub *roothub_entry;
> > - struct phy *phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
> > + struct phy *phy;
> >
> > - if (IS_ERR_OR_NULL(phy)) {
> > - if (!phy || PTR_ERR(phy) == -ENODEV)
> > + phy = devm_of_phy_get_by_index(dev, dev->of_node, index);
> > + if (IS_ERR(phy)) {
> > + if (PTR_ERR(phy) == -ENODEV)
> > return 0;
> > else
> > return PTR_ERR(phy);
>
> Thanks,
> Johan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-31 10:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-30 1:16 [PATCH v3] usb: core: phy: fix return value checking about devm_of_phy_get_by_index() Chunfeng Yun
2018-08-31 9:41 ` Johan Hovold
2018-08-31 10:03 ` Chunfeng Yun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).