From: Philipp Zabel <p.zabel@pengutronix.de>
To: Nava kishore Manne <nava.manne@xilinx.com>,
robh+dt@kernel.org, mark.rutland@arm.com,
michal.simek@xilinx.com, rajanv@xilinx.com, jollys@xilinx.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v3 2/3] dt-bindings: reset: Add bindings for ZynqMP reset driver
Date: Wed, 05 Sep 2018 12:09:48 +0200 [thread overview]
Message-ID: <1536142188.4084.1.camel@pengutronix.de> (raw)
In-Reply-To: <1536131342-28041-3-git-send-email-nava.manne@xilinx.com>
Hi,
On Wed, 2018-09-05 at 12:39 +0530, Nava kishore Manne wrote:
> Add documentation to describe Xilinx ZynqMP reset driver
> bindings.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v3:
> -Corrected Commit Msg.
> Changes for v2:
> -Moved reset node as a child to firwmare
> node.
>
> .../firmware/xilinx/xlnx,zynqmp-firmware.txt | 142 +++++++++++++++++++++
> 1 file changed, 142 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> index 1b431d9..351b1bb 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.txt
[...]
> -------
> Example
> -------
> @@ -25,5 +163,9 @@ firmware {
> zynqmp_firmware: zynqmp-firmware {
> compatible = "xlnx,zynqmp-firmware";
> method = "smc";
> + reset-controller:reset-controller@0 {
I think the label should use underscore instead of hyphen, and the unit
address part should be removed from the node name. There is no unit
address, as there is no reg property inside the node and the parent node
doesn't have #address-cells:
reset_controller: reset-controller {
> + compatible = "xlnx,zynqmp-reset";
> + #reset-cells = <1>;
> + };
> };
> };
regards
Philipp
next prev parent reply other threads:[~2018-09-05 10:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 7:08 [RFC PATCH v3 0/3] Add reset driver support for ZynqMP Nava kishore Manne
2018-09-05 7:09 ` [RFC PATCH v3 1/3] firmware: xilinx: Add reset API's Nava kishore Manne
2018-09-05 10:29 ` Philipp Zabel
2018-09-10 4:47 ` Nava kishore Manne
2018-09-05 7:09 ` [RFC PATCH v3 2/3] dt-bindings: reset: Add bindings for ZynqMP reset driver Nava kishore Manne
2018-09-05 10:09 ` Philipp Zabel [this message]
2018-09-10 4:43 ` Nava kishore Manne
2018-09-10 20:12 ` Rob Herring
2018-09-17 9:09 ` Nava kishore Manne
2018-09-05 7:09 ` [RFC PATCH v3 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller Nava kishore Manne
2018-09-05 10:29 ` Philipp Zabel
2018-09-10 4:49 ` Nava kishore Manne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536142188.4084.1.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=jollys@xilinx.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michal.simek@xilinx.com \
--cc=nava.manne@xilinx.com \
--cc=rajanv@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).