From: Ley Foon Tan <ley.foon.tan@intel.com>
To: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: nios2-dev@lists.rocketboards.org
Subject: Re: [PATCH v2 2/9] nios2: build .dtb files in dts directory
Date: Fri, 07 Sep 2018 10:21:35 +0800 [thread overview]
Message-ID: <1536286895.6128.4.camel@intel.com> (raw)
In-Reply-To: <20180905235327.5996-3-robh@kernel.org>
On Wed, 2018-09-05 at 18:53 -0500, Rob Herring wrote:
> Align nios2 with other architectures which build the dtb files in the
> same directory as the dts files. This is also in line with most other
> build targets which are located in the same directory as the source.
> This move will help enable the 'dtbs' target which builds all the
> dtbs
> regardless of kernel config.
>
> This transition could break some scripts if they expect dtb files in
> the old location.
>
> Cc: Ley Foon Tan <lftan@altera.com>
> Cc: nios2-dev@lists.rocketboards.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Please ack so I can take the whole series via the DT tree.
>
> arch/nios2/Makefile | 4 ++--
> arch/nios2/boot/Makefile | 4 ----
> arch/nios2/boot/dts/Makefile | 1 +
> 3 files changed, 3 insertions(+), 6 deletions(-)
> create mode 100644 arch/nios2/boot/dts/Makefile
>
> diff --git a/arch/nios2/Makefile b/arch/nios2/Makefile
> index 8673a79dca9c..50eece1c6adb 100644
> --- a/arch/nios2/Makefile
> +++ b/arch/nios2/Makefile
> @@ -59,10 +59,10 @@ archclean:
> $(Q)$(MAKE) $(clean)=$(nios2-boot)
>
> %.dtb: | scripts
> - $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
> + $(Q)$(MAKE) $(build)=$(nios2-boot)/dts $(nios2-boot)/dts/$@
>
> dtbs:
> - $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
> + $(Q)$(MAKE) $(build)=$(nios2-boot)/dts
>
> $(BOOT_TARGETS): vmlinux
> $(Q)$(MAKE) $(build)=$(nios2-boot) $(nios2-boot)/$@
> diff --git a/arch/nios2/boot/Makefile b/arch/nios2/boot/Makefile
> index 2ba23a679732..007586094dde 100644
> --- a/arch/nios2/boot/Makefile
> +++ b/arch/nios2/boot/Makefile
> @@ -47,10 +47,6 @@ obj-$(CONFIG_NIOS2_DTB_SOURCE_BOOL) +=
> linked_dtb.o
>
> targets += $(dtb-y)
>
> -# Rule to build device tree blobs with make command
> -$(obj)/%.dtb: $(src)/dts/%.dts FORCE
> - $(call if_changed_dep,dtc)
> -
> $(obj)/dtbs: $(addprefix $(obj)/, $(dtb-y))
>
> install:
> diff --git a/arch/nios2/boot/dts/Makefile
> b/arch/nios2/boot/dts/Makefile
> new file mode 100644
> index 000000000000..f66554cd5c45
> --- /dev/null
> +++ b/arch/nios2/boot/dts/Makefile
> @@ -0,0 +1 @@
> +# SPDX-License-Identifier: GPL-2.0
> --
> 2.17.1
>
Hi Rob
I have synced your all-dtbs branch from here: https://git.kernel.org/pu
b/scm/linux/kernel/git/robh/linux.git/log/?h=all-dtbs
It shows error when compile kernel image and also when "make
dtbs_install".
make dtbs_install
make[1]: *** No rule to make target
'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb', needed by
'arch/nios2/boot/dts/arch/nios2/boot/dts/10m50_devboard.dtb.S'. Stop.
Makefile:1229: recipe for target 'dtbs' failed
make: *** [dtbs] Error 2
Regards
Ley Foon
next prev parent reply other threads:[~2018-09-07 2:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 23:53 [PATCH v2 0/9] Devicetree build consolidation Rob Herring
2018-09-05 23:53 ` [PATCH v2 1/9] powerpc: build .dtb files in dts directory Rob Herring
2018-09-05 23:53 ` [PATCH v2 2/9] nios2: " Rob Herring
2018-09-07 2:21 ` Ley Foon Tan [this message]
2018-09-07 18:09 ` Rob Herring
2018-09-12 3:18 ` Ley Foon Tan
2018-09-05 23:53 ` [PATCH v2 3/9] nios2: use common rules to build built-in dtb Rob Herring
2018-09-05 23:53 ` [PATCH v2 4/9] nios2: fix building all dtbs Rob Herring
2018-09-05 23:53 ` [PATCH v2 5/9] c6x: use common built-in dtb support Rob Herring
2018-09-05 23:53 ` [PATCH v2 6/9] kbuild: consolidate Devicetree dtb build rules Rob Herring
2018-09-06 10:05 ` Will Deacon
2018-09-06 17:11 ` Paul Burton
2018-09-07 2:08 ` Ley Foon Tan
2018-09-07 10:32 ` Masahiro Yamada
2018-09-07 12:17 ` Rob Herring
2018-09-07 16:47 ` Masahiro Yamada
2018-09-09 23:27 ` Masahiro Yamada
2018-09-10 14:35 ` Rob Herring
2018-09-05 23:53 ` [PATCH v2 7/9] powerpc: enable building all dtbs Rob Herring
2018-09-05 23:53 ` [PATCH v2 8/9] c6x: " Rob Herring
2018-09-05 23:53 ` [PATCH v2 9/9] microblaze: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536286895.6128.4.camel@intel.com \
--to=ley.foon.tan@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nios2-dev@lists.rocketboards.org \
--cc=robh@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).