From: Phil Elwell <phil@raspberrypi.org>
To: Rob Herring <robh+dt@kernel.org>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Phil Elwell <phil@raspberrypi.org>,
devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
Russell King <linux@armlinux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com
Subject: [PATCH 0/2] Improve VCHIQ cache line size handling
Date: Wed, 12 Sep 2018 17:42:32 +0100 [thread overview]
Message-ID: <1536770554-107314-1-git-send-email-phil@raspberrypi.org> (raw)
Both sides of the VCHIQ communications mechanism need to agree on the cache
line size. Using an incorrect value can lead to data corruption, but having the
two sides using different values is usually worse.
In the absence of an obvious convenient run-time method to determine the
correct value in the ARCH=arm world, the downstream Raspberry Pi trees used a
Device Tree property, written by the firmware, to configure the kernel driver.
This method was vetoed during the upstreaming process, so a fixed value of 32
was used instead, and some corruptions ensued. This is take 2 at arriving at
the correct value.
Part one of the fix is deriving the correct value from the ARM's cpuid register.
Part two is a (seemingly cosmetic) correction of the Device Tree reg declaration
used by the driver, but it doubles as an indication to the Raspberry Pi firmware
that the kernel driver is running a recent kernel driver that chooses the
correct value. As such I would like very much for the DT patch not to be merged
before the driver patch - just tell me what hoops I need to jump through.
Phil Elwell (2):
staging/vc04_services: Derive g_cache_line_size
ARM: dts: bcm283x: Correct mailbox register sizes
arch/arm/boot/dts/bcm2835-rpi.dtsi | 2 +-
.../interface/vchiq_arm/vchiq_2835_arm.c | 24 +++++++++++++++++-----
2 files changed, 20 insertions(+), 6 deletions(-)
--
2.7.4
next reply other threads:[~2018-09-12 16:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-12 16:42 Phil Elwell [this message]
2018-09-12 16:42 ` [PATCH 1/2] staging/vc04_services: Derive g_cache_line_size Phil Elwell
2018-09-14 10:11 ` Stefan Wahren
2018-09-14 10:26 ` Phil Elwell
2018-09-14 11:03 ` Stefan Wahren
2018-09-14 11:09 ` Phil Elwell
[not found] ` <2aaa0f5f-b54d-396c-737e-73591b3083c8-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2018-09-14 11:25 ` Stefan Wahren
[not found] ` <107b707e-1f8c-1305-2582-0a131011758d-eS4NqCHxEME@public.gmane.org>
2018-09-14 10:41 ` Russell King - ARM Linux
2018-09-12 16:42 ` [PATCH 2/2] ARM: dts: bcm283x: Correct mailbox register sizes Phil Elwell
2018-09-16 15:25 ` [PATCH 0/2] Improve VCHIQ cache line size handling Stefan Wahren
-- strict thread matches above, loose matches on Subject: below --
2018-09-12 15:06 Phil Elwell
[not found] ` <1536764809-132672-1-git-send-email-phil-FnsA7b+Nu9XbIbC87yuRow@public.gmane.org>
2018-09-12 16:14 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1536770554-107314-1-git-send-email-phil@raspberrypi.org \
--to=phil@raspberrypi.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).