devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arkadiusz Lis <areklis909@gmail.com>
To: devicetree@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	linus.walleij@linaro.org, chrisadr@gentoo.org,
	dan.carpenter@oracle.com
Subject: emxx_udc device tree bindings
Date: Thu, 20 Sep 2018 20:35:52 +0200	[thread overview]
Message-ID: <1537468552-2533-1-git-send-email-areklis909@gmail.com> (raw)

Hi all,
I would like to help getting emxx_udc driver out of staging.
One of the things to do is to adjust it to using device tree.
The bindings are not defined yet. I have a blurred idea what properties are needed
however I've never done it and your support and comments will be really appreciated.

So, the drivers usually need the 'compatible' property with the manufacturer and device name,
so it is probably needed here as well.

According to Documentation/driver-api/gpio/board.rst,
to use gpio consumer interface (also on TODO list), '<function>-gpios'
property will be required. '<function>' is the name that is referenced in the driver
to obtain the gpio via gpiod_get(). Linus Walleij proposed 'vbus-gpios'.

IRQs are also used in this driver: USB_UDC_IRQ_1 and INT_VBUS,
it seems that 'interrupts' property will also be required.

Also memory region is mapped in the probe function.
	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
	mmio_base = devm_ioremap_resource(&pdev->dev, r);

Maybe 'reg' property can be used to describe physical base address and size of register map?
What are your suggestions?

Thanks for help,
Arek

             reply	other threads:[~2018-09-20 18:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 18:35 Arkadiusz Lis [this message]
2018-09-20 18:57 ` emxx_udc device tree bindings Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1537468552-2533-1-git-send-email-areklis909@gmail.com \
    --to=areklis909@gmail.com \
    --cc=chrisadr@gentoo.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).