From: Trent Piepho <tpiepho@impinj.com>
To: "dianders@chromium.org" <dianders@chromium.org>,
"swboyd@chromium.org" <swboyd@chromium.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"boris.brezillon@bootlin.com" <boris.brezillon@bootlin.com>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"ryandcase@chromium.org" <ryandcase@chromium.org>,
"girishm@codeaurora.org" <girishm@codeaurora.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation
Date: Mon, 24 Sep 2018 18:23:44 +0000 [thread overview]
Message-ID: <1537813423.7736.46.camel@impinj.com> (raw)
In-Reply-To: <CAD=FV=WbiAj4eZqo+BnjesF_3XfbeD1h-s1aEGVETaRTa545iQ@mail.gmail.com>
On Mon, 2018-09-24 at 10:13 -0700, Doug Anderson wrote:
> IIUC previous suggestions about just naming it based on the first SoC
> was due to the difficulty of coming up with a good generic name to
> give something. For instance you definitely wouldn't want to name it
> "qcom-qspi-sdm8xx" because you have no idea what future SoCs will be
> numbered.
And the hypothetical sdm899 might use a non-compatible device that uses
a different driver, and that really makes "qcom-qspi-sdm8xx" look dumb.
>
> In the case here calling it "qcom,qspi-v1" is better than that and if
> Rob gives the thumbs up then I won't object to it. In general though
> looking at other device tree bindings this doesn't seem like a thing
> commonly done. Perhaps if we decide it's useful here we should start
> suggesting it everywhere...
It would help if the programming model or IP core name or whatever this
is using was mentioned in the public reference manual for the SoC.
Then is a lot more clear that a number of different SoCs all have the
same quad spi controller inside them.
Usually it's not like that. The RMs just say, "it's got a SPI master
with these registers." What SoCs use the same IP module, which
different? When did they make a new version? The silicon vendors
don't tell you this. So any name we make up for the IP module likely
doesn't match reality.
next prev parent reply other threads:[~2018-09-24 18:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 22:40 [PATCH v2 1/2] dt-bindings: spi: Qualcomm Quad SPI(QSPI) documentation Ryan Case
2018-09-21 17:30 ` Stephen Boyd
2018-09-21 17:39 ` Mark Brown
2018-09-21 18:33 ` Trent Piepho
2018-09-21 17:40 ` Doug Anderson
2018-09-21 18:40 ` Stephen Boyd
2018-09-21 18:48 ` Doug Anderson
2018-09-21 18:51 ` Mark Brown
2018-09-23 3:45 ` Stephen Boyd
2018-09-24 17:13 ` Doug Anderson
2018-09-24 18:23 ` Trent Piepho [this message]
2018-09-25 16:02 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1537813423.7736.46.camel@impinj.com \
--to=tpiepho@impinj.com \
--cc=boris.brezillon@bootlin.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=girishm@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ryandcase@chromium.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).