devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damian Kos <dkos@cadence.com>
To: "David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Archit Taneja" <architt@codeaurora.org>,
	"Andrzej Hajda" <a.hajda@samsung.com>,
	"Laurent Pinchart" <Laurent.pinchart@ideasonboard.com>,
	"Gustavo Padovan" <gustavo@padovan.org>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Sean Paul" <sean@poorly.run>, "Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Quentin Schulz" <quentin.schulz@free-electrons.com>,
	"Damian Kos" <dkos@cadence.com>,
	"Piotr Sroka" <piotrs@cadence.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Cc: rafalc@cadence.com, quentin.schulz@bootlin.com, jbergsagel@ti.com
Subject: [PATCH v6 6/6] drm/bridge: add PHY initialization in mhdp8546 driver.
Date: Mon, 8 Oct 2018 22:42:12 +0100	[thread overview]
Message-ID: <1539034953-11274-7-git-send-email-dkos@cadence.com> (raw)
In-Reply-To: <1539034953-11274-1-git-send-email-dkos@cadence.com>

This patch modifies the mhdp8546 driver to initialize sd0801 "Torrent" PHY.

And removes the dbg_regs field from cdns_mhdp_device structure.

Signed-off-by: Damian Kos <dkos@cadence.com>
---
 drivers/gpu/drm/bridge/cdns-mhdp.c    | 9 +++++++++
 include/drm/bridge/cdns-mhdp-common.h | 1 -
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/cdns-mhdp.c b/drivers/gpu/drm/bridge/cdns-mhdp.c
index 48ac5cf1e031..caaf3c17d74f 100644
--- a/drivers/gpu/drm/bridge/cdns-mhdp.c
+++ b/drivers/gpu/drm/bridge/cdns-mhdp.c
@@ -17,6 +17,7 @@
 #include <linux/of.h>
 #include <linux/platform_device.h>
 #include <linux/slab.h>
+#include <linux/phy/phy.h>
 
 #include <drm/drm_atomic_helper.h>
 #include <drm/drm_bridge.h>
@@ -1220,6 +1221,12 @@ static int mhdp_probe(struct platform_device *pdev)
 	if (IS_ERR(mhdp->regs))
 		return PTR_ERR(mhdp->regs);
 
+	mhdp->phy = devm_phy_get(&pdev->dev, "dpphy");
+	if (IS_ERR(mhdp->phy)) {
+		dev_err(&pdev->dev, "no PHY configured\n");
+		return PTR_ERR(mhdp->phy);
+	}
+
 	platform_set_drvdata(pdev, mhdp);
 
 	ret = load_firmware(mhdp, FW_NAME, CDNS_MHDP_IMEM);
@@ -1291,6 +1298,8 @@ static int mhdp_probe(struct platform_device *pdev)
 			   mhdp->dev, HDMI_CODEC_DRV_NAME, PLATFORM_DEVID_AUTO,
 			   &codec_data, sizeof(codec_data));
 
+	phy_init(mhdp->phy);
+
 	/* Enable VIF clock for stream 0 */
 	cdns_mhdp_reg_read(mhdp, CDNS_DPTX_CAR, &resp);
 	cdns_mhdp_reg_write(mhdp, CDNS_DPTX_CAR,
diff --git a/include/drm/bridge/cdns-mhdp-common.h b/include/drm/bridge/cdns-mhdp-common.h
index d4711091ff2b..1e8a44138ce2 100644
--- a/include/drm/bridge/cdns-mhdp-common.h
+++ b/include/drm/bridge/cdns-mhdp-common.h
@@ -553,7 +553,6 @@ struct cdns_mhdp_device {
 	struct cdns_mhdp_sink	sink;
 	struct cdns_mhdp_bridge	bridge;
 	struct phy		*phy;
-	void __iomem		*dbg_regs;
 
 	struct video_info	video_info;
 	struct drm_display_mode	mode;
-- 
2.17.1

  parent reply	other threads:[~2018-10-08 21:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-08 21:42 [PATCH v6 0/6] drm: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-10-08 21:42 ` [PATCH v6 1/6] drm/rockchip: prepare common code for cdns and rk dpi/dp driver Damian Kos
2018-10-08 21:42 ` [PATCH v6 3/6] dt-bindings: drm/bridge: Document Cadence MHDP bridge bindings Damian Kos
2018-10-08 21:42 ` [PATCH v6 4/6] drm: bridge: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-11-05 13:10   ` Andrzej Hajda
2018-10-08 21:42 ` [PATCH v6 5/6] drm/bridge: add support for MST in mhdp8546 driver Damian Kos
2018-11-07 11:40   ` Andrzej Hajda
     [not found]     ` <4745c0e4-0147-59fd-1dda-c5644dadd10a-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-11-08 14:53       ` Damian Kos
2018-10-08 21:42 ` Damian Kos [this message]
2018-11-07 11:49   ` [PATCH v6 6/6] drm/bridge: add PHY initialization " Andrzej Hajda
     [not found] ` <1539034953-11274-1-git-send-email-dkos-vna1KIf7WgpBDgjK7y7TUQ@public.gmane.org>
2018-10-08 21:42   ` [PATCH v6 2/6] drm/dp: fix link probing for devices supporting DP 1.4+ Damian Kos
2018-11-05  9:44   ` [PATCH v6 0/6] drm: add support for Cadence MHDP DPI/DP bridge Damian Kos
2018-11-05 10:30     ` Laurent Pinchart
2018-11-05 10:33       ` Damian Kos
2018-11-05 11:09         ` Andrzej Hajda
     [not found]           ` <d6db03aa-6f61-f902-85f6-2245547186bc-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2018-11-05 11:34             ` Damian Kos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1539034953-11274-7-git-send-email-dkos@cadence.com \
    --to=dkos@cadence.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=architt@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=jbergsagel@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mark.rutland@arm.com \
    --cc=piotrs@cadence.com \
    --cc=quentin.schulz@bootlin.com \
    --cc=quentin.schulz@free-electrons.com \
    --cc=rafalc@cadence.com \
    --cc=robh+dt@kernel.org \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).