From: Randy Dunlap <rdunlap@infradead.org>
To: Maciej Purski <m.purski@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Thierry Reding <thierry.reding@gmail.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Archit Taneja <architt@codeaurora.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Inki Dae <inki.dae@samsung.com>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 08/12] drm/bridge: tc358764: Add DSI to LVDS bridge driver
Date: Mon, 28 May 2018 09:24:55 -0700 [thread overview]
Message-ID: <153d1f8c-a0b4-b189-34b5-42a81d15f66b@infradead.org> (raw)
In-Reply-To: <1527500833-16005-9-git-send-email-m.purski@samsung.com>
On 05/28/2018 02:47 AM, Maciej Purski wrote:
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index fa2c799..58e19af 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -110,6 +110,13 @@ config DRM_THINE_THC63LVD1024
> ---help---
> Thine THC63LVD1024 LVDS/parallel converter driver.
>
> +config DRM_TOSHIBA_TC358764
> + tristate "TC358764 DSI/LVDS bridge"
> + depends on DRM && DRM_PANEL
> + depends on OF
> + select DRM_MIPI_DSI
> + select VIDEOMODE_HELPERS
> +
Kconfig symbols with "prompt strings" should also have help text.
I expected checkpatch to catch that, but I tested it and there was no warning
from checkpatch about help text. OTOH, there was a warning that there are
2 lines in this patch that end with whitespace, so that should be fixed.
Did you use checkpatch (scripts/checkpatch.pl)?
> config DRM_TOSHIBA_TC358767
> tristate "Toshiba TC358767 eDP bridge"
> depends on OF
thanks,
--
~Randy
next prev parent reply other threads:[~2018-05-28 16:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180528094721eucas1p22b90fd838ce00f029fec7f5241cc06b5@eucas1p2.samsung.com>
2018-05-28 9:47 ` [PATCH 00/12] Add TOSHIBA TC358764 DSI/LVDS bridge driver Maciej Purski
[not found] ` <CGME20180528094722eucas1p28c087e8b9174e0591bf3cb6526885777@eucas1p2.samsung.com>
2018-05-28 9:47 ` [PATCH 01/12] drm/exynos: rename "bridge_node" to "mic_bridge_node" Maciej Purski
[not found] ` <CGME20180528094723eucas1p1776829e0b57d2ec6c4e28be872cf88fc@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 02/12] drm/exynos: move pm_runtime_get_sync() to exynos_dsi_init() Maciej Purski
[not found] ` <CGME20180528094724eucas1p17a37e06002ed96d97aaca87231f13bbb@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 03/12] drm/exynos: move connector creation to attach callback Maciej Purski
[not found] ` <CGME20180528094725eucas1p2e80e551edb29dd4ab437246f4896d108@eucas1p2.samsung.com>
2018-05-28 9:47 ` [PATCH 04/12] drm/exynos: add non-panel path to exynos_dsi_enable() Maciej Purski
[not found] ` <CGME20180528094726eucas1p14c9d821881865955a4d8b1735a650c8f@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 05/12] panel/hv070wsa-100: add DT bindings Maciej Purski
[not found] ` <CGME20180528094727eucas1p272478562b72a95dac2fc1b03be57c514@eucas1p2.samsung.com>
2018-05-28 9:47 ` [PATCH 06/12] drm/panel: add support for BOE HV070WSA-100 panel to simple-panel Maciej Purski
[not found] ` <CGME20180528094727eucas1p153b8116120cd2195b15b74776f171cbe@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 07/12] dt-bindings: tc358754: add DT bindings Maciej Purski
2018-05-28 10:18 ` Laurent Pinchart
2018-05-30 9:59 ` Andrzej Hajda
2018-05-30 12:35 ` Laurent Pinchart
2018-05-30 13:07 ` Andrzej Hajda
2018-05-30 13:20 ` Laurent Pinchart
[not found] ` <CGME20180528094728eucas1p128e8a44fa6c3bcb29d056a8191c039af@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 08/12] drm/bridge: tc358764: Add DSI to LVDS bridge driver Maciej Purski
2018-05-28 16:24 ` Randy Dunlap [this message]
2018-05-30 7:45 ` kbuild test robot
2018-05-30 8:27 ` Andrzej Hajda
[not found] ` <CGME20180528094729eucas1p1cc26ea191a4ee1ba9daa06fae93037bf@eucas1p1.samsung.com>
2018-05-28 9:47 ` [PATCH 09/12] ARM: dts: exynos5250: add mipi-phy node Maciej Purski
2018-05-28 16:24 ` Krzysztof Kozlowski
[not found] ` <CGME20180528095444eucas1p222e4054b8fb8997258182e501f37a10b@eucas1p2.samsung.com>
2018-05-28 9:54 ` [PATCH 10/12] ARM: dts: exynos5250: add DSI node Maciej Purski
2018-05-28 16:36 ` Krzysztof Kozlowski
[not found] ` <CGME20180528095523eucas1p1039e1b62aaef415b66d6f62e86dbef93@eucas1p1.samsung.com>
2018-05-28 9:55 ` [PATCH 11/12] ARM: dts: exynos5250-arndale: add display regulators Maciej Purski
[not found] ` <CGME20180528095555eucas1p2fb61f362a3aa2d0082b8c4001b17f176@eucas1p2.samsung.com>
2018-05-28 9:55 ` [PATCH 12/12] ARM: dts: exynos5250-arndale: add dsi and panel nodes Maciej Purski
2018-05-28 16:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=153d1f8c-a0b4-b189-34b5-42a81d15f66b@infradead.org \
--to=rdunlap@infradead.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jy0922.shim@samsung.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.purski@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).