* [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts
@ 2018-11-02 19:42 Jeykumar Sankaran
2018-11-02 19:42 ` [PATCH] arm64: dts: sdm845: Add dsi pinctrl nodes Jeykumar Sankaran
2018-11-02 20:33 ` [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Doug Anderson
0 siblings, 2 replies; 3+ messages in thread
From: Jeykumar Sankaran @ 2018-11-02 19:42 UTC (permalink / raw)
To: dri-devel, freedreno, linux-arm-msm, devicetree
Cc: dianders, mka, hoegsberg, seanpaul
Add mdss, dsi, dsi_phy, dsi pinctrl and truly nt35597 panel nodes to
sdm845 MTP board dtsi.
Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 124 ++++++++++++++++++++++++++++++++
1 file changed, 124 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index 6d651f3..6e98ae8 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -8,6 +8,7 @@
/dts-v1/;
#include "sdm845.dtsi"
+#include <dt-bindings/gpio/gpio.h>
/ {
model = "Qualcomm Technologies, Inc. SDM845 MTP";
@@ -22,6 +23,113 @@
};
};
+&dsi0 {
+ status = "okay";
+ qcom,dual-dsi-mode;
+ qcom,master-dsi;
+ qcom,sync-dual-dsi;
+
+ vdda-supply = <&vdda_mipi_dsi0_1p2>;
+
+ panel@0 {
+ compatible = "truly,nt35597-2K-display";
+ reg = <0>;
+
+ vdda-supply = <&vreg_l14a_1p88>;
+ vdispp-supply = <&lab_regulator>;
+ vdispn-supply = <&ibb_regulator>;
+
+ pinctrl-names = "default", "suspend";
+ pinctrl-0 = <&dpu_dsi_active>;
+ pinctrl-1 = <&dpu_dsi_suspend>;
+
+ reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
+ mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
+
+ display-timings {
+ timing0: timing-0 {
+ /* originally
+ * 268316160 Mhz,
+ * but value below fits
+ * better w/ downstream
+ */
+ clock-frequency = <268316138>;
+ hactive = <1440>;
+ vactive = <2560>;
+ hfront-porch = <200>;
+ hback-porch = <64>;
+ hsync-len = <32>;
+ vfront-porch = <8>;
+ vback-porch = <7>;
+ vsync-len = <1>;
+ };
+ };
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+ port@0 {
+ reg = <0>;
+ panel0_in: endpoint {
+ remote-endpoint = <&dsi0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ panel1_in: endpoint {
+ remote-endpoint = <&dsi1_out>;
+ };
+ };
+ };
+ };
+
+ ports {
+ port@1 {
+ endpoint {
+ remote-endpoint = <&panel0_in>;
+ data-lanes = <0 1 2 3>;
+ };
+ };
+ };
+};
+
+&dsi0_phy {
+ status = "okay";
+ vdds-supply = <&vdda_mipi_dsi0_pll>;
+};
+
+&dsi1 {
+ status = "okay";
+
+ qcom,dual-dsi-mode;
+ qcom,sync-dual-dsi;
+
+ vdda-supply = <&vdda_mipi_dsi1_1p2>;
+
+ ports {
+ port@1 {
+ endpoint {
+ remote-endpoint = <&panel1_in>;
+ data-lanes = <0 1 2 3>;
+ };
+ };
+ };
+};
+
+&dsi1_phy {
+ status = "okay";
+ vdds-supply = <&vdda_mipi_dsi1_pll>;
+};
+
+&mdss {
+ status = "okay";
+};
+
+&mdss_mdp {
+ status = "okay";
+};
+
&i2c10 {
status = "okay";
clock-frequency = <400000>;
@@ -58,3 +166,19 @@
bias-pull-up;
};
};
+
+&dpu_dsi_active {
+ pinconf {
+ pins = "gpio6", "gpio52";
+ drive-strength = <8>;
+ bias-disable;
+ };
+};
+
+&dpu_dsi_suspend {
+ pinconf {
+ pins = "gpio6", "gpio52";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+};
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm64: dts: sdm845: Add dsi pinctrl nodes
2018-11-02 19:42 [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Jeykumar Sankaran
@ 2018-11-02 19:42 ` Jeykumar Sankaran
2018-11-02 20:33 ` [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Doug Anderson
1 sibling, 0 replies; 3+ messages in thread
From: Jeykumar Sankaran @ 2018-11-02 19:42 UTC (permalink / raw)
To: dri-devel, freedreno, linux-arm-msm, devicetree
Cc: dianders, mka, hoegsberg, seanpaul
Add dsi active/suspend pinctrl nodes to sdm845 SoC dts.
Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index dd612ac..e6a64f6 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -714,6 +714,20 @@
interrupt-controller;
#interrupt-cells = <2>;
+ dpu_dsi_active: dpu-dsi-active {
+ pinmux {
+ pins = "gpio6", "gpio52";
+ function = "gpio";
+ };
+ };
+
+ dpu_dsi_suspend: dpu-dsi-suspend {
+ pinmux {
+ pins = "gpio6", "gpio52";
+ function = "gpio";
+ };
+ };
+
qup_i2c0_default: qup-i2c0-default {
pinmux {
pins = "gpio0", "gpio1";
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts
2018-11-02 19:42 [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Jeykumar Sankaran
2018-11-02 19:42 ` [PATCH] arm64: dts: sdm845: Add dsi pinctrl nodes Jeykumar Sankaran
@ 2018-11-02 20:33 ` Doug Anderson
1 sibling, 0 replies; 3+ messages in thread
From: Doug Anderson @ 2018-11-02 20:33 UTC (permalink / raw)
To: Jeykumar Sankaran
Cc: devicetree, linux-arm-msm, dri-devel, Matthias Kaehlcke,
Sean Paul, Kristian Kristensen, freedreno
Hi,
On Fri, Nov 2, 2018 at 12:42 PM Jeykumar Sankaran <jsanka@codeaurora.org> wrote:
>
> Add mdss, dsi, dsi_phy, dsi pinctrl and truly nt35597 panel nodes to
> sdm845 MTP board dtsi.
>
> Signed-off-by: Jeykumar Sankaran <jsanka@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 124 ++++++++++++++++++++++++++++++++
> 1 file changed, 124 insertions(+)
A few nits below about trying to keep the sort ordering right in this
file. I'm not an expert on device tree properties for display, but
other than these nits things here look good to me.
NOTE also that I'd probably put all 3 of your recent patches in a
3-part series since they all depend on each other, don't they? AKA
I'd to see next time:
[PATCH v4 1/3] arm64: dts: qcom: sdm845: Add dpu to sdm845 dts file
[PATCH v4 2/3] arm64: dts: sdm845: Add dsi pinctrl nodes
[PATCH v4 3/3] arm64: dts: sdm845: Add display nodes to MTP dts
...you can call them all v4 just to make it easier to track...
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index 6d651f3..6e98ae8 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -8,6 +8,7 @@
> /dts-v1/;
>
> #include "sdm845.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
Generally includes should have < includes above " includes.
...also: please rebase atop Andy's tree. Then you'll have the line:
#include <dt-bindings/regulator/qcom,rpmh-regulator.h>
..."gpio" is alphabetically before "regulator" so your include should
be _above_ that one.
>
> / {
> model = "Qualcomm Technologies, Inc. SDM845 MTP";
> @@ -22,6 +23,113 @@
> };
> };
>
> +&dsi0 {
> + status = "okay";
> + qcom,dual-dsi-mode;
> + qcom,master-dsi;
> + qcom,sync-dual-dsi;
> +
> + vdda-supply = <&vdda_mipi_dsi0_1p2>;
> +
> + panel@0 {
> + compatible = "truly,nt35597-2K-display";
> + reg = <0>;
> +
> + vdda-supply = <&vreg_l14a_1p88>;
> + vdispp-supply = <&lab_regulator>;
> + vdispn-supply = <&ibb_regulator>;
> +
> + pinctrl-names = "default", "suspend";
> + pinctrl-0 = <&dpu_dsi_active>;
> + pinctrl-1 = <&dpu_dsi_suspend>;
> +
> + reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
> + mode-gpios = <&tlmm 52 GPIO_ACTIVE_HIGH>;
> +
> + display-timings {
> + timing0: timing-0 {
> + /* originally
> + * 268316160 Mhz,
> + * but value below fits
> + * better w/ downstream
> + */
> + clock-frequency = <268316138>;
> + hactive = <1440>;
> + vactive = <2560>;
> + hfront-porch = <200>;
> + hback-porch = <64>;
> + hsync-len = <32>;
> + vfront-porch = <8>;
> + vback-porch = <7>;
> + vsync-len = <1>;
> + };
> + };
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + port@0 {
> + reg = <0>;
> + panel0_in: endpoint {
> + remote-endpoint = <&dsi0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + panel1_in: endpoint {
> + remote-endpoint = <&dsi1_out>;
> + };
> + };
> + };
> + };
> +
> + ports {
> + port@1 {
> + endpoint {
> + remote-endpoint = <&panel0_in>;
> + data-lanes = <0 1 2 3>;
> + };
> + };
> + };
> +};
> +
> +&dsi0_phy {
> + status = "okay";
> + vdds-supply = <&vdda_mipi_dsi0_pll>;
> +};
> +
> +&dsi1 {
> + status = "okay";
> +
> + qcom,dual-dsi-mode;
> + qcom,sync-dual-dsi;
> +
> + vdda-supply = <&vdda_mipi_dsi1_1p2>;
> +
> + ports {
> + port@1 {
> + endpoint {
> + remote-endpoint = <&panel1_in>;
> + data-lanes = <0 1 2 3>;
> + };
> + };
> + };
> +};
> +
> +&dsi1_phy {
> + status = "okay";
> + vdds-supply = <&vdda_mipi_dsi1_pll>;
> +};
> +
> +&mdss {
> + status = "okay";
> +};
> +
> +&mdss_mdp {
> + status = "okay";
> +};
Please keep these nodes sorted alphabetically even if it means you
don't keep all the display nodes together. Thus "mdss" and "mdss_mdp"
should be below "i2c10" and above "qupv3_id_1".
> +
> &i2c10 {
> status = "okay";
> clock-frequency = <400000>;
> @@ -58,3 +166,19 @@
> bias-pull-up;
> };
> };
> +
> +&dpu_dsi_active {
> + pinconf {
> + pins = "gpio6", "gpio52";
> + drive-strength = <8>;
> + bias-disable;
> + };
> +};
> +
> +&dpu_dsi_suspend {
> + pinconf {
> + pins = "gpio6", "gpio52";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +};
These two things should sorted alphabetically in the "PINCTRL -
additions to nodes defined in sdm845.dtsi" section. So please place
them both above the "qup_i2c10_default" node.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-02 20:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-02 19:42 [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Jeykumar Sankaran
2018-11-02 19:42 ` [PATCH] arm64: dts: sdm845: Add dsi pinctrl nodes Jeykumar Sankaran
2018-11-02 20:33 ` [PATCH] arm64: dts: sdm845: Add display nodes to MTP dts Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).