devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org, patchwork-lst@pengutronix.de,
	Chris Healy <cphealy@gmail.com>,
	kernel@pengutronix.de, linux-input@vger.kernel.org
Subject: Re: [PATCH 1/4] Input: egalax_ts - clean up capability initialization
Date: Mon, 05 Nov 2018 18:19:15 +0100	[thread overview]
Message-ID: <1541438355.2508.7.camel@pengutronix.de> (raw)
In-Reply-To: <20180920142256.2788-1-l.stach@pengutronix.de>

Hi all,

we can drop this whole series. I realized that all I need is already
implemented in the EXC3000 driver.

Regards,
Lucas

Am Donnerstag, den 20.09.2018, 16:22 +0200 schrieb Lucas Stach:
> Just provide the proper flags to input_mt_init_slots(), which will
> so the right thing and set the proper capability bits.
> 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  drivers/input/touchscreen/egalax_ts.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
> index 80e69bb8283e..5e7a60089c3d 100644
> --- a/drivers/input/touchscreen/egalax_ts.c
> +++ b/drivers/input/touchscreen/egalax_ts.c
> @@ -199,17 +199,12 @@ static int egalax_ts_probe(struct i2c_client *client,
> >  	input_dev->name = "EETI eGalax Touch Screen";
> >  	input_dev->id.bustype = BUS_I2C;
>  
> > -	__set_bit(EV_ABS, input_dev->evbit);
> > -	__set_bit(EV_KEY, input_dev->evbit);
> > -	__set_bit(BTN_TOUCH, input_dev->keybit);
> -
> > -	input_set_abs_params(input_dev, ABS_X, 0, EGALAX_MAX_X, 0, 0);
> > -	input_set_abs_params(input_dev, ABS_Y, 0, EGALAX_MAX_Y, 0, 0);
> >  	input_set_abs_params(input_dev,
> >  			     ABS_MT_POSITION_X, 0, EGALAX_MAX_X, 0, 0);
> >  	input_set_abs_params(input_dev,
> >  			     ABS_MT_POSITION_Y, 0, EGALAX_MAX_Y, 0, 0);
> > -	input_mt_init_slots(input_dev, MAX_SUPPORT_POINTS, 0);
> > +	input_mt_init_slots(input_dev, MAX_SUPPORT_POINTS,
> > +			    INPUT_MT_DIRECT | INPUT_MT_DROP_UNUSED);
>  
> >  	error = devm_request_threaded_irq(&client->dev, client->irq, NULL,
> >  					  egalax_ts_interrupt,

      parent reply	other threads:[~2018-11-05 17:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-20 14:22 [PATCH 1/4] Input: egalax_ts - clean up capability initialization Lucas Stach
2018-09-20 14:22 ` [PATCH 2/4] Input: egalax_ts - use touchscreen helpers Lucas Stach
2018-09-20 14:22 ` [PATCH 3/4] Input: egalax_ts - add property for protocol version Lucas Stach
2018-09-24 22:28   ` Rob Herring
2018-09-20 14:22 ` [PATCH 4/4] Input: egalax_ts - add support for new " Lucas Stach
2018-11-05 17:19 ` Lucas Stach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1541438355.2508.7.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-input@vger.kernel.org \
    --cc=patchwork-lst@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).