From: Philipp Zabel <p.zabel@pengutronix.de>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: robh+dt@kernel.org, mark.rutland@arm.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: socfpga: dts: document "altr,stratix10-rst-mgr" binding
Date: Thu, 15 Nov 2018 10:32:59 +0100 [thread overview]
Message-ID: <1542274379.4915.3.camel@pengutronix.de> (raw)
In-Reply-To: <20181105200549.17159-3-dinguyen@kernel.org>
Hi Dinh,
On Mon, 2018-11-05 at 14:05 -0600, Dinh Nguyen wrote:
> "altr,stratix10-rst-mgr" is used for the Stratix10 reset manager.
>
> Signed-off-by: Dinh Nguyen <dinguyen@kernel.org>
> ---
> Documentation/devicetree/bindings/reset/socfpga-reset.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/socfpga-reset.txt b/Documentation/devicetree/bindings/reset/socfpga-reset.txt
> index 98c9f560e5c5..38fe34fd8b8a 100644
> --- a/Documentation/devicetree/bindings/reset/socfpga-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/socfpga-reset.txt
> @@ -1,7 +1,8 @@
> Altera SOCFPGA Reset Manager
>
> Required properties:
> -- compatible : "altr,rst-mgr"
> +- compatible : "altr,rst-mgr" for (Cyclone5/Arria5/Arria10)
> + "altr,stratix10-rst-mgr","altr,rst-mgr" for Stratix10 ARM64 SoC
git grep '\(altr\|intel\),stratix10'
currently only shows "intel,stratix10-clkmgr". Should this be
"intel,stratix10-rst-mgr"? I think keeping "altr," is fine for
consistency, just wanted to point it out.
> - reg : Should contain 1 register ranges(address and length)
> - altr,modrst-offset : Should contain the offset of the first modrst register.
> - #reset-cells: 1
regards
Philipp
next prev parent reply other threads:[~2018-11-15 9:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 20:05 [PATCH 1/3] arm64: dts: stratix10: use "altr,stratix10-rst-mgr" binding Dinh Nguyen
2018-11-05 20:05 ` [PATCHv3 2/3] reset: socfpga: add an early reset driver for SoCFPGA Dinh Nguyen
2018-11-13 14:02 ` Philipp Zabel
2018-11-05 20:05 ` [PATCH 3/3] ARM: socfpga: dts: document "altr,stratix10-rst-mgr" binding Dinh Nguyen
2018-11-15 9:32 ` Philipp Zabel [this message]
2018-11-15 14:34 ` Dinh Nguyen
2018-11-15 9:33 ` [PATCH 1/3] arm64: dts: stratix10: use " Philipp Zabel
2018-11-15 14:35 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542274379.4915.3.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).