* [PATCH] ARM: dts: imx50: Fix memory node duplicaton
@ 2018-11-23 13:25 Fabio Estevam
2018-11-28 8:30 ` Shawn Guo
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2018-11-23 13:25 UTC (permalink / raw)
To: shawnguo; +Cc: devicetree, robh+dt, Fabio Estevam, linux-arm-kernel
imx50-evk has duplicate memory nodes:
- One coming from the board dts file: memory@
- One coming from the imx50.dtsi file.
Fix the duplication by removing the memory node from the dtsi file
and by adding 'device_type = "memory";' in the board dts.
Reported-by: Rob Herring <robh@kernel.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
arch/arm/boot/dts/imx50-evk.dts | 1 +
arch/arm/boot/dts/imx50.dtsi | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx50-evk.dts b/arch/arm/boot/dts/imx50-evk.dts
index 682a997..a25da41 100644
--- a/arch/arm/boot/dts/imx50-evk.dts
+++ b/arch/arm/boot/dts/imx50-evk.dts
@@ -12,6 +12,7 @@
compatible = "fsl,imx50-evk", "fsl,imx50";
memory@70000000 {
+ device_type = "memory";
reg = <0x70000000 0x80000000>;
};
};
diff --git a/arch/arm/boot/dts/imx50.dtsi b/arch/arm/boot/dts/imx50.dtsi
index 95b7fba..8be4ff4 100644
--- a/arch/arm/boot/dts/imx50.dtsi
+++ b/arch/arm/boot/dts/imx50.dtsi
@@ -22,10 +22,8 @@
* The decompressor and also some bootloaders rely on a
* pre-existing /chosen node to be available to insert the
* command line and merge other ATAGS info.
- * Also for U-Boot there must be a pre-existing /memory node.
*/
chosen {};
- memory { device_type = "memory"; };
aliases {
ethernet0 = &fec;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: dts: imx50: Fix memory node duplicaton
2018-11-23 13:25 [PATCH] ARM: dts: imx50: Fix memory node duplicaton Fabio Estevam
@ 2018-11-28 8:30 ` Shawn Guo
0 siblings, 0 replies; 2+ messages in thread
From: Shawn Guo @ 2018-11-28 8:30 UTC (permalink / raw)
To: Fabio Estevam; +Cc: devicetree, robh+dt, linux-arm-kernel
On Fri, Nov 23, 2018 at 11:25:19AM -0200, Fabio Estevam wrote:
> imx50-evk has duplicate memory nodes:
>
> - One coming from the board dts file: memory@
>
> - One coming from the imx50.dtsi file.
>
> Fix the duplication by removing the memory node from the dtsi file
> and by adding 'device_type = "memory";' in the board dts.
>
> Reported-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-11-28 8:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-23 13:25 [PATCH] ARM: dts: imx50: Fix memory node duplicaton Fabio Estevam
2018-11-28 8:30 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).