From: frowand.list@gmail.com
To: robh+dt@kernel.org, Michael Bringmann <mwb@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Thomas Falcon <tlfalcon@linux.vnet.ibm.com>,
Juliet Kim <minkim@us.ibm.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/2] of: phandle_cache, fix refcounts, remove stale entry
Date: Thu, 13 Dec 2018 22:42:49 -0800 [thread overview]
Message-ID: <1544769771-5468-1-git-send-email-frowand.list@gmail.com> (raw)
From: Frank Rowand <frank.rowand@sony.com>
Non-overlay dynamic devicetree node removal may leave the node in
the phandle cache. Subsequent calls to of_find_node_by_phandle()
will incorrectly find the stale entry. This bug exposed the foloowing
phandle cache refcount bug.
The refcount of phandle_cache entries is not incremented while in
the cache, allowing use after free error after kfree() of the
cached entry.
Frank Rowand (2):
of: of_node_get()/of_node_put() nodes held in phandle cache
of: __of_detach_node() - remove node from phandle cache
drivers/of/base.c | 99 ++++++++++++++++++++++++++++++++++++-------------
drivers/of/dynamic.c | 3 ++
drivers/of/of_private.h | 4 ++
3 files changed, 81 insertions(+), 25 deletions(-)
--
Frank Rowand <frank.rowand@sony.com>
next reply other threads:[~2018-12-14 6:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 6:42 frowand.list [this message]
2018-12-14 6:42 ` [PATCH 1/2] of: of_node_get()/of_node_put() nodes held in phandle cache frowand.list
2018-12-14 17:15 ` Rob Herring
2018-12-14 22:47 ` Frank Rowand
2018-12-14 23:04 ` Frank Rowand
2018-12-14 6:42 ` [PATCH 2/2] of: __of_detach_node() - remove node from " frowand.list
2018-12-14 17:20 ` Rob Herring
2018-12-14 21:56 ` Michael Bringmann
2018-12-14 22:38 ` Frank Rowand
2018-12-14 6:46 ` [PATCH 0/2] of: phandle_cache, fix refcounts, remove stale entry Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1544769771-5468-1-git-send-email-frowand.list@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minkim@us.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=mwb@linux.vnet.ibm.com \
--cc=robh+dt@kernel.org \
--cc=tlfalcon@linux.vnet.ibm.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).