From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
arnd@arndb.de, olof@lixom.net, soc@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
l.stach@pengutronix.de, alexander.stein@ew.tq-group.com,
marcel.ziswiler@toradex.com, linux@rempel-privat.de,
matthias.schiffer@ew.tq-group.com,
cniedermaier@dh-electronics.com, sebastian.reichel@collabora.com,
leoyang.li@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, nicolecrivain@gmail.com
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2
Date: Tue, 24 May 2022 11:20:05 +0200 [thread overview]
Message-ID: <1546297c-6627-574e-4b30-4b8dbf95a851@linaro.org> (raw)
In-Reply-To: <20220523210542.0735dd5f@aktux>
On 23/05/2022 21:05, Andreas Kemnade wrote:
> On Mon, 23 May 2022 12:03:09 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> [...]
>>> +
>>> + gpio_keys: gpio-keys {
>>> + compatible = "gpio-keys";
>>> + pinctrl-names = "default";
>>> + pinctrl-0 = <&pinctrl_gpio_keys>;
>>> +
>>> + cover {
>>
>> Generic node names. You could add suffix if needed, so either key or
>> key-cover.
>>
> hmm, the example in
> Documentation/devicetree/bindings/input/gpio-keys.yaml
>
> shows names like I did. I usually expect to trust binding documentation
> to have something acceptable.
It's only an example and no one usually cares about correcting it, once
it got merged.
Best regards,
Krzysztof
prev parent reply other threads:[~2022-05-24 9:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-22 21:44 [PATCH 0/2] ARM: dts: add Kobo Aura 2 Andreas Kemnade
2022-05-22 21:44 ` [PATCH 1/2] dt-bindings: arm: fsl: add compatible string for " Andreas Kemnade
2022-05-23 10:03 ` Krzysztof Kozlowski
2022-05-22 21:44 ` [PATCH 2/2] ARM: dts: imx: Add devicetree " Andreas Kemnade
2022-05-23 10:03 ` Krzysztof Kozlowski
2022-05-23 19:05 ` Andreas Kemnade
2022-05-24 9:20 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546297c-6627-574e-4b30-4b8dbf95a851@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=cniedermaier@dh-electronics.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.stach@pengutronix.de \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=marcel.ziswiler@toradex.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=nicolecrivain@gmail.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.reichel@collabora.com \
--cc=shawnguo@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).