From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58962C433FE for ; Tue, 24 May 2022 09:20:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235381AbiEXJUM (ORCPT ); Tue, 24 May 2022 05:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235376AbiEXJUM (ORCPT ); Tue, 24 May 2022 05:20:12 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF5BB6D844 for ; Tue, 24 May 2022 02:20:10 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id m6so20170949ljb.2 for ; Tue, 24 May 2022 02:20:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=gmC1VcL8yscCI1x9Ja1ww8OKwee0RnTTrztFQlz77Bc=; b=o4XvKcc2tDfYpFiGcIER/TkQLhWEG2NxgGdVOxts/6PecWelAhA4ZFGPNSGH+clTjA eVVRKwj3bZsR3XujzfOZDuLsxqer9PqF+7/9THqEj86Q9dv3UqDBTF3zk7LFt0CpfU+T OlW5k++WMSn8Oi99afEDvxYriEt2tENWgR0rLuJyG6p0iiCnFx0Tkwtvx83RVbIAvUUJ +mDvthDpqAq2/Qe2ppbqVKkgNT1ERAaYJPWiKFCDVo/xiYxvwhumP4pJN7OGGSCqxvxg nKaShYV3SHGTX/08yc3Y9nqIG7JasCJqQ3h9CBimib4ZQ0zxLceq/LfqFAzzInr4186O 529A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=gmC1VcL8yscCI1x9Ja1ww8OKwee0RnTTrztFQlz77Bc=; b=6eizHtPwhsktlMIaQrqM4YhWwB/KMEJtWMxBxSBNEdKqk7v6z8W/2EPBBcw1iW+vo0 PLdDhp74A/GO7sgoLWRG2KhDifcdXHSpt6w5/7jHeDxoF3w9UpBdwViuLjqAXcyOSU76 UTftOkffdNXAL76UKH13mHQP8BmOx86cgYo1vNx+uM4BfQBWyxEQs2cik2dJJWWpOASj BlgKnIcl78vznjh5BHu7cay/QQpGw2P+7dSGgEIyGO7OwZrzL3shHZRDbo+b3s8CnuX2 y9htVUe5TBEjL/q5r1pUN91k6PcGRIXFHuj9Et/rfupcfyTaVWlWxRD9W3LEs/Llr+LF Dx/A== X-Gm-Message-State: AOAM5325NiDwvu8iywH1YIOk3M6d5JB8nla39XHvCMLrBvwTbCFzwBWS zaA1HVCNMP0d7Ca9MrDhb2W8kA== X-Google-Smtp-Source: ABdhPJwsP8QIHu0YwsuqV3LIiclR/+y+mpo9Hp0+N+CZrmjMY1lkIzPrYWaAmSBYM5tGyraII/mBLw== X-Received: by 2002:a2e:a41a:0:b0:253:c96a:4e15 with SMTP id p26-20020a2ea41a000000b00253c96a4e15mr14939717ljn.195.1653384009037; Tue, 24 May 2022 02:20:09 -0700 (PDT) Received: from [172.20.68.48] ([91.221.145.6]) by smtp.gmail.com with ESMTPSA id b8-20020ac24108000000b0047408564c31sm2429755lfi.286.2022.05.24.02.20.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 May 2022 02:20:08 -0700 (PDT) Message-ID: <1546297c-6627-574e-4b30-4b8dbf95a851@linaro.org> Date: Tue, 24 May 2022 11:20:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2 Content-Language: en-US To: Andreas Kemnade Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, arnd@arndb.de, olof@lixom.net, soc@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, l.stach@pengutronix.de, alexander.stein@ew.tq-group.com, marcel.ziswiler@toradex.com, linux@rempel-privat.de, matthias.schiffer@ew.tq-group.com, cniedermaier@dh-electronics.com, sebastian.reichel@collabora.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nicolecrivain@gmail.com References: <20220522214415.254959-1-andreas@kemnade.info> <20220522214415.254959-3-andreas@kemnade.info> <402c7e38-7ad0-581f-146d-3db88e77d37c@linaro.org> <20220523210542.0735dd5f@aktux> From: Krzysztof Kozlowski In-Reply-To: <20220523210542.0735dd5f@aktux> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 23/05/2022 21:05, Andreas Kemnade wrote: > On Mon, 23 May 2022 12:03:09 +0200 > Krzysztof Kozlowski wrote: > > [...] >>> + >>> + gpio_keys: gpio-keys { >>> + compatible = "gpio-keys"; >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_gpio_keys>; >>> + >>> + cover { >> >> Generic node names. You could add suffix if needed, so either key or >> key-cover. >> > hmm, the example in > Documentation/devicetree/bindings/input/gpio-keys.yaml > > shows names like I did. I usually expect to trust binding documentation > to have something acceptable. It's only an example and no one usually cares about correcting it, once it got merged. Best regards, Krzysztof