* [PATCH 0/3] arm64: ti: k3-am654: USB support
@ 2019-01-11 10:00 Roger Quadros
2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Roger Quadros @ 2019-01-11 10:00 UTC (permalink / raw)
To: t-kristo
Cc: nm, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel,
Roger Quadros
Hi,
The AM654 SoC supports 2 DWC3 USB controller instances. The
AM654 base board supports the 2nd (USB1) instance in high-speed.
This series enables support for USB1 instance on the AM654-base-board.
To test, you need to first apply the below 2 series.
AM654 USB2 PHY support https://lkml.org/lkml/2018/12/5/908
AM654 DWC3 support https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1896101.html
cheers,
-roger
Jyri Sarha (1):
arm64: dts: ti: am654: Add Main System Control Module node
Roger Quadros (2):
arm64: dts: ti: k3-am6: add USB support
arm64: dts: ti: k3-am654-base-board: enable USB1
arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 88 ++++++++++++++++++++++++++
arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 20 ++++++
2 files changed, 108 insertions(+)
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node 2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros @ 2019-01-11 10:00 ` Roger Quadros 2019-01-15 14:33 ` Nishanth Menon 2019-01-11 10:01 ` [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support Roger Quadros ` (2 subsequent siblings) 3 siblings, 1 reply; 11+ messages in thread From: Roger Quadros @ 2019-01-11 10:00 UTC (permalink / raw) To: t-kristo Cc: nm, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel, Jyri Sarha, Roger Quadros From: Jyri Sarha <jsarha@ti.com> Main System control module support is added to the device tree to allow driver to access to their control module registers. Signed-off-by: Jyri Sarha <jsarha@ti.com> Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 272cf8f..8b55108 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -191,4 +191,12 @@ #address-cells = <1>; #size-cells = <0>; }; + + scm_conf: scm_conf@100000 { + compatible = "syscon", "simple-mfd"; + reg = <0 0x00100000 0 0x1c000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x00100000 0x1c000>; + }; }; -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node 2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros @ 2019-01-15 14:33 ` Nishanth Menon 2019-01-16 10:52 ` Roger Quadros 0 siblings, 1 reply; 11+ messages in thread From: Nishanth Menon @ 2019-01-15 14:33 UTC (permalink / raw) To: Roger Quadros Cc: devicetree, vigneshr, nsekhar, linux-kernel, Jyri Sarha, t-kristo, linux-arm-kernel On 12:00-20190111, Roger Quadros wrote: > From: Jyri Sarha <jsarha@ti.com> > > Main System control module support is added to the device tree to allow > driver to access to their control module registers. > > Signed-off-by: Jyri Sarha <jsarha@ti.com> > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 272cf8f..8b55108 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -191,4 +191,12 @@ > #address-cells = <1>; > #size-cells = <0>; > }; > + > + scm_conf: scm_conf@100000 { > + compatible = "syscon", "simple-mfd"; > + reg = <0 0x00100000 0 0x1c000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x0 0x00100000 0x1c000>; Who handles the MMR region unlock? > + }; > }; > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node 2019-01-15 14:33 ` Nishanth Menon @ 2019-01-16 10:52 ` Roger Quadros 0 siblings, 0 replies; 11+ messages in thread From: Roger Quadros @ 2019-01-16 10:52 UTC (permalink / raw) To: Nishanth Menon Cc: t-kristo, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel, Jyri Sarha On 15/01/19 16:33, Nishanth Menon wrote: > On 12:00-20190111, Roger Quadros wrote: >> From: Jyri Sarha <jsarha@ti.com> >> >> Main System control module support is added to the device tree to allow >> driver to access to their control module registers. >> >> Signed-off-by: Jyri Sarha <jsarha@ti.com> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> index 272cf8f..8b55108 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> @@ -191,4 +191,12 @@ >> #address-cells = <1>; >> #size-cells = <0>; >> }; >> + >> + scm_conf: scm_conf@100000 { >> + compatible = "syscon", "simple-mfd"; >> + reg = <0 0x00100000 0 0x1c000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x00100000 0x1c000>; > > Who handles the MMR region unlock? u-boot. > >> + }; >> }; >> -- >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support 2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros 2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros @ 2019-01-11 10:01 ` Roger Quadros 2019-01-15 14:36 ` Nishanth Menon 2019-01-11 10:01 ` [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 Roger Quadros 2019-01-15 14:33 ` [PATCH 0/3] arm64: ti: k3-am654: USB support Nishanth Menon 3 siblings, 1 reply; 11+ messages in thread From: Roger Quadros @ 2019-01-11 10:01 UTC (permalink / raw) To: t-kristo Cc: nm, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel, Roger Quadros Adds support for USB0 and USB1 instances on the AM6 SoC. USB0 is limited to high-speed for now. Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++ 1 file changed, 80 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi index 8b55108..680cbc7 100644 --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi @@ -199,4 +199,84 @@ #size-cells = <1>; ranges = <0x0 0x0 0x00100000 0x1c000>; }; + + dwc3_0: dwc3@4000000 { + compatible = "ti,am654-dwc3"; + reg = <0x0 0x4000000 0x0 0x4000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x4000000 0x20000>; + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; + dma-coherent; + status = "disabled"; + power-domains = <&k3_pds 151>; + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>; + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */ + + usb0: usb@10000 { + compatible = "snps,dwc3"; + reg = <0x10000 0x10000>; + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "peripheral", + "host", + "otg"; + maximum-speed = "high-speed"; + dr_mode = "otg"; + phys = <&usb0_phy>; + phy-names = "usb2-phy"; + snps,dis_u3_susphy_quirk; + }; + }; + + usb0_phy: phy@4100000 { + compatible = "ti,am654-usb2", "ti,omap-usb2"; + reg = <0x0 0x4100000 0x0 0x54>; + syscon-phy-power = <&scm_conf 0x4000>; + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>; + clock-names = "wkupclk", "refclk"; + #phy-cells = <0>; + status = "disabled"; + }; + + dwc3_1: dwc3@4020000 { + compatible = "ti,am654-dwc3"; + reg = <0x0 0x4020000 0x0 0x4000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0x0 0x0 0x4020000 0x20000>; + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; + dma-coherent; + status = "disabled"; + power-domains = <&k3_pds 152>; + assigned-clocks = <&k3_clks 152 2>; + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ + + usb1: usb@10000 { + compatible = "snps,dwc3"; + reg = <0x10000 0x10000>; + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "peripheral", + "host", + "otg"; + maximum-speed = "high-speed"; + dr_mode = "otg"; + phys = <&usb1_phy>; + phy-names = "usb2-phy"; + }; + }; + + usb1_phy: phy@4110000 { + compatible = "ti,am654-usb2", "ti,omap-usb2"; + reg = <0x0 0x4110000 0x0 0x54>; + syscon-phy-power = <&scm_conf 0x4020>; + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>; + clock-names = "wkupclk", "refclk"; + #phy-cells = <0>; + status = "disabled"; + }; }; -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support 2019-01-11 10:01 ` [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support Roger Quadros @ 2019-01-15 14:36 ` Nishanth Menon 2019-01-16 10:54 ` Roger Quadros 0 siblings, 1 reply; 11+ messages in thread From: Nishanth Menon @ 2019-01-15 14:36 UTC (permalink / raw) To: Roger Quadros Cc: t-kristo, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel On 12:01-20190111, Roger Quadros wrote: > Adds support for USB0 and USB1 instances on the AM6 SoC. > USB0 is limited to high-speed for now. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > index 8b55108..680cbc7 100644 > --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi > @@ -199,4 +199,84 @@ > #size-cells = <1>; > ranges = <0x0 0x0 0x00100000 0x1c000>; > }; > + > + dwc3_0: dwc3@4000000 { > + compatible = "ti,am654-dwc3"; > + reg = <0x0 0x4000000 0x0 0x4000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x0 0x4000000 0x20000>; > + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; > + dma-coherent; > + status = "disabled"; NAK. -> in ARMV8, we dont do default disabled. Instead, please disable nodes in the board dts or overlay as necessary. > + power-domains = <&k3_pds 151>; > + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>; > + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ > + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */ > + > + usb0: usb@10000 { > + compatible = "snps,dwc3"; > + reg = <0x10000 0x10000>; > + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "peripheral", > + "host", > + "otg"; > + maximum-speed = "high-speed"; > + dr_mode = "otg"; > + phys = <&usb0_phy>; > + phy-names = "usb2-phy"; > + snps,dis_u3_susphy_quirk; > + }; > + }; > + > + usb0_phy: phy@4100000 { > + compatible = "ti,am654-usb2", "ti,omap-usb2"; > + reg = <0x0 0x4100000 0x0 0x54>; > + syscon-phy-power = <&scm_conf 0x4000>; Just curious, dont we need a power domain as well? > + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>; > + clock-names = "wkupclk", "refclk"; > + #phy-cells = <0>; > + status = "disabled"; same here -> please drop > + }; > + > + dwc3_1: dwc3@4020000 { > + compatible = "ti,am654-dwc3"; > + reg = <0x0 0x4020000 0x0 0x4000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0x0 0x4020000 0x20000>; > + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; > + dma-coherent; > + status = "disabled"; same here -> please drop > + power-domains = <&k3_pds 152>; > + assigned-clocks = <&k3_clks 152 2>; > + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ > + > + usb1: usb@10000 { > + compatible = "snps,dwc3"; > + reg = <0x10000 0x10000>; > + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "peripheral", > + "host", > + "otg"; > + maximum-speed = "high-speed"; > + dr_mode = "otg"; > + phys = <&usb1_phy>; > + phy-names = "usb2-phy"; > + }; > + }; > + > + usb1_phy: phy@4110000 { > + compatible = "ti,am654-usb2", "ti,omap-usb2"; > + reg = <0x0 0x4110000 0x0 0x54>; > + syscon-phy-power = <&scm_conf 0x4020>; Same question on power domain.. > + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>; > + clock-names = "wkupclk", "refclk"; > + #phy-cells = <0>; > + status = "disabled"; same here -> please drop > + }; > }; > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support 2019-01-15 14:36 ` Nishanth Menon @ 2019-01-16 10:54 ` Roger Quadros 0 siblings, 0 replies; 11+ messages in thread From: Roger Quadros @ 2019-01-16 10:54 UTC (permalink / raw) To: Nishanth Menon Cc: devicetree, vigneshr, nsekhar, linux-kernel, t-kristo, linux-arm-kernel On 15/01/19 16:36, Nishanth Menon wrote: > On 12:01-20190111, Roger Quadros wrote: >> Adds support for USB0 and USB1 instances on the AM6 SoC. >> USB0 is limited to high-speed for now. >> >> Signed-off-by: Roger Quadros <rogerq@ti.com> >> --- >> arch/arm64/boot/dts/ti/k3-am65-main.dtsi | 80 ++++++++++++++++++++++++++++++++ >> 1 file changed, 80 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> index 8b55108..680cbc7 100644 >> --- a/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> +++ b/arch/arm64/boot/dts/ti/k3-am65-main.dtsi >> @@ -199,4 +199,84 @@ >> #size-cells = <1>; >> ranges = <0x0 0x0 0x00100000 0x1c000>; >> }; >> + >> + dwc3_0: dwc3@4000000 { >> + compatible = "ti,am654-dwc3"; >> + reg = <0x0 0x4000000 0x0 0x4000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x4000000 0x20000>; >> + interrupts = <GIC_SPI 97 IRQ_TYPE_LEVEL_HIGH>; >> + dma-coherent; >> + status = "disabled"; > > NAK. -> in ARMV8, we dont do default disabled. Instead, please disable > nodes in the board dts or overlay as necessary. got it. > >> + power-domains = <&k3_pds 151>; >> + assigned-clocks = <&k3_clks 151 2>, <&k3_clks 151 7>; >> + assigned-clock-parents = <&k3_clks 151 4>, /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ >> + <&k3_clks 151 9>; /* set PIPE3_TXB_CLK to CLK_12M_RC/256 (for HS only) */ >> + >> + usb0: usb@10000 { >> + compatible = "snps,dwc3"; >> + reg = <0x10000 0x10000>; >> + interrupts = <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 100 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "peripheral", >> + "host", >> + "otg"; >> + maximum-speed = "high-speed"; >> + dr_mode = "otg"; >> + phys = <&usb0_phy>; >> + phy-names = "usb2-phy"; >> + snps,dis_u3_susphy_quirk; >> + }; >> + }; >> + >> + usb0_phy: phy@4100000 { >> + compatible = "ti,am654-usb2", "ti,omap-usb2"; >> + reg = <0x0 0x4100000 0x0 0x54>; >> + syscon-phy-power = <&scm_conf 0x4000>; > > Just curious, dont we need a power domain as well? Not for USB2.0 PHYs. Those are part of USB3SSn power domains. > >> + clocks = <&k3_clks 151 0>, <&k3_clks 151 1>; >> + clock-names = "wkupclk", "refclk"; >> + #phy-cells = <0>; >> + status = "disabled"; > > same here -> please drop > >> + }; >> + >> + dwc3_1: dwc3@4020000 { >> + compatible = "ti,am654-dwc3"; >> + reg = <0x0 0x4020000 0x0 0x4000>; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x0 0x4020000 0x20000>; >> + interrupts = <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>; >> + dma-coherent; >> + status = "disabled"; > > same here -> please drop > >> + power-domains = <&k3_pds 152>; >> + assigned-clocks = <&k3_clks 152 2>; >> + assigned-clock-parents = <&k3_clks 152 4>; /* set REF_CLK to 20MHz i.e. PER0_PLL/48 */ >> + >> + usb1: usb@10000 { >> + compatible = "snps,dwc3"; >> + reg = <0x10000 0x10000>; >> + interrupts = <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 120 IRQ_TYPE_LEVEL_HIGH>, >> + <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>; >> + interrupt-names = "peripheral", >> + "host", >> + "otg"; >> + maximum-speed = "high-speed"; >> + dr_mode = "otg"; >> + phys = <&usb1_phy>; >> + phy-names = "usb2-phy"; >> + }; >> + }; >> + >> + usb1_phy: phy@4110000 { >> + compatible = "ti,am654-usb2", "ti,omap-usb2"; >> + reg = <0x0 0x4110000 0x0 0x54>; >> + syscon-phy-power = <&scm_conf 0x4020>; > > Same question on power domain.. > >> + clocks = <&k3_clks 152 0>, <&k3_clks 152 1>; >> + clock-names = "wkupclk", "refclk"; >> + #phy-cells = <0>; >> + status = "disabled"; > > same here -> please drop > >> + }; >> }; >> -- >> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. >> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki >> > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros 2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros 2019-01-11 10:01 ` [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support Roger Quadros @ 2019-01-11 10:01 ` Roger Quadros 2019-01-15 14:37 ` Nishanth Menon 2019-01-15 14:33 ` [PATCH 0/3] arm64: ti: k3-am654: USB support Nishanth Menon 3 siblings, 1 reply; 11+ messages in thread From: Roger Quadros @ 2019-01-11 10:01 UTC (permalink / raw) To: t-kristo Cc: nm, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel, Roger Quadros Add pinmux for USB1 and enable it as a dual role port. Signed-off-by: Roger Quadros <rogerq@ti.com> --- arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts index e41fc3a..c4f7b29 100644 --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts @@ -69,6 +69,12 @@ AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */ >; }; + + usb1_pins_default: usb1_pins_default { + pinctrl-single,pins = < + AM65X_IOPAD(0x02c0, PIN_OUTPUT, 0) /* (AC8) USB1_DRVVBUS */ + >; + }; }; &main_pmx1 { @@ -163,3 +169,17 @@ #size-cells= <1>; }; }; + +&dwc3_1 { + status = "okay"; +}; + +&usb1_phy { + status = "okay"; +}; + +&usb1 { + pinctrl-names = "default"; + pinctrl-0 = <&usb1_pins_default>; + dr_mode = "otg"; +}; -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 2019-01-11 10:01 ` [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 Roger Quadros @ 2019-01-15 14:37 ` Nishanth Menon 0 siblings, 0 replies; 11+ messages in thread From: Nishanth Menon @ 2019-01-15 14:37 UTC (permalink / raw) To: Roger Quadros Cc: devicetree, vigneshr, nsekhar, linux-kernel, t-kristo, linux-arm-kernel On 12:01-20190111, Roger Quadros wrote: > Add pinmux for USB1 and enable it as a dual role port. > > Signed-off-by: Roger Quadros <rogerq@ti.com> > --- > arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > index e41fc3a..c4f7b29 100644 > --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts > @@ -69,6 +69,12 @@ > AM65X_IOPAD(0x01bc, PIN_OUTPUT, 0) /* (AG13) SPI0_CS0 */ > >; > }; > + > + usb1_pins_default: usb1_pins_default { > + pinctrl-single,pins = < > + AM65X_IOPAD(0x02c0, PIN_OUTPUT, 0) /* (AC8) USB1_DRVVBUS */ > + >; > + }; > }; > > &main_pmx1 { > @@ -163,3 +169,17 @@ > #size-cells= <1>; > }; > }; > + > +&dwc3_1 { > + status = "okay"; > +}; > + > +&usb1_phy { > + status = "okay"; > +}; NAK -> we dont do status = "okay" in ARMV8. > + > +&usb1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&usb1_pins_default>; > + dr_mode = "otg"; > +}; > -- > Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. > Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki > -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/3] arm64: ti: k3-am654: USB support 2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros ` (2 preceding siblings ...) 2019-01-11 10:01 ` [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 Roger Quadros @ 2019-01-15 14:33 ` Nishanth Menon 2019-01-16 11:00 ` Roger Quadros 3 siblings, 1 reply; 11+ messages in thread From: Nishanth Menon @ 2019-01-15 14:33 UTC (permalink / raw) To: Roger Quadros Cc: t-kristo, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel On 12:00-20190111, Roger Quadros wrote: > Hi, > > The AM654 SoC supports 2 DWC3 USB controller instances. The > AM654 base board supports the 2nd (USB1) instance in high-speed. > > This series enables support for USB1 instance on the AM654-base-board. > > To test, you need to first apply the below 2 series. > > AM654 USB2 PHY support https://lkml.org/lkml/2018/12/5/908 > AM654 DWC3 support https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1896101.html > Please clarify if these have hit linux-next yet (I dont see anything in the threads as to being picked up yet, may be I am wrong). Once they do hit linux-next, please rebase to Tero's latest tip and repost. -- Regards, Nishanth Menon ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/3] arm64: ti: k3-am654: USB support 2019-01-15 14:33 ` [PATCH 0/3] arm64: ti: k3-am654: USB support Nishanth Menon @ 2019-01-16 11:00 ` Roger Quadros 0 siblings, 0 replies; 11+ messages in thread From: Roger Quadros @ 2019-01-16 11:00 UTC (permalink / raw) To: Nishanth Menon Cc: t-kristo, nsekhar, vigneshr, linux-arm-kernel, devicetree, linux-kernel On 15/01/19 16:33, Nishanth Menon wrote: > On 12:00-20190111, Roger Quadros wrote: >> Hi, >> >> The AM654 SoC supports 2 DWC3 USB controller instances. The >> AM654 base board supports the 2nd (USB1) instance in high-speed. >> >> This series enables support for USB1 instance on the AM654-base-board. >> >> To test, you need to first apply the below 2 series. >> >> AM654 USB2 PHY support https://lkml.org/lkml/2018/12/5/908 >> AM654 DWC3 support https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1896101.html >> > > Please clarify if these have hit linux-next yet (I dont see anything in > the threads as to being picked up yet, may be I am wrong). Once they do hit > linux-next, please rebase to Tero's latest tip and repost. > > They haven't yet. PHY patches were picked up today. cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-01-16 11:00 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-01-11 10:00 [PATCH 0/3] arm64: ti: k3-am654: USB support Roger Quadros 2019-01-11 10:00 ` [PATCH 1/3] arm64: dts: ti: am654: Add Main System Control Module node Roger Quadros 2019-01-15 14:33 ` Nishanth Menon 2019-01-16 10:52 ` Roger Quadros 2019-01-11 10:01 ` [PATCH 2/3] arm64: dts: ti: k3-am6: add USB support Roger Quadros 2019-01-15 14:36 ` Nishanth Menon 2019-01-16 10:54 ` Roger Quadros 2019-01-11 10:01 ` [PATCH 3/3] arm64: dts: ti: k3-am654-base-board: enable USB1 Roger Quadros 2019-01-15 14:37 ` Nishanth Menon 2019-01-15 14:33 ` [PATCH 0/3] arm64: ti: k3-am654: USB support Nishanth Menon 2019-01-16 11:00 ` Roger Quadros
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).