From: Lucas Stach <l.stach@pengutronix.de>
To: "Guido Günther" <agx@sigxcpu.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mq: Add system reset controller
Date: Tue, 15 Jan 2019 12:51:57 +0100 [thread overview]
Message-ID: <1547553117.4339.8.camel@pengutronix.de> (raw)
In-Reply-To: <20190115114641.GA15870@bogon.m.sigxcpu.org>
Am Dienstag, den 15.01.2019, 12:46 +0100 schrieb Guido Günther:
> We can reuse the src from fsl,imx51-src as with other imx SOCs.
That's not true. The SRC is significantly different from the i.MX51
one. See series "[PATCH v4 0/3] Reset controller support for i.MX8MQ".
We generally don't add the DT nodes until at least the binding, better
yet the full driver, is upstream.
Regards,
Lucas
>
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> I'm mostly interested in the syscon part to be able to use regmap for
> MIPI DSI here.
>
> Patch is against next-20190114 plus Lucas "arm64: dts: imx8mq: move
> watchdog nodes to correct location" but also applies to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=imx/dt64
>
> It will conflict with "arm64: dts: imx8mq: add GPC power domains" which
> is not yet in any tree I've seen.
>
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 0225eae2216e..7b1e0bdbd932 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -252,6 +252,13 @@
> > "clk_ext1", "clk_ext2",
> > "clk_ext3", "clk_ext4";
> > };
> +
> > > + src: src@30390000 {
> > + compatible = "fsl,imx8mq-src", "fsl,imx51-src", "syscon";
> > + reg = <0x30390000 0x10000>;
> > + interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > + #reset-cells = <1>;
> > + };
> > };
>
> > bus@30400000 { /* AIPS2 */
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-15 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 11:46 [PATCH] arm64: dts: imx8mq: Add system reset controller Guido Günther
2019-01-15 11:51 ` Lucas Stach [this message]
2019-01-15 12:35 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547553117.4339.8.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).