[PATCH] arm64: dts: imx8mq: Add system reset controller

[PATCH] arm64: dts: imx8mq: Add system reset controller

[Guido Günther]

We can reuse the src from fsl,imx51-src as with other imx SOCs.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
I'm mostly interested in the syscon part to be able to use regmap for
MIPI DSI here.

Patch is against next-20190114 plus Lucas "arm64: dts: imx8mq: move
watchdog nodes to correct location" but also applies to

    https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=imx/dt64

It will conflict with "arm64: dts: imx8mq: add GPC power domains" which
is not yet in any tree I've seen.

 arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
index 0225eae2216e..7b1e0bdbd932 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
@@ -252,6 +252,13 @@
 				              "clk_ext1", "clk_ext2",
 				              "clk_ext3", "clk_ext4";
 			};
+
+			src: src@30390000 {
+				compatible = "fsl,imx8mq-src", "fsl,imx51-src", "syscon";
+				reg = <0x30390000 0x10000>;
+				interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
+				#reset-cells = <1>;
+			};
 		};
 
 		bus@30400000 { /* AIPS2 */
-- 
2.20.1

Re: [PATCH] arm64: dts: imx8mq: Add system reset controller

[Lucas Stach]

Am Dienstag, den 15.01.2019, 12:46 +0100 schrieb Guido Günther:
> We can reuse the src from fsl,imx51-src as with other imx SOCs.

That's not true. The SRC is significantly different from the i.MX51
one. See series "[PATCH v4 0/3] Reset controller support for i.MX8MQ".

We generally don't add the DT nodes until at least the binding, better
yet the full driver, is upstream.

Regards,
Lucas

> 
> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> ---
> I'm mostly interested in the syscon part to be able to use regmap for
> MIPI DSI here.
> 
> Patch is against next-20190114 plus Lucas "arm64: dts: imx8mq: move
> watchdog nodes to correct location" but also applies to
> 
>     https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/log/?h=imx/dt64
> 
> It will conflict with "arm64: dts: imx8mq: add GPC power domains" which
> is not yet in any tree I've seen.
> 
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> index 0225eae2216e..7b1e0bdbd932 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> @@ -252,6 +252,13 @@
> >  				              "clk_ext1", "clk_ext2",
> >  				              "clk_ext3", "clk_ext4";
> >  			};
> +
> > > +			src: src@30390000 {
> > +				compatible = "fsl,imx8mq-src", "fsl,imx51-src", "syscon";
> > +				reg = <0x30390000 0x10000>;
> > +				interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
> > +				#reset-cells = <1>;
> > +			};
> >  		};
>  
> >  		bus@30400000 { /* AIPS2 */

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH] arm64: dts: imx8mq: Add system reset controller

[Guido Günther]

Hi,
On Tue, Jan 15, 2019 at 12:51:57PM +0100, Lucas Stach wrote:
> Am Dienstag, den 15.01.2019, 12:46 +0100 schrieb Guido Günther:
> > We can reuse the src from fsl,imx51-src as with other imx SOCs.
> 
> That's not true. The SRC is significantly different from the i.MX51
> one. See series "[PATCH v4 0/3] Reset controller support for i.MX8MQ".
> 
> We generally don't add the DT nodes until at least the binding, better
> yet the full driver, is upstream.

I guess I got carried away by the parts I needed working and mostly
requiring the syscon part. So let's hold that off, thanks for the quick
reply.

Cheers,
 -- Guido