From: Lucas Stach <l.stach@pengutronix.de>
To: "Guido Günther" <agx@sigxcpu.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Abel Vesa" <abel.vesa@nxp.com>,
devicetree@vger.kernel.org, "Shawn Guo" <shawnguo@kernel.org>
Subject: Re: [PATCH] dt-bindings: imx8mq: Number clocks consecutively
Date: Tue, 15 Jan 2019 17:53:51 +0100 [thread overview]
Message-ID: <1547571231.4339.17.camel@pengutronix.de> (raw)
In-Reply-To: <20190115163512.GA31914@bogon.m.sigxcpu.org>
Am Dienstag, den 15.01.2019, 17:35 +0100 schrieb Guido Günther:
> Signed-off-by: Guido Günther <agx@sigxcpu.org>
This is a breaking change in terms of devicetree stability. So either
we rush this into 5.0-rcX, before the current definition spreads around
or we need to drop this change. I'll leave this for Shawn (CCed) to
decide.
Regards,
Lucas
> ---
>
> include/dt-bindings/clock/imx8mq-clock.h | 26 ++++++++++++------------
> 1 file changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/include/dt-bindings/clock/imx8mq-clock.h b/include/dt-bindings/clock/imx8mq-clock.h
> index b53be41929be..04f7ac345984 100644
> --- a/include/dt-bindings/clock/imx8mq-clock.h
> +++ b/include/dt-bindings/clock/imx8mq-clock.h
> @@ -350,7 +350,7 @@
> > #define IMX8MQ_CLK_VPU_G2_ROOT 241
>
> /* SCCG PLL GATE */
> > -#define IMX8MQ_SYS1_PLL_OUT 232
> > +#define IMX8MQ_SYS1_PLL_OUT 242
> > #define IMX8MQ_SYS2_PLL_OUT 243
> > #define IMX8MQ_SYS3_PLL_OUT 244
> > #define IMX8MQ_DRAM_PLL_OUT 245
> @@ -372,24 +372,24 @@
> /* txesc clock */
> #define IMX8MQ_CLK_DSI_IPG_DIV 256
>
> > -#define IMX8MQ_CLK_TMU_ROOT 265
> > +#define IMX8MQ_CLK_TMU_ROOT 257
>
> /* Display root clocks */
> > -#define IMX8MQ_CLK_DISP_AXI_ROOT 266
> > -#define IMX8MQ_CLK_DISP_APB_ROOT 267
> > -#define IMX8MQ_CLK_DISP_RTRM_ROOT 268
> > +#define IMX8MQ_CLK_DISP_AXI_ROOT 258
> > +#define IMX8MQ_CLK_DISP_APB_ROOT 259
> > +#define IMX8MQ_CLK_DISP_RTRM_ROOT 260
>
> > -#define IMX8MQ_CLK_OCOTP_ROOT 269
> > +#define IMX8MQ_CLK_OCOTP_ROOT 261
>
> > -#define IMX8MQ_CLK_DRAM_ALT_ROOT 270
> > -#define IMX8MQ_CLK_DRAM_CORE 271
> > +#define IMX8MQ_CLK_DRAM_ALT_ROOT 262
> > +#define IMX8MQ_CLK_DRAM_CORE 263
>
> > -#define IMX8MQ_CLK_MU_ROOT 272
> > -#define IMX8MQ_VIDEO2_PLL_OUT 273
> > +#define IMX8MQ_CLK_MU_ROOT 264
> > +#define IMX8MQ_VIDEO2_PLL_OUT 265
>
> > -#define IMX8MQ_CLK_CLKO2 274
> > +#define IMX8MQ_CLK_CLKO2 266
>
> > -#define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 275
> > +#define IMX8MQ_CLK_NAND_USDHC_BUS_RAWNAND_CLK 267
>
> > -#define IMX8MQ_CLK_END 276
> > +#define IMX8MQ_CLK_END 268
> #endif /* __DT_BINDINGS_CLOCK_IMX8MQ_H */
next prev parent reply other threads:[~2019-01-15 16:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:35 [PATCH] dt-bindings: imx8mq: Number clocks consecutively Guido Günther
2019-01-15 16:49 ` Abel Vesa
2019-01-15 16:53 ` Lucas Stach [this message]
2019-01-15 17:30 ` Guido Günther
2019-01-16 3:33 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547571231.4339.17.camel@pengutronix.de \
--to=l.stach@pengutronix.de \
--cc=abel.vesa@nxp.com \
--cc=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).