devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock
@ 2019-01-16 19:45 Fabrizio Castro
  2019-01-17 12:29 ` Geert Uytterhoeven
  2019-01-17 13:11 ` Simon Horman
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrizio Castro @ 2019-01-16 19:45 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Wolfgang Grandegger, Marc Kleine-Budde,
	Michael Turquette, Stephen Boyd
  Cc: Fabrizio Castro, Simon Horman, Magnus Damm, David S. Miller,
	Geert Uytterhoeven, Thierry Reding, Andreas Färber,
	Alexandre Belloni, Kevin Hilman, Johan Hovold, Lukasz Majewski,
	Michal Simek, Michal Vokáč, Martin Blumenstingl,
	Ben Whitten, Chris Paterson, linux-renesas-soc, devicetree

This patch adds the missing CANFD clock to the r8a774c0 specific
clock driver.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>

---
The relevant documentation should appear in the next version
of the HW User's manual

v1->v2:
* appended R8A774C0_CLK_CANFD as per Geert's comment

 drivers/clk/renesas/r8a774c0-cpg-mssr.c       | 4 ++++
 include/dt-bindings/clock/r8a774c0-cpg-mssr.h | 1 +
 2 files changed, 5 insertions(+)

diff --git a/drivers/clk/renesas/r8a774c0-cpg-mssr.c b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
index 10b9689..28bcc81 100644
--- a/drivers/clk/renesas/r8a774c0-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a774c0-cpg-mssr.c
@@ -33,6 +33,7 @@ enum clk_ids {
 	CLK_PLL1,
 	CLK_PLL3,
 	CLK_PLL0D4,
+	CLK_PLL0D6,
 	CLK_PLL0D8,
 	CLK_PLL0D20,
 	CLK_PLL0D24,
@@ -61,6 +62,7 @@ static const struct cpg_core_clk r8a774c0_core_clks[] __initconst = {
 
 	DEF_FIXED(".pll0",     CLK_PLL0,           CLK_MAIN,	   1, 100),
 	DEF_FIXED(".pll0d4",   CLK_PLL0D4,         CLK_PLL0,       4, 1),
+	DEF_FIXED(".pll0d6",   CLK_PLL0D6,         CLK_PLL0,       6, 1),
 	DEF_FIXED(".pll0d8",   CLK_PLL0D8,         CLK_PLL0,       8, 1),
 	DEF_FIXED(".pll0d20",  CLK_PLL0D20,        CLK_PLL0,      20, 1),
 	DEF_FIXED(".pll0d24",  CLK_PLL0D24,        CLK_PLL0,      24, 1),
@@ -112,6 +114,7 @@ static const struct cpg_core_clk r8a774c0_core_clks[] __initconst = {
 	DEF_GEN3_PE("s3d2c",   R8A774C0_CLK_S3D2C, CLK_S3, 2, CLK_PE, 2),
 	DEF_GEN3_PE("s3d4c",   R8A774C0_CLK_S3D4C, CLK_S3, 4, CLK_PE, 4),
 
+	DEF_DIV6P1("canfd",    R8A774C0_CLK_CANFD, CLK_PLL0D6, 0x244),
 	DEF_DIV6P1("csi0",     R8A774C0_CLK_CSI0,  CLK_PLL1D2, 0x00c),
 	DEF_DIV6P1("mso",      R8A774C0_CLK_MSO,   CLK_PLL1D2, 0x014),
 
@@ -187,6 +190,7 @@ static const struct mssr_mod_clk r8a774c0_mod_clks[] __initconst = {
 	DEF_MOD("gpio2",		 910,	R8A774C0_CLK_S3D4),
 	DEF_MOD("gpio1",		 911,	R8A774C0_CLK_S3D4),
 	DEF_MOD("gpio0",		 912,	R8A774C0_CLK_S3D4),
+	DEF_MOD("can-fd",		 914,	R8A774C0_CLK_S3D2),
 	DEF_MOD("can-if1",		 915,	R8A774C0_CLK_S3D4),
 	DEF_MOD("can-if0",		 916,	R8A774C0_CLK_S3D4),
 	DEF_MOD("i2c6",			 918,	R8A774C0_CLK_S3D2),
diff --git a/include/dt-bindings/clock/r8a774c0-cpg-mssr.h b/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
index 8fe51b6..8ad9cd6 100644
--- a/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
+++ b/include/dt-bindings/clock/r8a774c0-cpg-mssr.h
@@ -56,5 +56,6 @@
 #define R8A774C0_CLK_CSI0		45
 #define R8A774C0_CLK_CP			46
 #define R8A774C0_CLK_CPEX		47
+#define R8A774C0_CLK_CANFD		48
 
 #endif /* __DT_BINDINGS_CLOCK_R8A774C0_CPG_MSSR_H__ */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock
  2019-01-16 19:45 [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock Fabrizio Castro
@ 2019-01-17 12:29 ` Geert Uytterhoeven
  2019-01-17 13:11 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-01-17 12:29 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Rob Herring, Mark Rutland, Wolfgang Grandegger, Marc Kleine-Budde,
	Michael Turquette, Stephen Boyd, Simon Horman, Magnus Damm,
	David S. Miller, Geert Uytterhoeven, Thierry Reding,
	Andreas Färber, Alexandre Belloni, Kevin Hilman,
	Johan Hovold, Lukasz Majewski, Michal Simek,
	Michal Vokáč

On Wed, Jan 16, 2019 at 8:45 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> This patch adds the missing CANFD clock to the r8a774c0 specific
> clock driver.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
>
> ---
> The relevant documentation should appear in the next version
> of the HW User's manual
>
> v1->v2:
> * appended R8A774C0_CLK_CANFD as per Geert's comment

Thanks for the update!

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in clk-renesas-for-v5.1.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock
  2019-01-16 19:45 [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock Fabrizio Castro
  2019-01-17 12:29 ` Geert Uytterhoeven
@ 2019-01-17 13:11 ` Simon Horman
  1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-01-17 13:11 UTC (permalink / raw)
  To: Fabrizio Castro
  Cc: Rob Herring, Mark Rutland, Wolfgang Grandegger, Marc Kleine-Budde,
	Michael Turquette, Stephen Boyd, Magnus Damm, David S. Miller,
	Geert Uytterhoeven, Thierry Reding, Andreas Färber,
	Alexandre Belloni, Kevin Hilman, Johan Hovold, Lukasz Majewski,
	Michal Simek, Michal Vokáč, Martin Blumenstingl

On Wed, Jan 16, 2019 at 07:45:45PM +0000, Fabrizio Castro wrote:
> This patch adds the missing CANFD clock to the r8a774c0 specific
> clock driver.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <Chris.Paterson2@renesas.com>
> 
> ---
> The relevant documentation should appear in the next version
> of the HW User's manual
> 
> v1->v2:
> * appended R8A774C0_CLK_CANFD as per Geert's comment


Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-01-17 13:11 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 19:45 [PATCH v2 08/11] clk: renesas: r8a774c0: Add missing CANFD clock Fabrizio Castro
2019-01-17 12:29 ` Geert Uytterhoeven
2019-01-17 13:11 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).