From: Min Guo <min.guo@mediatek.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Bin Liu <b-liu@ti.com>, Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Alan Stern <stern@rowland.harvard.edu>,
chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, tony@atomide.com,
hdegoede@redhat.com
Subject: Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller
Date: Thu, 17 Jan 2019 20:41:16 +0800 [thread overview]
Message-ID: <1547728876.4433.237.camel@mhfsdcap03> (raw)
In-Reply-To: <15fb900e-c665-8ebd-b2cc-54f47cc35734@cogentembedded.com>
Hello!
On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote:
> Hello!
>
> On 01/17/2019 10:15 AM, min.guo@mediatek.com wrote:
>
> > From: Min Guo <min.guo@mediatek.com>
> >
> > This adds support for MediaTek musb controller in
> > host, peripheral and otg mode.
> >
> > Signed-off-by: Min Guo <min.guo@mediatek.com>
> > ---
> > .../devicetree/bindings/usb/mediatek,musb.txt | 43 ++++++++++++++++++++++
> > 1 file changed, 43 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/usb/mediatek,musb.txt
> >
> > diff --git a/Documentation/devicetree/bindings/usb/mediatek,musb.txt b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > new file mode 100644
> > index 0000000..3e3f671
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/usb/mediatek,musb.txt
> > @@ -0,0 +1,43 @@
> > +MediaTek musb DRD/OTG controller
> > +-------------------------------------------
> > +
> > +Required properties:
> > + - compatible : should be "mediatek,mtk-musb"
> > + - reg : specifies physical base address and size of
> > + the registers
>
> I'd indent it more to align with "specifies", else it looks weird.
Okay.
> > + - interrupts : interrupt used by musb controller
> > + - interrupt-names : must be "mc"
> > + - phys : PHY specifier for the OTG phy
> > + - dr_mode : should be one of "host", "peripheral" or "otg",
> > + refer to usb/generic.txt
>
> Same here...
Okay.
> > + - clocks : a list of phandle + clock-specifier pairs, one for
> > + each entry in clock-names
>
> Here...
Okay.
> > + - clock-names : must contain "main", "mcu", "univpll"
> > + for clocks of controller
>
> And here.
Okay.
> > +
> > +Optional properties:
> > + - extcon : external connector for VBUS and IDPIN changes detection,
>
> ID pin, maybe?
Okay.
> > + needed when supports dual-role mode.
> > + - vbus-supply : reference to the VBUS regulator, needed when supports
> > + dual-role mode.
> > + - power-domains : a phandle to USB power domain node to control USB's
> > + MTCMOS
> [...]
>
> MBR, Sergei
next prev parent reply other threads:[~2019-01-17 12:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 7:15 [PATCH v3 0/4] Add MediaTek MUSB Controller Driver min.guo
2019-01-17 7:15 ` [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller min.guo
2019-01-17 11:06 ` Sergei Shtylyov
2019-01-17 12:41 ` Min Guo [this message]
2019-01-17 7:15 ` [PATCH v3 2/4] arm: dts: mt2701: Add usb2 device nodes min.guo
2019-01-17 7:15 ` [PATCH v3 3/4] usb: musb: Delete the const attribute of addr parameter in readb/w/l hooks min.guo
2019-01-17 7:15 ` [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller min.guo
2019-01-17 14:33 ` Tony Lindgren
2019-01-18 6:14 ` Min Guo
2019-01-18 13:34 ` Bin Liu
2019-01-21 1:08 ` Min Guo
2019-01-17 15:00 ` [PATCH v3 0/4] Add MediaTek MUSB Controller Driver Bin Liu
2019-01-18 1:17 ` Min Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1547728876.4433.237.camel@mhfsdcap03 \
--to=min.guo@mediatek.com \
--cc=b-liu@ti.com \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stern@rowland.harvard.edu \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).