* [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies
@ 2018-12-13 2:27 Ryder Lee
2018-12-13 4:21 ` Sean Wang
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Ryder Lee @ 2018-12-13 2:27 UTC (permalink / raw)
To: Linus Walleij, Sean Wang
Cc: Matthias Brugger, Weijie Gao, linux-gpio, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Ryder Lee
Remove prompts to make all pinctrl cores to non-visible symbols and
make sure the target SoCs would be coupled with the corresponding
cores.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
---
Changes since v1:
- Revise commit message
- Change all pinctrl cores to non-visible symbols
- Drop EINT_MTK in PINCTRL_MTK_MOORE
---
drivers/pinctrl/mediatek/Kconfig | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
index d8cb584..1817786 100644
--- a/drivers/pinctrl/mediatek/Kconfig
+++ b/drivers/pinctrl/mediatek/Kconfig
@@ -17,7 +17,7 @@ config PINCTRL_MTK
select OF_GPIO
config PINCTRL_MTK_MOORE
- bool "MediaTek Moore Core that implements generic binding"
+ bool
depends on OF
select GENERIC_PINCONF
select GENERIC_PINCTRL_GROUPS
@@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE
select OF_GPIO
config PINCTRL_MTK_PARIS
- bool "MediaTek Paris Core that implements vendor binding"
+ bool
depends on OF
select PINMUX
select GENERIC_PINCONF
@@ -45,14 +45,14 @@ config PINCTRL_MT2701
config PINCTRL_MT7623
bool "Mediatek MT7623 pin control with generic binding"
depends on MACH_MT7623 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default MACH_MT7623
+ select PINCTRL_MTK_MOORE
config PINCTRL_MT7629
bool "Mediatek MT7629 pin control"
depends on MACH_MT7629 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default MACH_MT7629
+ select PINCTRL_MTK_MOORE
config PINCTRL_MT8135
bool "Mediatek MT8135 pin control"
@@ -93,8 +93,8 @@ config PINCTRL_MT6797
config PINCTRL_MT7622
bool "MediaTek MT7622 pin control"
depends on ARM64 || COMPILE_TEST
- depends on PINCTRL_MTK_MOORE
- default y
+ default ARM64 && ARCH_MEDIATEK
+ select PINCTRL_MTK_MOORE
config PINCTRL_MT8173
bool "Mediatek MT8173 pin control"
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies
2018-12-13 2:27 [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies Ryder Lee
@ 2018-12-13 4:21 ` Sean Wang
2018-12-13 16:49 ` Kevin Hilman
2018-12-21 10:17 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Sean Wang @ 2018-12-13 4:21 UTC (permalink / raw)
To: Ryder Lee (李庚諺)
Cc: Linus Walleij, Matthias Brugger, weijie.gao, linux-gpio,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek
It looks good to me. Thanks for bringing the improved version soon.
Acked-by: Sean Wang <sean.wang@kernel.org>
On Wed, Dec 12, 2018 at 6:28 PM Ryder Lee <ryder.lee@mediatek.com> wrote:
>
> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> ---
> Changes since v1:
> - Revise commit message
> - Change all pinctrl cores to non-visible symbols
> - Drop EINT_MTK in PINCTRL_MTK_MOORE
> ---
> drivers/pinctrl/mediatek/Kconfig | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig
> index d8cb584..1817786 100644
> --- a/drivers/pinctrl/mediatek/Kconfig
> +++ b/drivers/pinctrl/mediatek/Kconfig
> @@ -17,7 +17,7 @@ config PINCTRL_MTK
> select OF_GPIO
>
> config PINCTRL_MTK_MOORE
> - bool "MediaTek Moore Core that implements generic binding"
> + bool
> depends on OF
> select GENERIC_PINCONF
> select GENERIC_PINCTRL_GROUPS
> @@ -26,7 +26,7 @@ config PINCTRL_MTK_MOORE
> select OF_GPIO
>
> config PINCTRL_MTK_PARIS
> - bool "MediaTek Paris Core that implements vendor binding"
> + bool
> depends on OF
> select PINMUX
> select GENERIC_PINCONF
> @@ -45,14 +45,14 @@ config PINCTRL_MT2701
> config PINCTRL_MT7623
> bool "Mediatek MT7623 pin control with generic binding"
> depends on MACH_MT7623 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default MACH_MT7623
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT7629
> bool "Mediatek MT7629 pin control"
> depends on MACH_MT7629 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default MACH_MT7629
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT8135
> bool "Mediatek MT8135 pin control"
> @@ -93,8 +93,8 @@ config PINCTRL_MT6797
> config PINCTRL_MT7622
> bool "MediaTek MT7622 pin control"
> depends on ARM64 || COMPILE_TEST
> - depends on PINCTRL_MTK_MOORE
> - default y
> + default ARM64 && ARCH_MEDIATEK
> + select PINCTRL_MTK_MOORE
>
> config PINCTRL_MT8173
> bool "Mediatek MT8173 pin control"
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies
2018-12-13 2:27 [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies Ryder Lee
2018-12-13 4:21 ` Sean Wang
@ 2018-12-13 16:49 ` Kevin Hilman
2018-12-21 10:17 ` Linus Walleij
2 siblings, 0 replies; 5+ messages in thread
From: Kevin Hilman @ 2018-12-13 16:49 UTC (permalink / raw)
To: Linus Walleij, Sean Wang
Cc: Matthias Brugger, Weijie Gao, linux-gpio, devicetree,
linux-kernel, linux-arm-kernel, linux-mediatek, Ryder Lee
Ryder Lee <ryder.lee@mediatek.com> writes:
> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
Tested on the mt7623-rfb1 board which has been failing in kernelCI, and
this patch gets things booting again.
Kevin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies
2018-12-13 2:27 [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies Ryder Lee
2018-12-13 4:21 ` Sean Wang
2018-12-13 16:49 ` Kevin Hilman
@ 2018-12-21 10:17 ` Linus Walleij
2019-01-22 14:00 ` Ryder Lee
2 siblings, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2018-12-21 10:17 UTC (permalink / raw)
To: Ryder Lee
Cc: Sean Wang, Matthias Brugger, Weijie Gao, open list:GPIO SUBSYSTEM,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
linux-kernel@vger.kernel.org, Linux ARM,
moderated list:ARM/Mediatek SoC support
On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <ryder.lee@mediatek.com> wrote:
> Remove prompts to make all pinctrl cores to non-visible symbols and
> make sure the target SoCs would be coupled with the corresponding
> cores.
>
> Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Patch applied with ACK and Tested-by.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies
2018-12-21 10:17 ` Linus Walleij
@ 2019-01-22 14:00 ` Ryder Lee
0 siblings, 0 replies; 5+ messages in thread
From: Ryder Lee @ 2019-01-22 14:00 UTC (permalink / raw)
To: Linus Walleij
Cc: open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sean Wang, Weijie Gao (高惟杰),
linux-kernel@vger.kernel.org, stable, open list:GPIO SUBSYSTEM,
moderated list:ARM/Mediatek SoC support, Matthias Brugger,
Linux ARM
CC: stable@vger.kernel.org
On Fri, 2018-12-21 at 18:17 +0800, Linus Walleij wrote:
> On Thu, Dec 13, 2018 at 3:28 AM Ryder Lee <ryder.lee@mediatek.com> wrote:
>
> > Remove prompts to make all pinctrl cores to non-visible symbols and
> > make sure the target SoCs would be coupled with the corresponding
> > cores.
> >
> > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
>
> Patch applied with ACK and Tested-by.
>
> Yours,
> Linus Walleij
I forgot to add stable-kernel into CC list.
This patch should be applied to stable-rc linux-4.20.y.
Sorry for the inconvenience.
Ryder
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-01-22 14:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-13 2:27 [PATCH v1] pinctrl: mediatek: improve Kconfig dependencies Ryder Lee
2018-12-13 4:21 ` Sean Wang
2018-12-13 16:49 ` Kevin Hilman
2018-12-21 10:17 ` Linus Walleij
2019-01-22 14:00 ` Ryder Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).