From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"Michal Vokáč" <michal.vokac@ysoft.com>
Subject: [PATCH RESEND v2 3/4] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity
Date: Mon, 28 Jan 2019 12:53:02 +0100 [thread overview]
Message-ID: <1548676383-29685-4-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1548676383-29685-1-git-send-email-michal.vokac@ysoft.com>
The reset signal of the SSD1306 OLED display is actually active-low.
Adapt the DT to reflect the real world.
Reviewed-by: Rob Herring <robh@kernel.org>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
Changes in v2 resend:
- Add Acked-by from Alexandre.
Changes from v1:
- Add R-by from Rob
arch/arm/boot/dts/imx28-cfa10036.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx28-cfa10036.dts b/arch/arm/boot/dts/imx28-cfa10036.dts
index d3e3622..de48b58 100644
--- a/arch/arm/boot/dts/imx28-cfa10036.dts
+++ b/arch/arm/boot/dts/imx28-cfa10036.dts
@@ -11,6 +11,7 @@
/dts-v1/;
#include "imx28.dtsi"
+#include <dt-bindings/gpio/gpio.h>
/ {
model = "Crystalfontz CFA-10036 Board";
@@ -96,7 +97,7 @@
pinctrl-names = "default";
pinctrl-0 = <&ssd1306_cfa10036>;
reg = <0x3c>;
- reset-gpios = <&gpio2 7 0>;
+ reset-gpios = <&gpio2 7 GPIO_ACTIVE_LOW>;
solomon,height = <32>;
solomon,width = <128>;
solomon,page-offset = <0>;
--
2.1.4
next prev parent reply other threads:[~2019-01-28 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190128115430epcas1p243804249cd6c841166eb6cd5a504ce22@epcas1p2.samsung.com>
2019-01-28 11:52 ` [PATCH RESEND v2 0/4] Fix ssd1307fb OLED driver reset Michal Vokáč
2019-01-28 11:53 ` [PATCH RESEND v2 1/4] dt-bindings: display: ssd1307fb: Remove reset-active-low from examples Michal Vokáč
2019-01-28 11:53 ` [PATCH RESEND v2 2/4] video: ssd1307fb: Do not hard code active-low reset sequence Michal Vokáč
2019-01-28 11:53 ` Michal Vokáč [this message]
2019-01-28 11:53 ` [PATCH RESEND v2 4/4] ARM: mxs: cfa10036: Fixup OLED display reset polarity Michal Vokáč
2019-02-08 17:54 ` [PATCH혻RESEND v2 0/4] Fix ssd1307fb OLED driver reset Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548676383-29685-4-git-send-email-michal.vokac@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).