From: "Michal Vokáč" <michal.vokac@ysoft.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
"Michal Vokáč" <michal.vokac@ysoft.com>
Subject: [PATCH RESEND v2 4/4] ARM: mxs: cfa10036: Fixup OLED display reset polarity
Date: Mon, 28 Jan 2019 12:53:03 +0100 [thread overview]
Message-ID: <1548676383-29685-5-git-send-email-michal.vokac@ysoft.com> (raw)
In-Reply-To: <1548676383-29685-1-git-send-email-michal.vokac@ysoft.com>
There was a bug in reset signal generation in ssd1307fb OLED driver.
The display needs an active-low reset signal but the driver produced
the correct sequence only if the GPIO used for reset was specified as
GPIO_ACTIVE_HIGH.
Now as the OLED driver is fixed it is also necessarry to implement
a fixup for all current users of the old DT ABI. There is only one
in-tree user and that is the Crystalfontz CFA-10036 board. In case
this board is booting and GPIO_ACTIVE_HIGH is used for reset we
override it to GPIO_ACTIVE_LOW.
Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
Changes from v1:
- Add R-by from Rob
- Use of_property_read_variable_u32_array to read the GPIO specifier
array instead of reading it manualy in for cycle. (Rob)
arch/arm/mach-mxs/mach-mxs.c | 44 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 44 insertions(+)
diff --git a/arch/arm/mach-mxs/mach-mxs.c b/arch/arm/mach-mxs/mach-mxs.c
index 1c6062d..50038d6 100644
--- a/arch/arm/mach-mxs/mach-mxs.c
+++ b/arch/arm/mach-mxs/mach-mxs.c
@@ -21,6 +21,7 @@
#include <linux/reboot.h>
#include <linux/micrel_phy.h>
#include <linux/of_address.h>
+#include <linux/of_gpio.h>
#include <linux/of_platform.h>
#include <linux/phy.h>
#include <linux/pinctrl/consumer.h>
@@ -268,9 +269,52 @@ static void __init apx4devkit_init(void)
apx4devkit_phy_fixup);
}
+#define OLED_RESET_GPIO_LEN 3
+#define OLED_RESET_GPIO_SIZE (OLED_RESET_GPIO_LEN * sizeof(u32))
+
+static void __init crystalfontz_oled_reset_fixup(void)
+{
+ struct property *newgpio;
+ struct device_node *np;
+ u32 *gpiospec;
+ int ret;
+
+ np = of_find_compatible_node(NULL, NULL, "solomon,ssd1306fb-i2c");
+ if (!np)
+ return;
+
+ newgpio = kzalloc(sizeof(*newgpio) + OLED_RESET_GPIO_SIZE, GFP_KERNEL);
+ if (!newgpio)
+ return;
+
+ newgpio->value = newgpio + 1;
+ newgpio->length = OLED_RESET_GPIO_SIZE;
+ newgpio->name = kstrdup("reset-gpios", GFP_KERNEL);
+ if (!newgpio->name) {
+ kfree(newgpio);
+ return;
+ }
+
+ gpiospec = newgpio->value;
+ ret = of_property_read_variable_u32_array(np, "reset-gpios", gpiospec,
+ OLED_RESET_GPIO_LEN, 0);
+
+ if (ret < 0) {
+ kfree(newgpio);
+ return;
+ }
+
+ if (!(gpiospec[2] & OF_GPIO_ACTIVE_LOW)) {
+ gpiospec[2] |= OF_GPIO_ACTIVE_LOW;
+ cpu_to_be32_array(gpiospec, gpiospec, OLED_RESET_GPIO_LEN);
+ of_update_property(np, newgpio);
+ }
+}
+
static void __init crystalfontz_init(void)
{
update_fec_mac_prop(OUI_CRYSTALFONTZ);
+ crystalfontz_oled_reset_fixup();
}
static void __init duckbill_init(void)
--
2.1.4
next prev parent reply other threads:[~2019-01-28 11:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190128115430epcas1p243804249cd6c841166eb6cd5a504ce22@epcas1p2.samsung.com>
2019-01-28 11:52 ` [PATCH RESEND v2 0/4] Fix ssd1307fb OLED driver reset Michal Vokáč
2019-01-28 11:53 ` [PATCH RESEND v2 1/4] dt-bindings: display: ssd1307fb: Remove reset-active-low from examples Michal Vokáč
2019-01-28 11:53 ` [PATCH RESEND v2 2/4] video: ssd1307fb: Do not hard code active-low reset sequence Michal Vokáč
2019-01-28 11:53 ` [PATCH RESEND v2 3/4] ARM: dts: imx28-cfa10036: Fix the reset gpio signal polarity Michal Vokáč
2019-01-28 11:53 ` Michal Vokáč [this message]
2019-02-08 17:54 ` [PATCH혻RESEND v2 0/4] Fix ssd1307fb OLED driver reset Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1548676383-29685-5-git-send-email-michal.vokac@ysoft.com \
--to=michal.vokac@ysoft.com \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).