From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: Add Ingenic X1000 RTC support. Date: Mon, 28 Jan 2019 17:48:04 -0300 Message-ID: <1548708484.7511.3@crapouillou.net> References: <1548696599-53639-1-git-send-email-zhouyanjie@zoho.com> <20190128201014.GB18309@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Return-path: In-Reply-To: <20190128201014.GB18309@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Zhou Yanjie , Lars-Peter Clausen , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, a.zummo@towertech.it, robh+dt@kernel.org, paul.burton@mips.com, mark.rutland@arm.com, syq@debian.org, jiaxun.yang@flygoat.com, 772753199@qq.com List-Id: devicetree@vger.kernel.org Hi, > Hello, > > This seems like a useless renaming to me, can you elaborate a bit > more? > > I'd also like to have Paul and Lars-Peter comment. According to the patchset, the RTC in the X1000 does not behave any different than the one in the JZ4780 SoC. Therefore patches 1/2 should be dropped. In your devicetree bindings, just use the "ingenic,jz4780-rtc" compatible string instead. The same goes for all the drivers (e.g. the uart one). I don't really mind the renaming, maybe replace "Ingenic JZ47xx SoCs" with just "Ingenic SoCs" since XBurst is just the name of the CPU inside these SoCs. Regards, -Paul