From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lucas Stach Subject: Re: [PATCH] ARC: [plat-hsdk]: Add support of Vivante GPU Date: Tue, 29 Jan 2019 15:18:07 +0100 Message-ID: <1548771487.6869.5.camel@pengutronix.de> References: <20190129124146.5398-1-Eugeniy.Paltsev@synopsys.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20190129124146.5398-1-Eugeniy.Paltsev@synopsys.com> Sender: linux-kernel-owner@vger.kernel.org To: Eugeniy Paltsev , linux-snps-arc@lists.infradead.org, Vineet Gupta Cc: linux-kernel@vger.kernel.org, Alexey Brodkin , Rob Herring , devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org Am Dienstag, den 29.01.2019, 15:41 +0300 schrieb Eugeniy Paltsev: > HSDK board has built-in Vivante GPU IP which works perfectly fine > with Etnaviv driver, so let's use it. > > > Signed-off-by: Eugeniy Paltsev > --- > NOTE: >  * this patch has prerequisite: >    https://patchwork.kernel.org/patch/10766265/ > >  arch/arc/boot/dts/hsdk.dts      | 6 ++++++ >  arch/arc/configs/hsdk_defconfig | 2 +- >  2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts > index 43f17b51ee89..ef892994f024 100644 > --- a/arch/arc/boot/dts/hsdk.dts > +++ b/arch/arc/boot/dts/hsdk.dts > @@ -237,6 +237,12 @@ > >   reg = <0>; > >   }; > >   }; > + > > > + gpu_3d: gpu@90000 { > > + compatible = "vivante,gc"; > > + reg = <0x90000 0x4000>; > + interrupts = <28>; Really no clock inputs? While the driver does not enforce this due to backward compatibility issues, the binding says that some of the clocks are mandatory. So I would really like to see them hooked up here, even if it's just fixed always-on clocks. Regards, Lucas > + }; > >   }; >   > >   memory@80000000 { > diff --git a/arch/arc/configs/hsdk_defconfig b/arch/arc/configs/hsdk_defconfig > index 87b23b7fb781..915e1cca31f8 100644 > --- a/arch/arc/configs/hsdk_defconfig > +++ b/arch/arc/configs/hsdk_defconfig > @@ -52,6 +52,7 @@ CONFIG_GPIO_DWAPB=y >  CONFIG_DRM=y >  # CONFIG_DRM_FBDEV_EMULATION is not set >  CONFIG_DRM_UDL=y > +CONFIG_DRM_ETNAVIV=y >  CONFIG_FB=y >  CONFIG_FRAMEBUFFER_CONSOLE=y >  CONFIG_USB_EHCI_HCD=y > @@ -63,7 +64,6 @@ CONFIG_MMC=y >  CONFIG_MMC_SDHCI=y >  CONFIG_MMC_SDHCI_PLTFM=y >  CONFIG_MMC_DW=y > -# CONFIG_IOMMU_SUPPORT is not set >  CONFIG_EXT3_FS=y >  CONFIG_VFAT_FS=y >  CONFIG_TMPFS=y